Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-tls-subcerts-12

Nick Sullivan <nick@cloudflare.com> Tue, 14 June 2022 19:48 UTC

Return-Path: <nick@cloudflare.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 22062C157B54 for <gen-art@ietfa.amsl.com>; Tue, 14 Jun 2022 12:48:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.109
X-Spam-Level:
X-Spam-Status: No, score=-2.109 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cloudflare.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zRC2W1-JtDYo for <gen-art@ietfa.amsl.com>; Tue, 14 Jun 2022 12:48:07 -0700 (PDT)
Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 49B3BC159490 for <gen-art@ietf.org>; Tue, 14 Jun 2022 12:47:32 -0700 (PDT)
Received: by mail-io1-xd32.google.com with SMTP id e80so10519711iof.3 for <gen-art@ietf.org>; Tue, 14 Jun 2022 12:47:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BaF2y6O+ZOLt7s2RYJIkNJ4TIGr/0M5T4lVZRx/bpUc=; b=TdNxAw8UyyXTrLOOmmmpfvyjfCim1N+zSOJ3vRnP1r08o0UDXZqe5RRjuX1HkIjsc9 Qb7bihvqacHRwrjjJdXwtJyf68iyyuH2A4wcXQvpG3E0G7//a5nOR9XKHT4TARBU9U4f 3P91e6tzcLhQNSTgAsqqa8FQ3fjcItTyFxMjQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BaF2y6O+ZOLt7s2RYJIkNJ4TIGr/0M5T4lVZRx/bpUc=; b=Erb5A2BkY0WuOWrH5MmA441uN9kuSJeDsdOi0mFjcinWj4HvF2CMFCfvGy44tQzR86 j5HwTZ5VNAUHHzLdJ4wZvvlLZCA5cj2MBYk0JKzD5WJXlqxEKKoLnIn6kTyD5AEPsjSY DqA9H7lHlrFym6PN/CkIWmEXyCLl8Sd4EWsaT8q7UzRd14Je3ryhcziRIjVitNsbp/iz WGUdaR/w5yS0ysQsQJvUXeysgkw7p4FwGYIjB+j4CUgktASMPplZE8FxmQsg96yrDzQ4 FCPJN4vZG/ad5AsudhcM+oEI5eLu4aaxQQbbdlpV5LEYpNDUVZsNc81qKUpsJbTiiXWS JeUw==
X-Gm-Message-State: AOAM532zNZdXSO4v9qwEwShZxPoMxEIQL/9ZkvP5EnNTW8eUxmVObEML wAdUyeCrLyzvMmfhqm5PB6agBxYB6monM01EuyTpFA==
X-Google-Smtp-Source: ABdhPJzmHOEudv2p4AmIu/ma2p/UXoNIFXie43tA/MEnnI5ncKSfHlq5AlIc08wyDBxjKlWPvFNg7eyjuUzoSd57NS8=
X-Received: by 2002:a05:6638:218c:b0:331:a10e:7702 with SMTP id s12-20020a056638218c00b00331a10e7702mr3800760jaj.147.1655236050790; Tue, 14 Jun 2022 12:47:30 -0700 (PDT)
MIME-Version: 1.0
References: <164946350444.3243.13599547539306150042@ietfa.amsl.com> <B475925D-F0C2-4402-9B78-BDAD9B32F6CB@eggert.org>
In-Reply-To: <B475925D-F0C2-4402-9B78-BDAD9B32F6CB@eggert.org>
From: Nick Sullivan <nick@cloudflare.com>
Date: Tue, 14 Jun 2022 15:47:15 -0400
Message-ID: <CAFDDyk-nawOohLhdgGEbS5LpO6F0HuAz43sSFhZj0MehiJCSWg@mail.gmail.com>
To: Lars Eggert <lars@eggert.org>
Cc: Elwyn Davies <elwynd@dial.pipex.com>, General Area Review Team <gen-art@ietf.org>, last-call@ietf.org, draft-ietf-tls-subcerts.all@ietf.org, "<tls@ietf.org>" <tls@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000d3cd7205e16dacf2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Fp0C4HNZvInHy2N7LmMMd-jF_Lo>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-tls-subcerts-12
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jun 2022 19:48:08 -0000

Thanks Elwyn,

I've updated the document in Github to address your nits (
https://github.com/tlswg/tls-subcerts/pull/108/files).

Best,
Nick

On Wed, May 25, 2022 at 5:20 AM Lars Eggert <lars@eggert.org> wrote:

> Elwyn, thank you for your review. I have entered a No Objection ballot for
> this document.
>
> Lars
>
>
> > On 2022-4-9, at 3:18, Elwyn Davies via Datatracker <noreply@ietf.org>
> wrote:
> >
> > Reviewer: Elwyn Davies
> > Review result: Ready with Nits
> >
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed
> > by the IESG for the IETF Chair.  Please treat these comments just
> > like any other last call comments.
> >
> > For more information, please see the FAQ at
> >
> > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> >
> > Document: draft-ietf-tls-subcerts-??
> > Reviewer: Elwyn Davies
> > Review Date: 2022-04-08
> > IETF LC End Date: 2022-04-08
> > IESG Telechat date: Not scheduled for a telechat
> >
> > Summary:
> > Ready with nits.    Just a few editrial level nits.
> >
> > Major issues:
> > None
> >
> > Minor issues:
> > None.
> >
> > Nits/editorial comments:
> > Abstract: The exact form of the abbreviation (D)TLS is not in the set of
> > well-known abbreviations.  I assume it is supposed to mean DTLS or TLS -
> This
> > ought to be expanded on first use.
> >
> > Abstract:  s/mechanism to to/mechanism to/
> >
> > s1, para 2: CA is used before its expansion in para 3.
> >
> > s1, next to last para: "this document proposes"  Hopefully when it
> becomes an
> > RFC it will do more than propose.  Suggest "this document introduces".
> >
> > s1, next to last para:  "to speak for names"  sounds a bit
> anthropomorphic to
> > me, but I can't think of a simple alternative word.
> >
> > s1, last para: s/We will refer/This document refers/  [Not an academic
> paper!]
> >
> > s3.1, 2nd bullet: s/provide are not necessary/provide is not necessary/
> >
> > s4, definition of expected_cert_verify_algorithm:  " Only signature
> algorithms
> > allowed for use in CertificateVerify message are allowed."  Does this
> need a
> > reference to the place where the list of such algorithms is recorded?
> >
> > s4.1.1 and s4.1.2:  In s4.1.1:  "the client SHOULD ignore delegated
> credentials
> > sent as extensions to any other certificate."  I would have though this
> ought
> > to be a MUST.  There is an equivalent in s4.1.2. I am not sure what the
> > client/server might do if it doesn't ignore the DC.
> >
> > s4.1.3, para 1: s/same way that is done/same way that it is done/
> >
> > s4.2, para 1: s/We define/This docuent defines/
> >
> > sS/s5.1: RFC conventions prefer not to have sections empty of text:  Add
> > something like: "The following operational consideration should be taken
> into
> > consideration when using Delegated Certificates:"
> >
> >
> >
> > --
> > last-call mailing list
> > last-call@ietf.org
> > https://www.ietf.org/mailman/listinfo/last-call
>
>