Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10

Rifaat Shekh-Yusef <rifaat.ietf@gmail.com> Tue, 22 October 2019 19:55 UTC

Return-Path: <rifaat.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B8E291200D6; Tue, 22 Oct 2019 12:55:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wWRn-1lkD9qK; Tue, 22 Oct 2019 12:55:43 -0700 (PDT)
Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A51D5120077; Tue, 22 Oct 2019 12:55:40 -0700 (PDT)
Received: by mail-io1-xd36.google.com with SMTP id t18so17857243iog.2; Tue, 22 Oct 2019 12:55:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FuBnfVDwdJcU8xFCUmu45E9P1VjALz556Q7L9+zedfs=; b=PVN7xhzg/RT0xLRBf8nW+VQXDg2tFnaCKaj81wd+Z9R9V08DfPUBsriiVoOqdoqVVS KE46lbOERtJ6DUQ4ityGkjeFku4Z1MH6bYk7fJ+jKsSToKNeoFpsT6brWlwxb9JVDLTS Oud8I7+4Uoi1kpJ2LytQyVj6qHJxfV/H5pp+Ah7+ZHroTl3xha+tph5ZP4sxZNedWaNe beB8GvWdJEC4EP5C8XLAqOn0mSrQjpvCX50C5FT75D84RwSINcW+lk5XwUunxSEzfm31 v2QqWDlf/7A7HnPfZcA2JnEnvOVOcxaXIu7x2KBMfx+vxSAB4JhCVlgAO22/njn7b3da kHUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FuBnfVDwdJcU8xFCUmu45E9P1VjALz556Q7L9+zedfs=; b=YHI3PixOcmu/l3hPlXgltSPZoqFcLNe75ghz/x0qtsjpujaaWbrwxHc3cGJYr8lTdV NaobzsG+n9vkSamjW08txq4BBcHyaeyBcSAECFMIATnss6F3S4zPaGqE2PE+iJSfZv+/ iiyg2m6veA1gggpt3Edh83osZgz5C5S6bqqgNrouZwwAkcaasnJedEn+THNq9kG4BDz+ bQKDYpcgrisfR2r/rrcpalgvylGWT3pjVjICHEQuqzV/SLAQx4g8cfEdJ11koc0MvyaP wujfj6/MsUN40ckVLbk9fOPW4fsao5ScQS8v6oP2jjq48EUMu1I6YmNZ3JsZRxfgYhV4 0VzA==
X-Gm-Message-State: APjAAAUoXUyysARPLYZ5BNLGESmzk935uLjQrj7w0HzHEV+cx1oAUAxW UQMO5C9W8EWhT6/MZQ4ijiGbzP9nrXgXMa+y4YM=
X-Google-Smtp-Source: APXvYqxFMrik2HdnFBlBf/wRyKKowpZc8tWDLusffd7sPREPmgyi4CuibTWV3mikAfvlZOj8wIah8jlIY2thz8rYALU=
X-Received: by 2002:a02:40c6:: with SMTP id n189mr5601491jaa.121.1571774139803; Tue, 22 Oct 2019 12:55:39 -0700 (PDT)
MIME-Version: 1.0
References: <157173348155.3011.12458315336826264414@ietfa.amsl.com>
In-Reply-To: <157173348155.3011.12458315336826264414@ietfa.amsl.com>
From: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
Date: Tue, 22 Oct 2019 15:55:28 -0400
Message-ID: <CAGL6epLBJQgEH=F9V9daEAsn3P9BWjcXsgx8K15k-Vk9FcVWmg@mail.gmail.com>
To: Roni Even <ron.even.tlv@gmail.com>
Cc: gen-art@ietf.org, last-call@ietf.org, SIPCORE <sipcore@ietf.org>, draft-ietf-sipcore-digest-scheme.all@ietf.org
Content-Type: multipart/alternative; boundary="000000000000452eb20595852f9a"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/FvVAaEdIEqzyXjGjUrvfQqeVQ4A>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 19:55:46 -0000

Thanks Roni!

See my replies below.

Regards,
 Rifaat


On Tue, Oct 22, 2019 at 4:38 AM Roni Even via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Roni Even
> Review result: Almost Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-sipcore-digest-scheme-??
> Reviewer: Roni Even
> Review Date: 2019-10-22
> IETF LC End Date: None
> IESG Telechat date: 2019-10-31
>
> Summary:
> The document is almost ready for publication as a standard track RFC
>
> Major issues:
>
> Minor issues:
>
> 1. In section 2.4 " If the UAC cannot respond to any of the challenges in
> the
> response, then it SHOULD abandon attempts to send the request, e.g. if the
> UAC
>    does not have credentials or has stale credentials for any of the
> realms,
>    unless a local policy dictates otherwise." Yet RFC3261 section 22.2 "
> If no
>    credentials for a realm can be located, UACs MAY attempt to retry the
>    request with a username of "anonymous" and no password (a  password of
> "").
>    Is this deprecated ?
>
>
No, it is not deprecated by this document, and that part is covered by the
last sentence of the quoted paragraph, which talks about a local policy.



> 2. RFC3261 algorithm includes "MD5-sess" while section 2.6 removed it
>

These changes are provided in the context of RFC7616, so if an
implementation supports "-sess" it could always refer to that document for
these details.


> 3. it may be good to have a backward compatibility section.
>
> I believe we covered that in the security consideration section. Do you
see anything missing there?

Regards,
 Rifaat



> Nits/editorial comments:
>
>
>