Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <B8F9A780D330094D99AF023C5877DABAAD54B417@dggeml511-mbs.china.huawei.com>
Date: Wed, 22 Apr 2020 15:41:21 -0400
Cc: "gen-art@ietf.org" <gen-art@ietf.org>,
 "last-call@ietf.org" <last-call@ietf.org>,
 "draft-ietf-netmod-factory-default.all@ietf.org"
 <draft-ietf-netmod-factory-default.all@ietf.org>, 
 "netmod@ietf.org" <netmod@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <82630369-489D-4E1E-8897-C17CBC6F4B70@cooperw.in>
References: <B8F9A780D330094D99AF023C5877DABAAD54B417@dggeml511-mbs.china.huawei.com>
To: Qin Wu <bill.wu@huawei.com>,
 Stewart Bryant <stewart.bryant@gmail.com>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/G_i_W8j4gVDJl4o_SFjDsXby-XY>
Subject: Re: [Gen-art] Genart last call review of
 draft-ietf-netmod-factory-default-14
Precedence: list

Stewart, thanks for your review. Qin, thanks for your response. I =
entered a No Objection ballot.

Alissa


> On Mar 13, 2020, at 8:26 AM, Qin Wu <bill.wu@huawei.com> wrote:
>=20
> Thanks Stewart for a good review, see reply inline below.
>=20
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Stewart Bryant via Datatracker =
[mailto:noreply@ietf.org]=20
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B43=E6=9C=8812=E6=97=A5=
 21:12
> =E6=94=B6=E4=BB=B6=E4=BA=BA: gen-art@ietf.org
> =E6=8A=84=E9=80=81: netmod@ietf.org; last-call@ietf.org; =
draft-ietf-netmod-factory-default.all@ietf.org
> =E4=B8=BB=E9=A2=98: Genart last call review of =
draft-ietf-netmod-factory-default-14
>=20
> Reviewer: Stewart Bryant
> Review result: Ready
>=20
> I am the assigned Gen-ART reviewer for this draft. The General Area =
Review Team (Gen-ART) reviews all IETF documents being processed by the =
IESG for the IETF Chair.  Please treat these comments just like any =
other last call comments.
>=20
> For more information, please see the FAQ at
>=20
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>=20
> Document: draft-ietf-netmod-factory-default-14
> Reviewer: Stewart Bryant
> Review Date: 2020-03-12
> IETF LC End Date: 2020-03-16
> IESG Telechat date: Not scheduled for a telechat
>=20
> Summary: A well written document that is pretty much ready to go. I =
only have one concern and that is whether the overwrite pattern needs =
some text so that it does not accidentally become a covert channel.
>=20
> Major issues: None
>=20
> Minor issues:
>=20
> "All security sensitive data (i.e., private keys, passwords, etc.)  =
SHOULD be  overwritten with zeros or a pattern before deletion.  "
>=20
> "a pattern" is possibly vague, and care needs to be taken that this is =
not a covert channel. Possibly it needs to say something like "an =
implementation specific common pattern"?
>=20
> [Qin]: The proposed change works for me, maybe "common" should also be =
removed.
> Nits/editorial comments:
>=20
> Nits contains a warning about references, but one concerns text that =
will removed, and the other is a format error that will be fixed in =
publication
> [Qin]:Correct, YANG library reference is unused and should be removed.=20=

> I saw the SecDir comment on RPC. This is a starred term in the =
abbreviation list and does not technically need expanding.
> [Qin]: Right, RPC is an existing term that is defined in RFC7950, =
which doesn't need to be expanded.
>=20
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art