Re: [Gen-art] Genart last call review of draft-ietf-bess-rfc5549revision-04

Christer Holmberg <christer.holmberg@ericsson.com> Tue, 14 July 2020 12:50 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 94E573A0028; Tue, 14 Jul 2020 05:50:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.102
X-Spam-Level:
X-Spam-Status: No, score=-2.102 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EygdS2fC0Nis; Tue, 14 Jul 2020 05:50:52 -0700 (PDT)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DE8573A0029; Tue, 14 Jul 2020 05:50:51 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SSmvoU6C00KXpSW88n7h0Zvvf+fCBEz60flaBV6+dBLwx9+y5WS3ZAvnBggR+OjB5U4mwLM6HPDuYfl6rhWhjBytRdN+TlGWBrucYM4at/7jOfGe360BjPaiWohU0RBu3Bjpu+KtU/FqYQ6dTncfKfRtm/KPnax5wc0aULd3si2ZKBgFq3Dqke9s31UVCeL22/8eVp08BjXArpOSC33EfW8VkkRd7TFMrJ0Rw+S/rXuPpHdwOyhC89334nLuCzfc8yxLTYMgAfNTT6TIAj/yYrlPw9R99wEkL+KdtKah2nA5Lfm9NuHV0+mfGItsVxnrwQXOUPm8+LVOUR3+sgw2AA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGl2Vp/Tmy5Y+jolfFE0HTeKcs/wAkGexAIzZ4kw73Q=; b=ihU4aflZd8RRcTwwZquEsNHAVbtH94TRmdj8GE1fAixGAPSOlRcISE2goZ9kjU6JBOIYdTQWH9DBiy22wvYZb9EEnaUwiOm/Oi9gGJoVegVU2ybjs49y8oOT7nhuMRtcnnuO9cN/hzrpxqFfOblwYTpmmQ1Q4s12/d0T4eLyS2GUF7fJgs/MWRJjicApMxh0o0dgDgvpSdAZp6nDBUcboWJahv14QhTlE6Jme0IPji3NzHiIgfix33Kcw5NYCtPhsbXW2dsiC3MjaVSmel21bl98tR9/9SXTX95pQ2XHHVK1x8dK6Gv8lhqWnaIRgEmK3nR2bZmskMEAWNewTg3ARQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGl2Vp/Tmy5Y+jolfFE0HTeKcs/wAkGexAIzZ4kw73Q=; b=l/UuaEHoctV398s4kplCEEHbb/Y6JEYEekQbtU81hoU6aVtklnOQGSR9df0sHWRtmRk1WK2nhi97FfFRLfOgIhf26Xyt/99xI/DBaB/lFBzC35bsfQkL+8FVv/dJGz5sjU0Vwnbg9qkwnJ7bVo1J1w2QwNPcJEY94HTaeyIHloo=
Received: from AM7PR07MB7012.eurprd07.prod.outlook.com (2603:10a6:20b:1bc::19) by AM6PR07MB5317.eurprd07.prod.outlook.com (2603:10a6:20b:6c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.10; Tue, 14 Jul 2020 12:50:49 +0000
Received: from AM7PR07MB7012.eurprd07.prod.outlook.com ([fe80::68d5:e267:db47:9d39]) by AM7PR07MB7012.eurprd07.prod.outlook.com ([fe80::68d5:e267:db47:9d39%6]) with mapi id 15.20.3195.013; Tue, 14 Jul 2020 12:50:49 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "slitkows.ietf@gmail.com" <slitkows.ietf@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-bess-rfc5549revision.all@ietf.org" <draft-ietf-bess-rfc5549revision.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-bess-rfc5549revision-04
Thread-Index: AQHWVsIAf8YdTQRp7UWB7tPONt5U26kHCtbg
Date: Tue, 14 Jul 2020 12:50:49 +0000
Message-ID: <AM7PR07MB70126306D2DBF0E5B74FE13093610@AM7PR07MB7012.eurprd07.prod.outlook.com>
References: <159433301602.19413.16120234350291165406@ietfa.amsl.com> <001801d656c1$fc848b30$f58da190$@gmail.com>
In-Reply-To: <001801d656c1$fc848b30$f58da190$@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [188.127.223.154]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 220a9b61-0d57-4d4e-7651-08d827f488e1
x-ms-traffictypediagnostic: AM6PR07MB5317:
x-microsoft-antispam-prvs: <AM6PR07MB53170CF3C3EF96083F62801193610@AM6PR07MB5317.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: BCTh9INXB87YqxR4fN1f93C2eIQOuiyLIvgr76wcdsTGyNNYJT1EWtORMaODNxnMaq5MIGqph27855WUy6qvdpnsEtbsK5wNJytr0f1LEs3aEqY+PeHRkkarf2Bf7JTMPqAQaibDt3rGkPK/Vg5NGH5DHt4VQXWgMs2VgZkrH1KmOGSq4woXIejVntQjRLq7fSrfVa4SYAbgR1H/1R/mL4HxgxdTSY87c9LR+CzT5/DDnh1rjaYFlBGscRx1tz6IMNUofKUp7ItMWUlq2Cmtut0v1yCJfXHTFaq7JP4PFOztuDRk2RPCX/W1SB/CDlYq+qrMNKswVofojTZX0Ukvcl5dSujjzaEjKUgml/RVoL6XYaWZIngTENpfwYiQffuQTudl9jUxV6EeFOfajghXVA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR07MB7012.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(376002)(366004)(396003)(53546011)(55016002)(4326008)(5660300002)(110136005)(8936002)(52536014)(66946007)(26005)(2906002)(66446008)(71200400001)(86362001)(9686003)(7696005)(64756008)(186003)(54906003)(44832011)(316002)(6506007)(83380400001)(8676002)(33656002)(66476007)(76116006)(66556008)(478600001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: KjLBIN1mATusItIwBjv4p+xlxvWAyW0gHxIKCkQAE6RpyaXHR53YeyYDCVlOpiIY/xfopGHei1EEM9yADH4/KBVPdEywI5c4OzjOyIksdWlGHEUzV3jD3x9kA5pvqVi7KdEjbVhCFSqUub1lcFtATn92MgzYPo4zJsK8CtJsfRV/oDsTrXC+QE96+5/ylRWr7BHEbEOGUtdbWs6ZJjx2nYrMEU687MOWdYeaY5u+98L053ey/OLxI3upUgEZpn/MRZbmlB/e6xuubR6aQe4MNEhDN6p1kHPI4mpRKw+y/ZWs/PRiDl9zWlW/xE3GMcd79AySHTzR1h83e00ME1d2M6tr2WAsGrNX9e3BicSQWpBMHjneV1ogKJRuLWFWRYserWLpGtemNMnS/7hH3rONFRphFWueF4yTD/YS+CnLfyKkEAHly79HsrLeQcw3mnwPENXi5Iz8oNa0FbE6eZCMYqKBXT7+7zmNnL7lrWRoiBdGfg9coc4yri0gUOtDWAFM
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM7PR07MB7012.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 220a9b61-0d57-4d4e-7651-08d827f488e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 12:50:49.4238 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qmb11GIlmZj1cCrSyZcuQEI9MgMvkdm/iGotKW1bee2J0a8xwqXRx/QaFUGI4FuqJqReNXzb7UPw8UuoqxPOtgB0hTsF8I/Ew05F92vyFr8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB5317
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/loSSQBfPCD906-QvV5ZecJC9M0w>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-bess-rfc5549revision-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2020 12:50:54 -0000

Hi Stephane,

>Thanks for your comments.
>For your information, this document is just a revision of RFC5549, so 99,9% of the text is just copy/paste from the existing RFC.
>Of course, we can improve things.
>
>I'll take care of your comments for a next revision.
>For the IANA section, as IANA will not have any action, I would prefer keeping the existing text from RFC5549. We can also let other people comment on that point.

In that case, shouldn't you at least update the reference (from RFC5549 to this document) in the IANA registry? 

But, as the document obsoletes RFC5549, I would personally include the complete registration text in this document - even if it is just copy/paste from RFC5549.

Regards,

Christer




-----Original Message-----
From: Christer Holmberg via Datatracker <noreply@ietf.org> 
Sent: vendredi 10 juillet 2020 00:17
To: gen-art@ietf.org
Cc: draft-ietf-bess-rfc5549revision.all@ietf.org; last-call@ietf.org; bess@ietf.org
Subject: Genart last call review of draft-ietf-bess-rfc5549revision-04

Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-bess-rfc5549revision-04
Reviewer: Christer Holmberg
Review Date: 2020-07-09
IETF LC End Date: 2020-07-21
IESG Telechat date: Not scheduled for a telechat

Summary: The document is well written, and almost ready for publication. I only have a couple of editorial nits.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:

Q1. In the Abstract, I suggest the split the text into 2 paragrahps, where the "This document specifies..." sentence is the beginning of the second paragraph.

Q2. In the Introduction section, in the last paragraph, instead of saying "This document specifies the extensions necessary to do so." I suggest to be explicit about what the document specifies - similar to the Abstract.

Q3. The document uses "IPvX Network Layer Protocol" and "IPvX Protocol"
terminology. Similarly, the document uses "IPvX" and "IPvX Address"
terminology. Unless there is a good reason, I suggest do double check whether the terminology can be more consistent.

Q4. In the IANA Considerations section, I suggest to use the IANA registry table format, where the different values (Value, Description and Reference) are indicated, e.g., as in Section 7 of RFC 8654. Also similar to 8654, please indicate the IANA registry name.