Re: [Gen-art] Genart telechat review of draft-ietf-bfd-vxlan-09

Alissa Cooper <alissa@cooperw.in> Wed, 18 December 2019 21:46 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 579AD120089; Wed, 18 Dec 2019 13:46:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=EbeyzLDt; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=ZzkQOh2x
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P4_K0ms9D-cv; Wed, 18 Dec 2019 13:46:40 -0800 (PST)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E38DA12001A; Wed, 18 Dec 2019 13:46:39 -0800 (PST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 0426F4A4; Wed, 18 Dec 2019 16:46:38 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 18 Dec 2019 16:46:39 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm1; bh=Uxj3gCBSxZRs54pmAYWCig+ Yv8IzF4cUfzjL9NJzNTA=; b=EbeyzLDtSV8NBQSPhF8QNDyosWK2Z6r8g0Uq6Ig rglUqrTyfbUyGxIK6xeEP9P62LRLhuQ9ueafrpOFMw4SsW2tIJ65O+WG71YyF00J JeJQpxGKCZq4kUPgkDDnwc0TY30f+J6wg///zY3m977ihLeu6u+zMsMYvaop6e7v TSmS79cYlC28rbDg7gkabbEQwpTn0XuMPt5qOHwFItmuhh0B3XkcIZonBVOdYM/Y cR6jYaS6iH84gsMKXBA0XR1mUx9sd2LEYaF86Hpv6jYE50af+tHp84GyH2TtTVQt yQYF6m9JicbcAISP93VY728uxY1dgsaPQTWqukpcelnfnBQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Uxj3gC BSxZRs54pmAYWCig+Yv8IzF4cUfzjL9NJzNTA=; b=ZzkQOh2xbZeEjmCgNsDsXv glr/EHqaa/rFblPwhkX2IazFqozxQvhVoCFt4ZdL+aw/fcWECGmUFNIaczMgXMsl OHemTfob2dWZyM+aCzS2OE0vSRlCDwXPhd3MuoeSJEWGJ++MaoAbEQLNbm+il2FM ZdPVGpUQFM1F7AeXydrGS31D4qPGeleNcJsrw7XHdWir3gh/o3CZObXem0OcrCle EEXDunyn69v6cwxMSuWiigqB7WcaCqY/gRrd4Qj1XhlOgi1SQXK1NTPApQlhNJhz 14oQv+S1xAYDv8k/DXDWA1LNDkTXdwUhrz/ZTQmxYa9OHddpY0GNNxbHq1te89NQ ==
X-ME-Sender: <xms:Pp76XQe50KZDKE9OThxzeQiWSIi8PVlqGPpuvDQAwnxNEcwEpgjEQg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtledgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhkfgtggfuffgjvfhfofesrgdtmherhhdtjeenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrg hinhepihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrieehnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidrihhnnecuvehluhhsth gvrhfuihiivgeptd
X-ME-Proxy: <xmx:Pp76XQtQFRGXpq-bk25i0xZHFQZYdpmTGh7KBbDOBOT1COxdh2e8xQ> <xmx:Pp76XYUSHTZtLGLtJyMG1J0R7ZYor1lzG261kk7ms0NJsSDADVn0Vg> <xmx:Pp76XV-sBmOnK0sGWFaJwoE0OlD4tL5RHh0Tzznn-_p05boRb5PuiQ> <xmx:Pp76XRVqoO-JhqSdFTqcH_wqSa7lRMW3uPZtoVaGyuULEdAUJOPUHw>
Received: from dhcp-10-150-9-228.cisco.com (unknown [173.38.117.65]) by mail.messagingengine.com (Postfix) with ESMTPA id 7ED4D8005C; Wed, 18 Dec 2019 16:46:37 -0500 (EST)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <523551D0-BDC8-4DCA-B112-6549CC58898C@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_02263575-B3D2-4F2D-8047-F9333AC950FF"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Wed, 18 Dec 2019 16:46:36 -0500
In-Reply-To: <CA+RyBmU0nRYR0xL87d-W0YCUuiyHu_C3Y3ri=tjyexnTwoS9MQ@mail.gmail.com>
Cc: last-call@ietf.org, General Area Review Team <gen-art@ietf.org>, draft-ietf-bfd-vxlan.all@ietf.org, rtg-bfd WG <rtg-bfd@ietf.org>
To: Greg Mirsky <gregimirsky@gmail.com>, Erik Kline <ek.ietf@gmail.com>
References: <157655999615.24604.538120700710888094@ietfa.amsl.com> <CA+RyBmU0nRYR0xL87d-W0YCUuiyHu_C3Y3ri=tjyexnTwoS9MQ@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/HN0UY9B_-s6AkdwYDREiwL_gEU0>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-bfd-vxlan-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Dec 2019 21:46:42 -0000

Erik, thanks for your review. Greg, thanks for addressing Erik’s comments. I entered a No Objection ballot.

Alissa


> On Dec 17, 2019, at 6:17 PM, Greg Mirsky <gregimirsky@gmail.com> wrote:
> 
> Hi Erik,
> thank you for your reviews and for sharing thoughts on the selection of the destination IPv6 address. Following recommendations from Adam, I've updated the document to use the proper representation of IPv6 addresses and refer to them as "IPv4-mapped IPv4 loopback addresses". These updates are in the attached diff.. Adam also noted that RFC 8504 doesn't have a similar wording regarding the handling of packets addressed to an address from 127/8 network as RFC 1812 (of course, referring to IPv4-mapped 127/8 addresses):
>       A router SHOULD NOT forward, except over a loopback interface, any
>       packet that has a destination address on network 127.  A router
>       MAY have a switch that allows the network manager to disable these
>       checks.  If such a switch is provided, it MUST default to
>       performing the checks.
> I'd note, that the egress BFD system is expected to accept a BFD packet with the destination IP address from the specified range without being provisioned for the specific address from that range. Perhaps that makes the use of this range possible even though its special handling is not explicitly documented.
> 
> Best regards,
> Greg
> 
> 
> On Mon, Dec 16, 2019 at 9:19 PM Erik Kline via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
> Reviewer: Erik Kline
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>>.
> 
> Document: draft-ietf-bfd-vxlan-??
> Reviewer: Erik Kline
> Review Date: 2019-12-16
> IETF LC End Date: None
> IESG Telechat date: 2019-12-19
> 
> Summary:
> 
> -09 addresses my concerns from -07.  Thank you for this.
> 
> The one "nit" is that it seems to have introduced a recommendation to use
> ::ffff:7f00:0/104 as an IPv6 loopback prefix.  (a) This document should follow
> the format recommendations of RFC 5952 section 4.3 and lowercase the "F"s.  But
> (b) more importantly, I'm not sure how implementations may treats this space.
> 
> The use of an RFC4291 section-2.5.5.2 mapped v4 address doesn't necessarily
> make the packet a part of an IPv6 connection.  Nevertheless, I'm not sure I
> have a strong feeling about this as it may still exercise enough of the IPv6
> stack in a VTEP.
> 
> I definitely do think that in the case of BFD on the management VNI targeting
> an IPv6 link-local address of the VTEP would be better.  However, I expect that
> if ::ffff:127.0.0.0 does prove to have some issues in the future a -bis can be
> written quickly with a recommendation.
> 
> Also, Suresh may have ideas for a solution.
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 
> <Diff_ draft-ietf-bfd-vxlan-09.txt - draft-ietf-bfd-vxlan-10.txt.html>_______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art