Re: [Gen-art] Gen_ART review of draft-santesson-auth-context-extension-10

Stefan Santesson <stefan@aaa-sec.com> Sun, 22 November 2015 22:18 UTC

Return-Path: <stefan@aaa-sec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A61A51ACE90 for <gen-art@ietfa.amsl.com>; Sun, 22 Nov 2015 14:18:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.25
X-Spam-Level:
X-Spam-Status: No, score=-2.25 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HELO_EQ_SE=0.35, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tdq27GitnRpF for <gen-art@ietfa.amsl.com>; Sun, 22 Nov 2015 14:18:53 -0800 (PST)
Received: from smtp.outgoing.loopia.se (smtp.outgoing.loopia.se [194.9.95.112]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9C4D1ACE8D for <gen-art@ietf.org>; Sun, 22 Nov 2015 14:18:51 -0800 (PST)
Received: from s314.loopia.se (localhost [127.0.0.1]) by s314.loopia.se (Postfix) with ESMTP id 87603167BECF for <gen-art@ietf.org>; Sun, 22 Nov 2015 23:18:48 +0100 (CET)
X-Loopia-Auth: user
X-Loopia-Originating-IP: 90.228.174.201
X-Loopia-User: stefan@fiddler.nu
Received: from s499.loopia.se (unknown [172.21.200.97]) by s314.loopia.se (Postfix) with ESMTP id 6BD892009C52; Sun, 22 Nov 2015 23:18:48 +0100 (CET)
Received: from s404.loopia.se (unknown [172.21.200.105]) by s499.loopia.se (Postfix) with ESMTP id 616B5135C930; Sun, 22 Nov 2015 23:18:48 +0100 (CET)
X-Virus-Scanned: amavisd-new at amavis.loopia.se
Received: from s500.loopia.se ([172.21.200.105]) by s404.loopia.se (s404.loopia.se [172.21.200.134]) (amavisd-new, port 10024) with LMTP id ipZ8T2KvJObt; Sun, 22 Nov 2015 23:18:48 +0100 (CET)
Received: from [192.168.0.111] (unknown [90.228.174.201]) (Authenticated sender: stefan@fiddler.nu) by s500.loopia.se (Postfix) with ESMTPSA id AE2AFA97AB2; Sun, 22 Nov 2015 23:18:47 +0100 (CET)
User-Agent: Microsoft-MacOutlook/0.0.0.151105
Date: Sun, 22 Nov 2015 23:18:45 +0100
From: Stefan Santesson <stefan@aaa-sec.com>
To: Jari Arkko <jari.arkko@piuha.net>, jouni korhonen <jouni.nospam@gmail.com>
Message-Id: <F064785A-11BE-419C-A3E3-55CD0F8A7145@aaa-sec.com>
Thread-Topic: [Gen-art] Gen_ART review of draft-santesson-auth-context-extension-10
References: <CAC8SSWu-p-exvzpEY=5hVQrHiCnKRkbfMHCevbu8Az=mGwFpRQ@mail.gmail.com> <D4D187AF-63A7-45C0-B5DC-F420CC7FB291@piuha.net>
In-Reply-To: <D4D187AF-63A7-45C0-B5DC-F420CC7FB291@piuha.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/HZtYsTQZpdcshPGFglhW5FJJGUA>
Cc: General Area Review Team <gen-art@ietf.org>, draft-santesson-auth-context-extension.all@tools.ietf.org
Subject: Re: [Gen-art] Gen_ART review of draft-santesson-auth-context-extension-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Nov 2015 22:18:55 -0000

Thank you,

I have now seen this and I will address this in the final document update.

/Stefan




On 20/11/15 02:12, "Jari Arkko" <jari.arkko@piuha.net> wrote:

>Thanks for your review, Jouni!
>
>(Authors, did you see this review - wanted to make sure no information is lost.)
>
>Jari
>
>On 16 Oct 2015, at 01:56, jouni korhonen <jouni.nospam@gmail.com> wrote:
>
>> I am the assigned Gen-ART reviewer for this draft. For background on
>> Gen-ART, please see the FAQ at
>> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
>> 
>> Please resolve these comments along with any other Last Call comments
>> you may receive.
>> 
>> Document:draft-santesson-auth-context-extension-10
>> Reviewer: Jouni Korhonen
>> Review Date: Oct-15-2015
>> IETF LC End Date: Oct-27-2015
>> IESG Telechat date: not yet
>> 
>> 
>> Summary:
>> --------
>> 
>> Ready for publication as an Informational RFC.
>> 
>> Comments:
>> ---------
>> 
>> I do not have deep expertise on the area this I-D covers. Having read it through and knowing the solution is already deployed for few years I have no technical comments.
>> 
>> Minor issues/nits:
>> ------------------
>> 1) IDNits result that need to be addressed:
>>    ** The abstract seems to contain references ([RFC5280], [SAML]), which it
>>       shouldn't.  Please replace those with straight textual mentions of the
>>       documents in question.
>> 
>> 2) == Unused Reference: 'RFC5322' is defined on line 416, but no explicit
>>       reference was found in the text
>> 
>> 
>> 3) Since this targets Informational RFC I wouldn't mind seeing all references
>>    except RFC2119 as informational references and not normative. We could argue
>>    whether RFC2119 language is needed at all (but no strong opinion here).
>> 4) Introduction third paragraph:
>>    * expand SAML on the first occurrence
>>    * I would welcome a reference for "SAML federation"
>> 
>> 5) Introduction eight paragraph:
>>    * expand CA on the first occurrence
>> 6) Section 3.1.2:
>>    * expand OID on the first occurrence (now it comes after the paragraph
>>      explaining "Ref")
>>    * three times  s/REF/Ref
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art
>