Re: [Gen-art] Gen-ART Telechat Review of draft-ietf-pim-pop-count-06

Stig Venaas <stig@cisco.com> Wed, 26 September 2012 18:40 UTC

Return-Path: <stig@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D36FC21F84B6 for <gen-art@ietfa.amsl.com>; Wed, 26 Sep 2012 11:40:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tuk1w1jmwFRu for <gen-art@ietfa.amsl.com>; Wed, 26 Sep 2012 11:40:35 -0700 (PDT)
Received: from mtv-iport-3.cisco.com (mtv-iport-3.cisco.com [173.36.130.14]) by ietfa.amsl.com (Postfix) with ESMTP id 5887921F84A1 for <gen-art@ietf.org>; Wed, 26 Sep 2012 11:40:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2570; q=dns/txt; s=iport; t=1348684835; x=1349894435; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=aYBwtA5u/c/06AmTzxn0L/ZPJl9b+7dPUzZz2IPGG1w=; b=FADS2iJVnSM5j8X96o+hn5DQEH+mFgBAzBoJCSuqP7PFguBM5NfXbq35 HJpCox9KrAhrglzbt8f2GkdbjyKDOx7zdaGD9f1u17/5zwf/UfslQzH+T aglvV4VhXv+3naT5y8ugzqQxUR39tjqBBGxM9q6CKRb7vCry5PnKeyBOr 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Av4EAHtLY1CrRDoJ/2dsb2JhbABFvlqBCIIgAQEBAwESASVBBQsLFAQJJQ8CRgYNAQcBAR6HXQUMmDKgNIsYhgkDiFiNEYEVhE2IYIFpgwc
X-IronPort-AV: E=Sophos;i="4.80,491,1344211200"; d="scan'208";a="56971334"
Received: from mtv-core-4.cisco.com ([171.68.58.9]) by mtv-iport-3.cisco.com with ESMTP; 26 Sep 2012 18:40:35 +0000
Received: from [10.154.208.60] ([10.154.208.60]) by mtv-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id q8QIeYkr010887; Wed, 26 Sep 2012 18:40:35 GMT
Message-ID: <50634C22.50800@cisco.com>
Date: Wed, 26 Sep 2012 11:40:34 -0700
From: Stig Venaas <stig@cisco.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1
MIME-Version: 1.0
To: Pete McCann <mccap@petoni.org>
References: <CACvMsLHQKYm41iw85cJzoF1rOs6DXW7jhJH9L9Tdy5cD3UjjMw@mail.gmail.com>
In-Reply-To: <CACvMsLHQKYm41iw85cJzoF1rOs6DXW7jhJH9L9Tdy5cD3UjjMw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Wed, 26 Sep 2012 11:50:45 -0700
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-pim-pop-count.all@tools.ietf.org" <draft-ietf-pim-pop-count.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART Telechat Review of draft-ietf-pim-pop-count-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2012 18:40:35 -0000

Hi, thanks for the comments. Apologies for not responding until now.

On 6/19/2012 5:08 PM, Pete McCann wrote:
> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>gt;.
>
> Please wait for direction from your document shepherd
> or AD before posting a new version of the draft.
>
> Document: draft-ietf-pim-pop-count-06
> Reviewer: Peter McCann
> Review Date: 2012-06-19
> IETF LC End Date: 2012-06-12
> IESG Telechat date: 2012-06-21
>
> Summary: 2 minor issues
>
> Major issues: none
>
> Minor issues:
>
> The Transit and Stub oif-List counts are only 2 octets.  Will these
> fields be large enough to contain
> the totals for a large multicast distribution tree?

I agree this is likely to be an issue. Checking with the WG to see how
best to resolve this. One possibility is certainly to make them 4 octets.

> Are there any alignment constraints on the options?  It looks like all
> the two-octet options come first
> and the single-octet options come last.  However, is this a
> requirement for any future options that may
> be defined?

They are aligned now, but I don't think we can require that for new
options. I'll add a comment on that.

>
> Nits/editorial comments:
>
> The descriptions of how the counts are maintained could use a little
> clarification.  For example,

I agree. I'll try to improve the language a bit for the below and also
for other options that look unclear.

Stig

> when you say:
>
>     Transit Oif-List Count:   This is filled in by a router sending a
>        Join/Prune message which is equal to the number of oifs (outgoing
>        interfaces) for the multicast route that has been joined by PIM.
>        This indicates the transit branches on a multicast distribution
>        tree (no members on the links between this router and joining
>        routers).  This is added to the value advertised by all downstream
>        PIM routers that have joined on this oif.  Length 2 octets.
>
> it isn't clear what you mean by "which is equal to". Literally, you
> are saying the Join/Prune message
> is equal to something.  I don't think that's quite right.  Did you
> mean "with a number that is equal to"?
> Maybe, "with a number that is equal to the number of oifs (outgoing
> interfaces) for the multicast
> route that has been joined by PIM, plus the values advertised by all
> downstream PIM routers that
> have joined this oif."
>
>
>
> -Pete
>