Re: [Gen-art] [Idr] Genart last call review of draft-ietf-idr-rfc5575bis-20

Alissa Cooper <alissa@cooperw.in> Wed, 22 April 2020 13:55 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C31A43A0CBE; Wed, 22 Apr 2020 06:55:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=09KoZb5N; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=GCPUCsTw
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A42sHrxyh1J2; Wed, 22 Apr 2020 06:55:14 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CAE0C3A0CAA; Wed, 22 Apr 2020 06:55:13 -0700 (PDT)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6E5AE5C00B5; Wed, 22 Apr 2020 09:55:12 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 22 Apr 2020 09:55:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm2; bh=ZTCgjJCsgnf6zVMcmTDiIy/ oLCW4A0iGDh7AqnltlMA=; b=09KoZb5NKezq/ZyYm0nxLkhznTglcnR40cAplQl XslqAparO0sKvQSMmruM4WFWfzRrfTT9X8Bri5nHt1qjjw7TY128feA4sh0hMMcK Awg7lacFGz8p6nSe9w5rpSGQsdl/HPN540o8FLLWUMht2aDQYI8DUyxa7mSbCjxA 7EVCcRZWCI2pQ+mmkN3HfOVSVNCLAF1BlrSYK0PzO+DQXRvOXwmK6HY1jKYJSidm ydh9Gil2CXhq9ZxfikaR/8Iewz1NAXSoaEBvYHHjlWsfcdZyXwa2A98lvW4UeAmv 8UCCC0wdVNApp4MsEjBUHhM+gv2UL6pgyFiwdGGLmYfPUGQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZTCgjJ Csgnf6zVMcmTDiIy/oLCW4A0iGDh7AqnltlMA=; b=GCPUCsTwewwZDULRP/i6I8 jdX9I7wtnhxF1enptD3CAfL0GXCXjjYhuz5rniOCRci2gJ2zf9MbwYwynOCgqmcz zQXsLJuAg97ysq3RHAsIwfEmzRD2JhGp4l+colNORhPCRqlRtYlh2srpgEjHROvr le0Q4VZoh6PmTaxYeBilExUxzQ0cxvzLixzV6CthojNgK84ju8e3LH1JUk92lOSY LOEeoPZbKT+pVnGMB+IB+rGtlUkMRpSdcl2FU5Yef6LPXyzUKkv+tYvufBT7RDG4 N9FdPICtrN/tFIq1G7dKTyHk6BxDDLdqG/Fg2foRQWvc7SyVVD+bRc2OG8Hj+usA ==
X-ME-Sender: <xms:v0ygXto_oWNCzNoHbvroVC59XjxgSVcBAjJH7FHIMr2rlR8ug3hjYA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeejgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffktgggufffjgfvfhfosegrtdhmre hhtdejnecuhfhrohhmpeetlhhishhsrgcuvehoohhpvghruceorghlihhsshgrsegtohho phgvrhifrdhinheqnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpnhgvgihtlhgrhi gvrhdrrghtpdhivghtfhdrohhrghenucfkphepudejfedrfeekrdduudejrdejkeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhishhsrg estghoohhpvghrfidrihhn
X-ME-Proxy: <xmx:v0ygXseyZVwm42eeQRtABUzHQMZ9TXNGnz0KKveLjERWsiF72AbPMA> <xmx:v0ygXlHNB7zDlngoEr9OSjEBsana5yv8TA1BZk2HXo7ISjN96DimJg> <xmx:v0ygXjxTCMX90E8147aYg8OEfITVgLCRPca254hPuMNH6WfaPqFtPw> <xmx:wEygXsCZjxQgErqc-NG_lvF2iuGLt0z2LuGwWzSkQ674L4FfvrilFg>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.78]) by mail.messagingengine.com (Postfix) with ESMTPA id B640E3065CDF; Wed, 22 Apr 2020 09:55:10 -0400 (EDT)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <F7D42D8A-9764-4CB7-B6AC-600239CFBFF9@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_F69FD258-EE59-4822-A3B9-096D0AC9F5F2"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.5\))
Date: Wed, 22 Apr 2020 09:55:06 -0400
In-Reply-To: <42014AE1-D058-486E-9E17-475D07A91885@tix.at>
Cc: last-call@ietf.org, General Area Review Team <gen-art@ietf.org>, draft-ietf-idr-rfc5575bis.all@ietf.org, IDR List <idr@ietf.org>
To: Christoph Loibl <c@tix.at>, Gyan Mishra <hayabusagsm@gmail.com>
References: <158629580378.13606.6350807287790835622@ietfa.amsl.com> <42014AE1-D058-486E-9E17-475D07A91885@tix.at>
X-Mailer: Apple Mail (2.3445.9.5)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/I7-0EsDjBEtsHD2eCxnse-n4Lk4>
Subject: Re: [Gen-art] [Idr] Genart last call review of draft-ietf-idr-rfc5575bis-20
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Apr 2020 13:55:17 -0000

Gyan, thanks for your review. Christoph, thanks for your response. I think the intro in the draft is ok as-is. I entered a DISCUSS ballot with a question about Section 7.

Alissa


> On Apr 17, 2020, at 3:43 AM, Christoph Loibl <c@tix.at> wrote:
> 
> Hi Gyan,
> 
> Thanks for your review. According to your review I made the following changes to the document which is available now as revision -22:
> 
>> On 07.04.2020, at 23:43, Gyan Mishra via Datatracker <noreply@ietf.org <mailto:noreply@ietf.org>> wrote:
>> 
>> Reviewer: Gyan Mishra
>> Review result: Ready with Nits
>> 
>> Reviewer: Gyan Mishra
>> Review result: Ready with Minor Issues
>> 
>> Minor issues:
>> I am familiar with BGP Flow specification and would like to recommend some
>> verbiage that may help in the introduction as far as explaining how BGP flow
>> spec works.  Ssince the introduction has been re-written with this update, this
>> could be a possible addition to the draft.
>> 
>> This could be placed at the end of the introduction if desired.
>> BGP flow specification is a client-server model that allows for a more granular
>> approach to DDOS mitigation than its predecessor, “Remotely Triggered Blackhole
>> (RTBF) which tagged a prefix with a community and sent it do a discard next
>> hop.  BGP flow spec has two main components, the “controller” being the BGP
>> speaker device which acts as the server side, which injects the new flowspec
>> entry, and the client side which is the BGP speaker devices that receives the
>> flowspec NLRI and acts on the instruction to match a particular flow with Layer
>> 3 and Layer 4 parameters and then implements the hardware forwarding action
>> requested.
> 
> <-- 
> Tracked via issue #163: https://github.com/stoffi92/rfc5575bis/issues/163 <https://github.com/stoffi92/rfc5575bis/issues/163>
> 
> I do not agree that BGP flowspec is a client-server model -only-. We can propagate this NLRI over administrative domain borders as we do with IP routing information, it follows the same mechanisms. We see such solutions being deployed in the internet as inter provider DDoS solutions.
> 
> We actually had a paragraph in the darft that was explaining the advantages over other approaches like RTBF but this has been removed because it was pointed out that it is not relevant to the spec to justify a well deployed technology.
> -->
> 
> 
>> Nits/editorial comments:
>> 7.  Traffic Filtering Actions
>>   This document defines a minimum set of Traffic Filtering Actions that
>>   it standardizes as BGP extended community values [RFC4360]
>> 
>>   Any mention of [RFC4360] should be updated with [RFC7153] IANA Registries
>>   for BGP Extended Communities.
>> 
> 
> <-- 
> Tracked via issue #164: https://github.com/stoffi92/rfc5575bis/issues/164 <https://github.com/stoffi92/rfc5575bis/issues/164>
> Commits mentions:
>     https://github.com/stoffi92/rfc5575bis/commit/31f0ac79b7cd998aa2750fd376dc148d7a590369 <https://github.com/stoffi92/rfc5575bis/commit/31f0ac79b7cd998aa2750fd376dc148d7a590369>
>     https://github.com/stoffi92/rfc5575bis/commit/7aadadcdf55a1f5a7d5c1822070b862247dfaead <https://github.com/stoffi92/rfc5575bis/commit/7aadadcdf55a1f5a7d5c1822070b862247dfaead>
> 
> Removed the "values" statement (as suggested by Alvaro) from the draft to make clear we are not talking about particular values but about  Extended Communities as specified in RFC4360.
> s/standardizes as BGP extended community values [RFC4360]/standardizes as BGP extended communities [RFC4360]/
> 
> -->
> 
> Cheers 
> Christoph
> 
> -- 
> Christoph Loibl
> c@tix.at <mailto:c@tix.at> | CL8-RIPE | PGP-Key-ID: 0x4B2C0055 | http://www.nextlayer.at <http://www.nextlayer.at/>
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org <mailto:Gen-art@ietf.org>
> https://www.ietf.org/mailman/listinfo/gen-art <https://www.ietf.org/mailman/listinfo/gen-art>