IETF Logo Mail Archive

Re: [Gen-art] [Gem-art] Gem-ART review of draft-moriaty-pkcs1-03

"Kaliski, Burt" <bkaliski@verisign.com> Mon, 19 September 2016 21:24 UTC

Return-Path: <bkaliski@verisign.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8B62212B14B for <gen-art@ietfa.amsl.com>; Mon, 19 Sep 2016 14:24:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.589
X-Spam-Level:
X-Spam-Status: No, score=-2.589 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=verisign-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oxXlf4n3uiyB for <gen-art@ietfa.amsl.com>; Mon, 19 Sep 2016 14:24:02 -0700 (PDT)
Received: from mail-oi0-x263.google.com (mail-oi0-x263.google.com [IPv6:2607:f8b0:4003:c06::263]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0E2212B00D for <gen-art@ietf.org>; Mon, 19 Sep 2016 14:24:02 -0700 (PDT)
Received: by mail-oi0-x263.google.com with SMTP id w11so10083063oia.0 for <gen-art@ietf.org>; Mon, 19 Sep 2016 14:24:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verisign-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:thread-topic:thread-index:date:message-id :references:in-reply-to:accept-language:content-language :mime-version; bh=hAfQ5YJSi1Dl95uxmJ2r5XkEKMFpt73xDCdm3S9zIqk=; b=lmO2Ex7U+h3zKQ2+kfSuWM6sfDqB6tit0zjKAiPxdqJrsntdY+ODuV8r7fzbzv4fNZ 4/TyQbV7G+6x4fhptJpzptF8RXBhcOSCl3e5R7n7QP2xLovycXyfl+EGG0ZzbTOJHvsU zI/uroU+TnbzhGSLYr9GN4czyOOPC6C3F0mLpPHaOJwm8BercUNXN+wWx0zHuwsiUJDa ozASAPJlkHUEi2A3L8ufiwq2+uWhzjG/1UAZvRLmZ8TvbSutR2Ccl1Y+96kU6mIN3KU/ 5YC4fh3gXWAywB1j3/pE+9o5q0YpQ5oWTRWq/Ry5RO8cqViNJcHAZsUn3AB1o2CHAC5Q JyeQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:thread-topic:thread-index :date:message-id:references:in-reply-to:accept-language :content-language:mime-version; bh=hAfQ5YJSi1Dl95uxmJ2r5XkEKMFpt73xDCdm3S9zIqk=; b=VTBd7VbSA4QCXI6uYibLfCEansn7d3vN6gBoZI1ZrVCRjlu/RyNvOr9A9t3ECFDruB /o6fbvlRhmj1TR455mbUACxou1+D+z6PmE8e4SBe6AVh1xmlWPDXJUNULnbHN88T3HFt swacdBN9LPLJaRTTgMtOIUAxC79mNpdO9imwTlJa6IsMtZd5phWaeHnQl9XKhPl9YyER yMvHI4RLomVUjkQAdaoha8gmEAxLCRwGYHEwDKuwBr4qjBaWJ4tkku6nDWeol4m3+/cB hH4RcESu4/sfbz8w9fb0ljy2Gsw/KNuHWtPHbDAxsjFaAG3YHGiutGVIVlE790KSn7y9 a3mA==
X-Gm-Message-State: AE9vXwMrRIMeXHjTb08q1sDCYubHoPAcMGt2tOvddkQZRVu4TeoTm2V/u06NOG3Ju/OMNGjowNi9zZZyhp559O4sR7476wKC
X-Received: by 10.55.214.68 with SMTP id t65mr32581506qki.216.1474320241934; Mon, 19 Sep 2016 14:24:01 -0700 (PDT)
Received: from brn1lxmailout01.verisign.com (brn1lxmailout01.verisign.com. [72.13.63.41]) by smtp-relay.gmail.com with ESMTPS id j190sm4188707qkd.9.2016.09.19.14.24.01 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 19 Sep 2016 14:24:01 -0700 (PDT)
X-Relaying-Domain: verisign.com
Received: from brn1wnexcas01.vcorp.ad.vrsn.com (brn1wnexcas01 [10.173.152.205]) by brn1lxmailout01.verisign.com (8.13.8/8.13.8) with ESMTP id u8JLO0TB031261 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 19 Sep 2016 17:24:01 -0400
Received: from BRN1WNEXMBX01.vcorp.ad.vrsn.com ([::1]) by brn1wnexcas01.vcorp.ad.vrsn.com ([::1]) with mapi id 14.03.0174.001; Mon, 19 Sep 2016 17:23:58 -0400
From: "Kaliski, Burt" <bkaliski@verisign.com>
To: Lucy yong <lucy.yong@huawei.com>
Thread-Topic: [Gem-art] Gem-ART review of draft-moriaty-pkcs1-03
Thread-Index: AdIPbT27VIohZU1dTfWQfj5cNaMGrgDToIsw
Date: Mon, 19 Sep 2016 21:23:57 +0000
Message-ID: <B8387BC3FC075E4EAD935BF5752561063D013871@BRN1WNEXMBX01.vcorp.ad.vrsn.com>
References: <2691CE0099834E4A9C5044EEC662BB9D572D4C78@dfweml501-mbb>
In-Reply-To: <2691CE0099834E4A9C5044EEC662BB9D572D4C78@dfweml501-mbb>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.173.152.4]
Content-Type: multipart/alternative; boundary="_000_B8387BC3FC075E4EAD935BF5752561063D013871BRN1WNEXMBX01vc_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/ILaxqsVPH5sHuOdFyi3e_V3gWPQ>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-moriarty-pkcs1@tools.ietf.org" <draft-moriarty-pkcs1@tools.ietf.org>
Subject: Re: [Gen-art] [Gem-art] Gem-ART review of draft-moriaty-pkcs1-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Sep 2016 21:24:04 -0000

Dear Lucy,

Thank you very much for the careful review.

These are all good catches, especially the need to change several labels from "PKCS" to "PKCS1" to match the corresponding PKCS #1 v2.2 document:  https://www.emc.com/collateral/white-papers/h11300-pkcs-1v2-2-rsa-cryptography-standard-wp.pdf

My co-authors may have additional feedback.


n  Burt

From: Lucy yong [mailto:lucy.yong@huawei.com]
Sent: Thursday, September 15, 2016 12:22 PM
To: gen-art@ietf.org; draft-moriarty-pkcs1@tools.ietf.org
Subject: [Gem-art] Gem-ART review of draft-moriaty-pkcs1-03

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
Document:                       draft-moriaty-pkcs1-03
Reviewer:                         Lucy Yong
Review Date:                   15 September 2016
IETF LC End Date:            2 September 2016

Summary:
The document is well written, and is ready for publication as Informational RFC. IPR considerations are in Appendix D.
Major Issues:    None
Minor Issues:

*        Several places use xxx-PKCS-v1_5, should it be xxx-PKCS1-v1_5? where xxx may be EMSA, RSAES, and RSASSA.
Editorial Issues:

*        Please check the Idnits tool

*        Page 18: s/k - 2hLen -2/k - 2hLen - 2/

*        Page 18: s/"knowing"the/"knowing" the/

*        Page 40: s/ -- such as the salt value in EMSA-PSS --/ such as the salt value in EMSA-PSS/

*        replace Section 7.2.2. title with "Decryption operation"

*        In Section 8.2, s/Note:/Note./   (to be consistent with the rest of doc.)

*        Section 8.2 last paragraph, replace "recommended" with "RECOMMENDED"
Regards,
Lucy

v2.46.0 | Report a Bug | By Email | System Status