[Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-06

Russ Housley <housley@vigilsec.com> Fri, 11 September 2015 16:19 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0CFE21A1A82; Fri, 11 Sep 2015 09:19:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mGxrVBjymPRu; Fri, 11 Sep 2015 09:19:48 -0700 (PDT)
Received: from odin.smetech.net (x-bolt-wan.smeinc.net [209.135.219.146]) by ietfa.amsl.com (Postfix) with ESMTP id BF8861B4001; Fri, 11 Sep 2015 09:19:48 -0700 (PDT)
Received: from localhost (unknown [209.135.209.5]) by odin.smetech.net (Postfix) with ESMTP id 4BA52F2418A; Fri, 11 Sep 2015 12:19:38 -0400 (EDT)
X-Virus-Scanned: amavisd-new at smetech.net
Received: from odin.smetech.net ([209.135.209.4]) by localhost (ronin.smeinc.net [209.135.209.5]) (amavisd-new, port 10024) with ESMTP id NZQfCcN0neYZ; Fri, 11 Sep 2015 12:18:41 -0400 (EDT)
Received: from [192.168.2.100] (pool-108-51-128-219.washdc.fios.verizon.net [108.51.128.219]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by odin.smetech.net (Postfix) with ESMTP id E96D5F24189; Fri, 11 Sep 2015 12:19:37 -0400 (EDT)
Mime-Version: 1.0 (Apple Message framework v1085)
Content-Type: text/plain; charset=us-ascii
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com>
Date: Fri, 11 Sep 2015 12:19:27 -0400
Content-Transfer-Encoding: 7bit
Message-Id: <15C39A03-63B9-4A2E-9BE9-DFB3AA41F94F@vigilsec.com>
References: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com>
To: draft-ietf-trill-pseudonode-nickname.all@ietf.org
X-Mailer: Apple Mail (2.1085)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/IVNtmlY5vykD3uqumD3OUM_CsfQ>
Cc: IETF Gen-ART <gen-art@ietf.org>, IETF <ietf@ietf.org>
Subject: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Sep 2015 16:19:50 -0000

I am the assigned Gen-ART reviewer for this draft.  The General Area
Review Team (Gen-ART) reviews all IETF documents being processed by
the IESG for the IETF Chair.  Please treat these comments just like
any other last call comments.  For more information, please see the
FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-trill-pseudonode-nickname-06
Reviewer: Russ Housley
Review Date: 2015-09-11
IETF LC End Date: 2015-09-01
IESG Telechat date: 2015-09-17

Summary: Almost Ready

Thanks for resolving my comments on the -05 version of this document.

Remaining Concern:

Building on the comment from my previous review on Section 5.2, Step 1:

Your response said, "The sort is done in the per-LAALP base. It's not
necessary to make the LAALP ID to a constant length. Besides, the 'mod'
function always returns a value in [0, k-1] whatever the length of
LAALP ID is."  The role of the 'mod' function was clear to me.

In Section 5.2, Step 1, the updated text says, "System ID and LAALP ID
are considered as byte strings", but the Step 2 text refers to "the
numerically sorted list".  If all of the System IDs are the same
length, then these are obviously the same.  Is that always the case?