Re: [Gen-art] review of draft-ietf-ecrit-additional-data-34.txt

Jari Arkko <jari.arkko@piuha.net> Thu, 03 September 2015 12:04 UTC

Return-Path: <jari.arkko@piuha.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9C7681B3477 for <gen-art@ietfa.amsl.com>; Thu, 3 Sep 2015 05:04:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.91
X-Spam-Level:
X-Spam-Status: No, score=-3.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, GB_I_LETTER=-2, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cciKdKbD5O6l for <gen-art@ietfa.amsl.com>; Thu, 3 Sep 2015 05:04:03 -0700 (PDT)
Received: from p130.piuha.net (p130.piuha.net [IPv6:2a00:1d50:2::130]) by ietfa.amsl.com (Postfix) with ESMTP id 6EDCA1B33A4 for <gen-art@ietf.org>; Thu, 3 Sep 2015 05:04:02 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by p130.piuha.net (Postfix) with ESMTP id 56F7A2CC6B; Thu, 3 Sep 2015 15:04:01 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
X-Virus-Scanned: amavisd-new at piuha.net
Received: from p130.piuha.net ([127.0.0.1]) by localhost (p130.piuha.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rZU3VT4TSGoD; Thu, 3 Sep 2015 15:03:59 +0300 (EEST)
Received: from [127.0.0.1] (p130.piuha.net [IPv6:2a00:1d50:2::130]) by p130.piuha.net (Postfix) with ESMTP id 34D1A2CC5C; Thu, 3 Sep 2015 15:03:59 +0300 (EEST) (envelope-from jari.arkko@piuha.net)
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Content-Type: multipart/signed; boundary="Apple-Mail=_CA5F60B4-2EFD-4BF3-BBAE-BEAA2A4EACC7"; protocol="application/pgp-signature"; micalg="pgp-sha512"
X-Pgp-Agent: GPGMail 2.5.1
From: Jari Arkko <jari.arkko@piuha.net>
In-Reply-To: <201509021019.t82AJwfk041328@givry.fdupont.fr>
Date: Thu, 03 Sep 2015 14:03:58 +0200
Message-Id: <46064B02-E72A-441F-8DFF-7DF82669BE13@piuha.net>
References: <201509021019.t82AJwfk041328@givry.fdupont.fr>
To: Francis Dupont <Francis.Dupont@fdupont.fr>
X-Mailer: Apple Mail (2.1878.6)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/IZm_nrn8z2gdYQQ3IuRypFVcKhY>
Cc: General Area Review Team <gen-art@ietf.org>, draft-ietf-ecrit-additional-data.all@tools.ietf.org
Subject: Re: [Gen-art] review of draft-ietf-ecrit-additional-data-34.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Sep 2015 12:04:05 -0000

Thanks for your review, Francis!

Can the authors check the comments? Thanks.

With regards to RFC 2119 keywords, if I understand the point correctly,
I wouldn’t worry too much about the appearance of lower case keywords,
if they indeed are meant to be just English and not keywords. That is the
current practice since a long time ago. I don’t think we need additional
text in the document to explain this. However, if there is a case where these
really are meant to be keywords, then they should, I think, be in capital
letters.

Thanks,

Jari

On 02 Sep 2015, at 12:19, Francis Dupont <Francis.Dupont@fdupont.fr> wrote:

> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ecrit-additional-data-34.txt
> Reviewer: Francis Dupont
> Review Date: 20150828
> IETF LC End Date: 20150824
> IESG Telechat date: 20150903
> 
> Summary: Almost Ready
> 
> Major issues: None
> 
> Minor issues:
> This document uses and even redefines RFC 2119 keywords outside the
> *formal* wording of RFC 2119: quoting the RFC 2119 (Abstract):
> "These words are often capitalized."
> This formally means a keyword in lower case is still a keyword which
> must (MUST :-) be interpreted as described in RFC 2119. IMHO this is
> for very old IETF documents: any IETF document published less than 20
> years ago uses full upper case keywords when they have to be interpreted
> so this statement in the RFC 2119 Abstract is more source of confusion
> than clarification.
> If it can be accepted I propose to add an exception for this document
> saying that RFC 2119 keywords are capitalized.
> 
> Nits/editorial comments:
> - Abstract page 1: every emergency call carry -> carries
> 
> - 1 page 4: every emergency call carry -> carries
> 
> - 2 page 6: the place where I suggest to add that RFC 2119 keywords
>  are capitalized and in general keywords are case sensitive.
> 
> - 4.1.4 page 13: an example of a "may" and a "should" which are not
>  RFC 2119 keywords but only common English.
> 
> - 4.2.1 page 18: neccessarily -> necessarily
> 
> - 4.3.8 page 27: defined . -> defined.
> 
> - 5.2 page 36 and 5.3 page 38:
>  I am afraid the provided-by construct in the example is unbalanced
>  (i.e., <provided-by -> <provided-by>)
> 
> - 8 page 62, 9 page 65 (twice): as security and privacy considerations
>  can be read independently I suggest to replace the 3 "may"s by
>  equivalent wordings ("can", "be allowed to", etc).
> 
> - 10.1.9 page 70: registation -> registration
> 
> - 10.4 pages 72 - 76 (many):
>  The IESG <ietf@ietf.org> -> The IESG <iesg@ietf.org>
> 
> - 10.6 page 82: ectit@ietf.org -> ecrit@ietf.org
> 
> - 11 page 83: benefitted -> benefited
> 
> Note I didn't check the schemas (even you had the nice attention to
> provide them directly, cf appendix B). I reviewed the 33 version
> (so at the exception of spelling errors I gave the 33.txt page numbers)
> and verified the 33-34 diff.
> 
> Regards
> 
> Francis.Dupont@fdupont.fr
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art