Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10

Rifaat Shekh-Yusef <rifaat.ietf@gmail.com> Wed, 23 October 2019 12:25 UTC

Return-Path: <rifaat.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 92D55120144; Wed, 23 Oct 2019 05:25:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DNZKbFi4BpAJ; Wed, 23 Oct 2019 05:25:18 -0700 (PDT)
Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 07DFB1200D8; Wed, 23 Oct 2019 05:25:18 -0700 (PDT)
Received: by mail-io1-xd36.google.com with SMTP id z19so24719944ior.0; Wed, 23 Oct 2019 05:25:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kIShG2nGArgH2BdTVOM3Mz7s+M6vBVTMiUL5+pXa/UY=; b=cV9BD9MK0/p76VHRworoSwLVPkom2/eH/HVDOJdV6od6jtg4co6y05W19yCcVhI8q9 vytwNF97WRCSlvjwwk2JVF0n9Dret+Ac1mUNWssjz2lhQBufIlyo2NiGJY1A5LA886AA B7wAZzaFX5emxHK8TpZXmYx8uK0keqwlgSIsvF9f7z2bPsApdvC8eAQXr5aO+XYDjCH4 dOLd1cTi5SAUGGuzn2RJEZ6xPGEyE9qw5xaZwwpsdbkARzngFu2np3ie7ZOnFxPU6TX9 HRpbJ2HLK+hy9Ae15wdC9A41NRNHVHh1HmQau1Fodbs6gJZsbsLRXTNdb7UmF44md3Tf Os7Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kIShG2nGArgH2BdTVOM3Mz7s+M6vBVTMiUL5+pXa/UY=; b=QsPLM90Ycz5re6ReaqunkgcQibVAIufzHQ31A8LAY5hGWGO0IjV0EPwifyL+0N0Wsh kUq4xMMS2cFYqCszp4b4lwbDGJSBYyRiAvfVACA2h/meSFmn3NjyRnEXfRKs1vjDYNLp 7jv6e7+JwmJzXTWMoJ/bTLJQKQ3n5t6DJuqwCaDj0MOqDNVdUWnulIxs3KFqInHhXXSj 6S9BKTZunYQzjGYrRxmpRyKHwUbARsE1C9Q/y2jTZfrPOZfnQHXCq0bJW8tE/7TLtk/T uPvUV4oNGn4qXoe7AAgQz76cx/PKOT9a8YSYKJExuGZlTQDrHsQtjyVpfP1OFMhdPRVY 1rwg==
X-Gm-Message-State: APjAAAW5CG9WDHOt3dyVqd1yMyuQ056/djn4nwiupJrwmXIfGoEY51m6 Dx7QwoTggaWdREuZnD/lke9RYnl5dMnduqv4DGM=
X-Google-Smtp-Source: APXvYqyEINwhw4rnLbBNZ3t/CCWU7ZYytFSkOj+LQE/tvqNO5V2ctMgVlAbGMFGZp55MbdQA8Vp1xShCJZsOTdBSJAo=
X-Received: by 2002:a02:40c6:: with SMTP id n189mr9144891jaa.121.1571833517314; Wed, 23 Oct 2019 05:25:17 -0700 (PDT)
MIME-Version: 1.0
References: <157173348155.3011.12458315336826264414@ietfa.amsl.com> <CAGL6epLBJQgEH=F9V9daEAsn3P9BWjcXsgx8K15k-Vk9FcVWmg@mail.gmail.com> <6E58094ECC8D8344914996DAD28F1CCD23D93020@DGGEMM506-MBX.china.huawei.com>
In-Reply-To: <6E58094ECC8D8344914996DAD28F1CCD23D93020@DGGEMM506-MBX.china.huawei.com>
From: Rifaat Shekh-Yusef <rifaat.ietf@gmail.com>
Date: Wed, 23 Oct 2019 08:25:05 -0400
Message-ID: <CAGL6epK0_2JvAmbUU7iiBDZoxfwnWJnoZWJRsQaG54ObdM6NEA@mail.gmail.com>
To: "Roni Even (A)" <roni.even@huawei.com>
Cc: Roni Even <ron.even.tlv@gmail.com>, "last-call@ietf.org" <last-call@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, SIPCORE <sipcore@ietf.org>, "draft-ietf-sipcore-digest-scheme.all@ietf.org" <draft-ietf-sipcore-digest-scheme.all@ietf.org>
Content-Type: multipart/alternative; boundary="000000000000721757059593021d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/IaBB2sb6CBGuu3Q5d5M6acLUOL0>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-sipcore-digest-scheme-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2019 12:25:21 -0000

Hi Roni,

I agree with the ABNF issue. I will fix that in the next version of the
draft.

Thanks,
 Rifaat


On Wed, Oct 23, 2019 at 1:43 AM Roni Even (A) <roni.even@huawei.com> wrote:

> Rifaat thanks,
>
> See in line
>
> Roni
>
>
>
>
>
> On Tue, Oct 22, 2019 at 4:38 AM Roni Even via Datatracker <
> noreply@ietf.org> wrote:
>
> Reviewer: Roni Even
> Review result: Almost Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-sipcore-digest-scheme-??
> Reviewer: Roni Even
> Review Date: 2019-10-22
> IETF LC End Date: None
> IESG Telechat date: 2019-10-31
>
> Summary:
> The document is almost ready for publication as a standard track RFC
>
> Major issues:
>
> Minor issues:
>
> 1. In section 2.4 " If the UAC cannot respond to any of the challenges in
> the
> response, then it SHOULD abandon attempts to send the request, e.g. if the
> UAC
>    does not have credentials or has stale credentials for any of the
> realms,
>    unless a local policy dictates otherwise." Yet RFC3261 section 22.2 "
> If no
>    credentials for a realm can be located, UACs MAY attempt to retry the
>    request with a username of "anonymous" and no password (a  password of
> "").
>    Is this deprecated ?
>
>
>
> No, it is not deprecated by this document, and that part is covered by the
> last sentence of the quoted paragraph, which talks about a local policy.
>
>
>
> RE: I have no strong feeling it is just that the language is different
>
>
>
>
>
> 2. RFC3261 algorithm includes "MD5-sess" while section 2.6 removed it
>
>
>
> These changes are provided in the context of RFC7616, so if an
> implementation supports "-sess" it could always refer to that document for
> these details.
>
>
>
> RE: I think that the BNF
>
> algorithm = "algorithm" EQUAL ( "MD5" / "SHA-512-256" / "SHA-256"/ token )
>
> should be
>
> algorithm = "algorithm" EQUAL ( "MD5" / "MD5-sess / "SHA-512-256" / "SHA-256"/ token )
>
>
>
>
>
>
>
>
> 3. it may be good to have a backward compatibility section.
>
> I believe we covered that in the security consideration section. Do you
> see anything missing there?
>
>
>
> RE: OK, no problem.
>
>
>
> Regards,
>
>  Rifaat
>
>
>
>
>
> Nits/editorial comments:
>
>