Re: [Gen-art] Genart last call review of draft-ietf-dnsop-iana-class-type-yang-02

Ladislav Lhotka <ladislav.lhotka@nic.cz> Mon, 17 May 2021 12:25 UTC

Return-Path: <ladislav.lhotka@nic.cz>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 660523A35FE; Mon, 17 May 2021 05:25:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nic.cz
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4gcL0ZGWihPG; Mon, 17 May 2021 05:25:38 -0700 (PDT)
Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 279F43A35FC; Mon, 17 May 2021 05:25:38 -0700 (PDT)
Received: from localhost (unknown [IPv6:2001:1488:fffe:6:a88f:7eff:fed2:45f8]) by mail.nic.cz (Postfix) with ESMTPSA id 9A802141075; Mon, 17 May 2021 14:25:34 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1621254334; bh=ejiennoKchRWnAy6Xq4MyrMyHcuOmbwTr3zqB59RaT4=; h=From:To:Date; b=TGHcpdkkxdOmla+zD49ceemJsFFAQ5KhF5QW+kCZizQ0a2n4WASwHCZWYDDYel+lG lbZd/DGZXI4lkUN4Z6DDtp7iL771HCYcZofwQt6IE92ZMEbRHk7E8vrf8IjIxPQdyD 3T8f2NFmFcpNh3ErLAfr8m2nTX/uW3wkkiIVZrpE=
From: Ladislav Lhotka <ladislav.lhotka@nic.cz>
To: Joel Halpern <jmh@joelhalpern.com>, gen-art@ietf.org
Cc: dnsop@ietf.org, draft-ietf-dnsop-iana-class-type-yang.all@ietf.org, last-call@ietf.org
In-Reply-To: <162102448453.25089.15077622369733772482@ietfa.amsl.com>
References: <162102448453.25089.15077622369733772482@ietfa.amsl.com>
Date: Mon, 17 May 2021 14:25:34 +0200
Message-ID: <877djxk0n5.fsf@nic.cz>
MIME-Version: 1.0
Content-Type: text/plain
X-Virus-Scanned: clamav-milter 0.102.2 at mail
X-Virus-Status: Clean
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/JIMWqI-WV64mb6heLAKZ3bvqwGs>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-dnsop-iana-class-type-yang-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2021 12:25:44 -0000

Hi Joel,

thanks for the review, please see my responses below.

Joel Halpern via Datatracker <noreply@ietf.org> writes:

> Reviewer: Joel Halpern
> Review result: Ready with Issues
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-dnsop-iana-class-type-yang-02
> Reviewer: Joel Halpern
> Review Date: 2021-05-14
> IETF LC End Date: 2021-05-24
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: This document is ready for publication as a proposed standard.
>
> I do have two questions that I hope has already been considered by the WG and
> is a non-issue.  See minor issues.
>
> Major issues:
>
> Minor issues: 1) I presume IANA has been involved in the development
> of this document, and is willing to undertake the maintenance?  I
> looked for but did not see where that was noted.

Yes, Michelle Cotton of IANA did an early review last year. One issue that remains to be decided has to do with the XSLT stylesheet that is intended to be used for generating the initial revision of the YANG module: is it to be removed before publication or not?

> 2) I question the use of enumerations for the content.  I understand
> that since IANA will generate new YANG modules when there is a
> change, the new models can have new values.  I am concerned that if
> an implementation using the older schema reads data from a DNS
> repository with updated entries (and the corresponding updated
> version) the version skew will cause processing errors instead of
> simply handing over the numeric value in a fashion that is
> acceptable but not understood.

This is partly alleviated by the YANG union types "dns-class" and "rr-type" that should be used for configuration data: old clients can always use corresponding numeric values in place of unsupported enums.

If the module update rules of sec. 11 in RFC 7950 are observed, then the risk of interoperability issues is IMO reasonably low.

Lada

>
> Nits/editorial comments:
>
>
>

-- 
Ladislav Lhotka
Head, CZ.NIC Labs
PGP Key ID: 0xB8F92B08A9F76C67