Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd

Alia Atlas <akatlas@gmail.com> Tue, 03 November 2015 05:27 UTC

Return-Path: <akatlas@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5FB621ACCEF; Mon, 2 Nov 2015 21:27:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.999
X-Spam-Level:
X-Spam-Status: No, score=-101.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QxW-h0i7J5sz; Mon, 2 Nov 2015 21:27:14 -0800 (PST)
Received: from mail-ob0-x232.google.com (mail-ob0-x232.google.com [IPv6:2607:f8b0:4003:c01::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BCBE81A8F50; Mon, 2 Nov 2015 21:27:13 -0800 (PST)
Received: by obctp1 with SMTP id tp1so4560366obc.2; Mon, 02 Nov 2015 21:27:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lCwX+ScGLKJL4HEeupfH7Jwdslsgizd3bsm8fpPMeL0=; b=Xilp1lHronJme/C7AypTbKvkIhGp1Ljk7BRASm01KwIDGnUiwwwb9X9/1r3B8w5T7H Q4VdTFJt6punDKfvpSyXvE7uLZZog1G+tqtFoS+VtB88cU/gOwjiB7s9iRfFyhTOlywL BxpZRtvw5syFE3M4bcaxrNrTEbOGZogZuIxt/VNxc1EBpTNxG+jyzyA5SQUTAhMIezC4 bfHxif+XBZL1f07qMul9q1X4TbZnj2hZUY5yRlPaZeDgL18RJtWzmF0W28Z+q518BLlV 1/uJ1KnQcimq54i5YYKYF52DOc0ZkaqAbK59nRNaqwCmDK0E3jMplHb/UunnP1O3/r7G GjbQ==
MIME-Version: 1.0
X-Received: by 10.60.116.101 with SMTP id jv5mr18021834oeb.24.1446528433206; Mon, 02 Nov 2015 21:27:13 -0800 (PST)
Received: by 10.60.6.132 with HTTP; Mon, 2 Nov 2015 21:27:13 -0800 (PST)
In-Reply-To: <40746B2300A8FC4AB04EE722A593182B9C8214D6@ONWVEXCHMB04.ciena.com>
References: <095AB7C0-C1B7-4963-852C-A5A613AD261A@cisco.com> <40746B2300A8FC4AB04EE722A593182B9ACC4AF3@ONWVEXCHMB04.ciena.com> <D98030BB-32EB-4859-A71B-8D54BDBF031C@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C37860E@ONWVEXCHMB04.ciena.com> <2F4FBE17-D7D8-4B96-AB1C-8ACFE48B2630@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C378941@ONWVEXCHMB04.ciena.com> <CAA=duU0Jeva2=1CdKxW3D3wHonFnWv7JpwWkyD6ORePzQfmSYg@mail.gmail.com> <40746B2300A8FC4AB04EE722A593182B9C3789B3@ONWVEXCHMB04.ciena.com> <8D144BAF-E93F-4BCE-A940-E1AB48947C12@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C8214D6@ONWVEXCHMB04.ciena.com>
Date: Tue, 03 Nov 2015 00:27:13 -0500
Message-ID: <CAG4d1rfw5HkgOAOf2cDogzFLowN-N1Qfi4gRms73Jw-_2wnSgg@mail.gmail.com>
From: Alia Atlas <akatlas@gmail.com>
To: "Shah, Himanshu" <hshah@ciena.com>
Content-Type: multipart/alternative; boundary="089e0115f0526b3ca705239c25f8"
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/JSf04xLeOJErAJgWrtEn9DqpapM>
Cc: General Area Review Team <gen-art@ietf.org>, "Andrew G. Malis" <agmalis@gmail.com>, "Ralph Droms (rdroms)" <rdroms@cisco.com>, "draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org" <draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org>, The IESG <iesg@ietf.org>
Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2015 05:27:16 -0000

Himanshu,

This looks good to me.  Can you please submit the updated draft?

Regards,
Alia

On Mon, Nov 2, 2015 at 2:24 PM, Shah, Himanshu <hshah@ciena.com> wrote:

> Hi Ralph and Alia -
>
> Ralph - I have replace the sequence number/mac withdraw sub-TLV
> registration,
> Section with request for the value 0x0001 from the LDP's TLV type name
> space.
> Please review and verify that it addresses your concern.
>
> Alia - I have also addressed your concern by replacing the original text
> with
> Steve Bryant's offered text (which you stated you were OK with). Please
> review,
> verify and accept by removing "DISCUSS" on this draft review.
>
> Thanks,
> Himanshu
>
> -----Original Message-----
> From: Shah, Himanshu
> Sent: Monday, October 26, 2015 7:05 PM
> To: 'Ralph Droms (rdroms)'
> Cc: Andrew G. Malis; A. Jean Mahoney; General Area Review Team;
> draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG
> Subject: RE: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
>
> Hi Ralph -
>
> You make a good point on the sub-TLV.
> I have talked to my WG chairs and we are going to change the text based on
> your suggestion.
> I will remove the MAC Withdraw sub-TLV registry for sequence number TLV
> and instead use the Value from the LDP Type values (same as MAC List TLV).
>
> As for combining text of section 3 and 4.1.
>
> Section 3 described the packet fields, including the sequence number text.
> The reason for sequence number text is - that it is applicable to both;
> Sender (section 4.1) and Receiver (section 4.2).
>
> I will explore to remove the overlap..
>
> Thanks,
> Himanshu
>
>
> -----Original Message-----
> From: Ralph Droms (rdroms) [mailto:rdroms@cisco.com]
> Sent: Monday, October 26, 2015 3:13 PM
> To: Shah, Himanshu
> Cc: Andrew G. Malis; A. Jean Mahoney; General Area Review Team;
> draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG
> Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
>
> Himanshu - I've been tied up in meetings most of the day today and am
> about to go into more meetings that will last until the end of the day.
>
> I reviewed your revised draft briefly and it mostly looks OK.  I have one
> substantive comment, which is about an issue I didn't notice until now:
>
> How is the Mac Withdraw sub-TLV registry from which the "Sequence Number"
> code point is taken differentiated from the LDP Parameters sub-TLV registry
> from which the "MAC List" and "MAC Flush Parameter" code points are taken?
> In other words, how does the receciver know to interpret the code point on
> the Sequence Number TLV as a code point in the Mac Withdraw sub-TLV
> registry while the code points on the MAC List TLV and the MAC Flush
> Paramter TLV are interpreted as code points in the LDP Paramteres sub-TLV?
> Shouldn't all the code points on the TLVs in this message come from a
> single registry?
>
> I also have an editorial comment from my earlier review: the ifrst
> paragraph of section 3 is mostly redundant with section 4.1 and that text
> in section 3 should be merged into the text in section 4.1
>
> - Ralph
>
> > On Oct 26, 2015, at 2:09 PM 10/26/15, Shah, Himanshu <hshah@ciena.com>
> wrote:
> >
> > Thanks Andy.
> > He did re-send the email without MIME and I was able to read and reply.
> >
> > Thanks,
> > Himanshu
> >
> > From: Andrew G. Malis [mailto:agmalis@gmail.com]
> > Sent: Monday, October 26, 2015 2:08 PM
> > To: Shah, Himanshu
> > Cc: Ralph Droms (rdroms); A. Jean Mahoney; General Area Review Team;
> > draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG
> > Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
> >
> > Himanshu,
> >
> > Ralph said:
> >
> > Himanshu - I've received your revised draft.  I've been stuck in a
> variety of meetings Monday and haven't had time to review it.  I should be
> able to look at it before the end of the day.
> >
> > - Ralph
> >
> > On Mon, Oct 26, 2015 at 1:04 PM, Shah, Himanshu <hshah@ciena.com> wrote:
> > Can you send the email without MIME signature?
> >
> > Thanks,
> > Himanshu
> >
> > From: Ralph Droms (rdroms) [mailto:rdroms@cisco.com]
> > Sent: Monday, October 26, 2015 1:02 PM
> > To: Shah, Himanshu
> > Cc: A. Jean Mahoney; General Area Review Team;
> > draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG
> > Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
>
>
>