[Gen-art] Gen-ART LC Review of draft-ietf-ippm-rate-problem-08
Ben Campbell <ben@nostrum.com> Mon, 22 December 2014 23:31 UTC
Return-Path: <ben@nostrum.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23DF91A6FFC for <gen-art@ietfa.amsl.com>; Mon, 22 Dec 2014 15:31:41 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.91
X-Spam-Level:
X-Spam-Status: No, score=-1.91 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xpcfYo2BxDKJ for <gen-art@ietfa.amsl.com>; Mon, 22 Dec 2014 15:31:39 -0800 (PST)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2291F1A6F28 for <gen-art@ietf.org>; Mon, 22 Dec 2014 15:31:39 -0800 (PST)
Received: from [10.0.1.23] (cpe-173-172-146-58.tx.res.rr.com [173.172.146.58]) (authenticated bits=0) by nostrum.com (8.14.9/8.14.7) with ESMTP id sBMNVaZg069172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Dec 2014 17:31:37 -0600 (CST) (envelope-from ben@nostrum.com)
X-Authentication-Warning: raven.nostrum.com: Host cpe-173-172-146-58.tx.res.rr.com [173.172.146.58] claimed to be [10.0.1.23]
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
From: Ben Campbell <ben@nostrum.com>
Date: Mon, 22 Dec 2014 17:31:35 -0600
X-Mao-Original-Outgoing-Id: 440983895.83676-9d59670c707ee3ad4b33959341acaffe
Content-Transfer-Encoding: quoted-printable
Message-Id: <41FE5731-31A7-43E2-B36B-CCDDCD7EC858@nostrum.com>
To: draft-ietf-ippm-rate-problem.all@tools.ietf.org
X-Mailer: Apple Mail (2.1993)
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/KFQRsZUbNYq6fPLezdWxfUhIDMs
Cc: "gen-art@ietf.org Team (gen-art@ietf.org)" <gen-art@ietf.org>
Subject: [Gen-art] Gen-ART LC Review of draft-ietf-ippm-rate-problem-08
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Dec 2014 23:31:41 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Document: draft-ietf-ippm-rate-problem-08 Reviewer: Ben Campbell Review Date: 2014-12-22 IETF LC End Date: 2014-12-22 IESG Telechat date: (if known) Summary: The draft is almost ready for publication as an informational RFC. I have a few comments that might should be considered first. Major issues: None Minor issues: -- section 3, paragraph 3: "Service testing MUST respect" Who or what does the MUST apply to? The protocol (or protocol designers)? The users of the protocol? (I note that much of the draft uses the form "The protocol MUST...", is the same meant here?) -- section 3, paragraph 4: This paragraph seems to be saying that the protocol must meet other, non-enumerated "practical matter" requirements. It seems like those should be actually enumerated. -- section 4, paragraph immediately after alpha list: The first sentence seems to be redundant with normative text right before the list. -- section 5, first paragraph: The first sentence seems to be redundant with normative text in the previous section. If the idea is to point out that the requirements in the previous section, please consider using descriptive language instead of 2119 language. (Repeated normative text tends to be error prone, and creates confusion about which text is authoritative.) -- section 5, note concerning "vanishing number of symmetrical-rate..." Does this mean the protocol doesn't have to worry about it, or that while the number is shrinking it still needs to be considered? Nits/editorial comments: -- Abstract: second sentence This sentence is pretty heavy on the sales pitch, and will likely become irrelevant once the work this draft contemplates is done. Please consider whether you really want it in the abstract. (For the record, I have no objection to the similar language in the intro.) -- General: Consider numbering you diagrams and using cross references, rather than "below". Don't count on them being in the same relative position with the text that references them in all possible renderings. -- Section 1, diagram: It's not clear to me whether the "User, Device, or Host" label(s)" are intended to be one label for all 3 access methods, or if user is tied to fiber, Device to copper, etc. I assume the former, but the diagram looks more like the latter. -- 2, paragraph starting with "Support of active measurement methods will be addressed here..." What is meant by "here"? This document? Or the working group? (If the former, consider present tense.) -- 2, last paragraph: This draft _is_ the problem statement, right? Consider saying "problem statement mandates" rather than "will mandate". -- section 3, paragraph 6: "it is expected...MUST" The phrase "it is expected" seems odd in combination with MUST. Does this mean it _might_ be a MUST? Assuming that's not the case, I suggest dropping "it is expected that". -- section 4, preface to alpha list: This means "All _supported_ categories", correct? -- section 4, 2nd to last paragraph: What actionable guidance is intended by this paragraph? -- section 4, last paragraph "(these could be listed later, if desired)" Listed in this document, or somewhere else. Is this text that was intended to be deleted? -- same paragraph: "... protocol entity that collects results." Is this the RECEIVER? The REPORTER? I suggest sticking to the defined terms.
- [Gen-art] Gen-ART LC Review of draft-ietf-ippm-ra… Ben Campbell