Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-ipsecme-labeled-ipsec-10

Lars Eggert <lars@eggert.org> Mon, 24 April 2023 14:03 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7233FC14CF15; Mon, 24 Apr 2023 07:03:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wcebgN1cJ_z3; Mon, 24 Apr 2023 07:03:22 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 895E8C152D94; Mon, 24 Apr 2023 07:03:22 -0700 (PDT)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:cc:515f:3561:e4cb]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 90CD3208BD; Mon, 24 Apr 2023 17:03:12 +0300 (EEST)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: Lars Eggert <lars@eggert.org>
Mime-Version: 1.0 (1.0)
Date: Mon, 24 Apr 2023 17:03:11 +0300
Message-Id: <3E27D0CC-D8B2-4020-B1CD-5E914AC9CD09@eggert.org>
References: <168115302430.32336.7010056407732824949@ietfa.amsl.com>
Cc: gen-art@ietf.org, draft-ietf-ipsecme-labeled-ipsec.all@ietf.org, ipsec@ietf.org, last-call@ietf.org
In-Reply-To: <168115302430.32336.7010056407732824949@ietfa.amsl.com>
To: Ines Robles <mariainesrobles@googlemail.com>
X-MailScanner-ID: 90CD3208BD.A8852
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/KTWGXEJfQvi7FitnWxQperPDjrY>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-ipsecme-labeled-ipsec-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2023 14:03:26 -0000

Ines, thank you for your review! I have entered a No Objection ballot.

Lars

> On 10. Apr 2023, at 21:57, Ines Robles via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Ines Robles
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-ipsecme-labeled-ipsec-10
> Reviewer: Ines Robles
> Review Date: 2023-04-10
> IETF LC End Date: 2023-04-10
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> This document defines a new Traffic Selector (TS) Type for Internet Key
> Exchange version 2 to add support for negotiating Mandatory Access Control
> (MAC) security labels as a traffic selector of the Security Policy Database
> (SPD).  The new TS type is TS_SECLABEL.
> 
> The document is well written and easy to read.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments:
> 
> Section 3.2: "198.51.0/24" --> "198.51.100.0/24" ?
> 
> Question: Section 2.1, the Security Label should be at least of one octet. Is
> there a limit of octets for this field?
> 
> Thank you for this document,
> 
> Ines.
> 
> 
> 
> -- 
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call