Re: [Gen-art] Gen-ART review: draft-ietf-pwe3-pw-typed-wc-fec-03

Kamran Raza <skraza@cisco.com> Mon, 09 April 2012 19:49 UTC

Return-Path: <skraza@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAA5F21F87E4 for <gen-art@ietfa.amsl.com>; Mon, 9 Apr 2012 12:49:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.135
X-Spam-Level:
X-Spam-Status: No, score=-7.135 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HTML_MESSAGE=0.001, MIME_QP_LONG_LINE=1.396, RCVD_IN_DNSWL_HI=-8, RCVD_NUMERIC_HELO=2.067]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ft3rIOvdQYEL for <gen-art@ietfa.amsl.com>; Mon, 9 Apr 2012 12:49:22 -0700 (PDT)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) by ietfa.amsl.com (Postfix) with ESMTP id 3380B21F87E3 for <gen-art@ietf.org>; Mon, 9 Apr 2012 12:49:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=skraza@cisco.com; l=9099; q=dns/txt; s=iport; t=1334000962; x=1335210562; h=date:subject:from:to:cc:message-id:in-reply-to: mime-version; bh=gw+rG5vfiI2T8+GvSWR0c3YFON8k76sZ0TFihl5L30w=; b=UsZwnunMBYB7/JdfLSKf5+pcLINnle8lzdkOGSTvdESb90Fxym6uzMrc QFkT5LKRh9uHRTJmrPgD433UMxIxFJ5H8YYeWC+US9YP4P0qGxiGem0b0 +JFnl9w+b/gno43GDWa85a/QB2EyzurZn0hgq3rr1XhLstF9InQ72vlKv g=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: Aq4IAFQ8g0+tJV2d/2dsb2JhbABAA4JTrXWII3MCgQeCCQEBAQMBEgEUFhgREwUNAQgUUzYBAQQBDQUbB4deAwYFC55bljMNgWuKLYMVgykEiCeNRYERiiiDFCeBQoMD
X-IronPort-AV: E=Sophos; i="4.75,393,1330905600"; d="scan'208,217"; a="73223570"
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by rcdn-iport-2.cisco.com with ESMTP; 09 Apr 2012 19:49:21 +0000
Received: from xbh-rcd-102.cisco.com (xbh-rcd-102.cisco.com [72.163.62.139]) by rcdn-core-6.cisco.com (8.14.3/8.14.3) with ESMTP id q39JnLa1014368; Mon, 9 Apr 2012 19:49:21 GMT
Received: from xmb-rcd-103.cisco.com ([72.163.62.145]) by xbh-rcd-102.cisco.com with Microsoft SMTPSVC(6.0.3790.4675); Mon, 9 Apr 2012 14:49:07 -0500
Received: from 161.44.193.212 ([161.44.193.212]) by XMB-RCD-103.cisco.com ([72.163.62.145]) with Microsoft Exchange Server HTTP-DAV ; Mon, 9 Apr 2012 19:49:07 +0000
User-Agent: Microsoft-Entourage/12.32.0.111121
Date: Mon, 09 Apr 2012 15:51:01 -0400
From: Kamran Raza <skraza@cisco.com>
To: Mary Barnes <mary.ietf.barnes@gmail.com>, <draft-ietf-pwe3-pw-typed-wc-fec.all@tools.ietf.org>
Message-ID: <CBA8B5E5.27E2D%skraza@cisco.com>
Thread-Topic: Gen-ART review: draft-ietf-pwe3-pw-typed-wc-fec-03
Thread-Index: Ac0Wihb0KiakvUC5Ck2YBEcnhBobPg==
In-Reply-To: <CAHBDyN4-z57zkkc8_thG+PPPso38vZNZy496xNviS+10BPj6_w@mail.gmail.com>
Mime-version: 1.0
Content-type: multipart/alternative; boundary="B_3416831462_48426"
X-OriginalArrivalTime: 09 Apr 2012 19:49:07.0946 (UTC) FILETIME=[D39154A0:01CD1689]
X-Mailman-Approved-At: Mon, 09 Apr 2012 12:52:18 -0700
Cc: gen-art@ietf.org
Subject: Re: [Gen-art] Gen-ART review: draft-ietf-pwe3-pw-typed-wc-fec-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Apr 2012 19:49:24 -0000

Thanks Mary for your review.

Agree with all your comments and will fix them in next revision accordingly.

Rgds,
-- Kamran

On 12-04-09 3:21 PM, "Mary Barnes" <mary.ietf.barnes@gmail.com> wrote:

> I am the assigned Gen-ART reviewer for this draft. For background on
> Gen-ART, please see the FAQ at
> < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>gt;.
> 
> Please wait for direction from your document shepherd
> or AD before posting a new version of the draft.
> 
> Document: draft-ietf-pwe3-pw-typed-wc-fec-03.txt
> Reviewer:  Mary Barnes 
> Review Date:  9 April 2012
> IESG Telechat Date: 12 April 2012
> 
> Summary:  Ready with nits.
> 
> Comments: there are some editorial nits, many summarized below.  There are
> several cases where an article - i.e., "the", "an", etc. is missing.   I
> believe these can be fixed in AUTH48 and I imagine the RFC editor will catch
> them. But, if the doc needs any other updates, it would be good to make these
> fixes at the same time.  
> 
> Nits:
> -----
> Section 1: 
> - first paragraph, second sentence is very awkward and could be rewritten
> something like (unless I've misunderstood the objective of that sentence:
> OLD:
>    This can be used when it is 
>    desired to request all label bindings for a given type of FEC 
>    Element, or to release or withdraw all label bindings for a given 
>    type of FEC element. 
> NEW: 
>    This can be used to request, release or withdraw all label 
>    bindings for a given type of FEC element.
> 
> [skraza]: Agree.
> 
> - second paragraph, last sentence - missing articles (PWID, same)
> OLD:
>    The procedures for Typed Wildcard processing for PWid and  
>    Generalized PWid FEC Elements are same as described in [RFC5918] for 
>    any typed wildcard FEC Element type.
> NEW: 
>    The procedures for Typed Wildcard processing for the PWid and  
>    Generalized PWid FEC Elements are the same as described in [RFC5918] for 
>    any typed wildcard FEC Element type.
> 
> Section 3:
> - third paragraph, last sentence before list: 
> OLD: 
>  provide 
>   more generalized and comprehensive solution by allowing: 
> NEW: 
>   provide a
>   more generalized and comprehensive solution by allowing: 
> 
> - list item 2: "constraint" -> "constrain"
> 
> 
> 
> Section 4.1: 
> OLD:
>  "Š had learnt from LSR B over LDP session."
> NEW: 
>  " Š learned from the LSR B over the LDP session."
> 
> OLD:
>  "Šsuch requestŠ" 
> NEW:
>  "Šsuch a requestŠ"  OR "..the requestŠ"
> 
> OLD: 
>  (no stale)
> NEW: 
>  (not stale)
> 
> OLD:
>   completes consistency check
> NEW:
>   completes the consistency check
> 
> Section 4.3: 
> - first paragraph, last sentence:  
> OLD: 
>   with large number
> NEW:
>   with a large number
> 
> Section 4.4:
> - 1st para, 2nd sentence:
> OLD: 
>    These procedures use LDP Address Withdraw message
> NEW: 
>    These procedures use an LDP Address Withdraw message
> 
> - 2nd paragraph, last sentence:
> OLD:
>   This per PW (VPLS instance) MAC Withdraw messages 
> NEW: 
>   These per PW (VPLS instance) MAC Withdraw messages 
> 
> 3rd paragraph - 1st sentence:
> OLD:
>   this document allows use of
> NEW: 
>   this document allows the use of
> 

-- 
Syed Kamran Raza
Technical Leader, SPRSG IOS-XR Routing (MPLS)
Cisco Systems, Inc.,
Kanata, ON, K2K 3E8, Canada
Ph: +1 (613) 254-4520
http://www.cisco.com