Re: [Gen-art] Genart telechat review of draft-ietf-nvo3-hpvr2nve-cp-req-13

Liyizhou <liyizhou@huawei.com> Wed, 07 February 2018 02:46 UTC

Return-Path: <liyizhou@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9552812DA0A; Tue, 6 Feb 2018 18:46:28 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.231
X-Spam-Level:
X-Spam-Status: No, score=-4.231 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SHDjPivmgLrr; Tue, 6 Feb 2018 18:46:26 -0800 (PST)
Received: from huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4E0511200F1; Tue, 6 Feb 2018 18:46:26 -0800 (PST)
Received: from lhreml706-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 596CBD7513A1B; Wed, 7 Feb 2018 02:46:22 +0000 (GMT)
Received: from NKGEML412-HUB.china.huawei.com (10.98.56.73) by lhreml706-cah.china.huawei.com (10.201.108.47) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 7 Feb 2018 02:46:23 +0000
Received: from NKGEML513-MBS.china.huawei.com ([169.254.2.231]) by nkgeml412-hub.china.huawei.com ([10.98.56.73]) with mapi id 14.03.0361.001; Wed, 7 Feb 2018 10:46:20 +0800
From: Liyizhou <liyizhou@huawei.com>
To: Brian Carpenter <brian.e.carpenter@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "nvo3@ietf.org" <nvo3@ietf.org>, "draft-ietf-nvo3-hpvr2nve-cp-req.all@ietf.org" <draft-ietf-nvo3-hpvr2nve-cp-req.all@ietf.org>
Thread-Topic: Genart telechat review of draft-ietf-nvo3-hpvr2nve-cp-req-13
Thread-Index: AQHTn5pZe98RhtKr/kyr9m0YrD3sQ6OYOqwQ
Date: Wed, 07 Feb 2018 02:46:19 +0000
Message-ID: <D408889639FC5E4FADB4E00A3E01FA8FA6B4236C@nkgeml513-mbs.china.huawei.com>
References: <151795632835.25952.6168100923198993264@ietfa.amsl.com>
In-Reply-To: <151795632835.25952.6168100923198993264@ietfa.amsl.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.134.186.229]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/LPeq63UJ_QA7h4kKL_flO7BXVU0>
Subject: Re: [Gen-art] Genart telechat review of draft-ietf-nvo3-hpvr2nve-cp-req-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2018 02:46:29 -0000

Thanks Brian.

I will add " An IP address can be in either IPv4 or IPv6 format." to Section 1.2 Target Scenarios as below.

Section 1.2 Target Scenarios
.... In the Split-NVE architecture, the external NVE may be able to reach multiple MAC and IP addresses via a TSI. *An IP address can be in either IPv4 or IPv6 format.* For example, .....

Rgds,
Yizhou

-----Original Message-----
From: Brian Carpenter [mailto:brian.e.carpenter@gmail.com] 
Sent: Wednesday, February 07, 2018 6:32 AM
To: gen-art@ietf.org
Cc: nvo3@ietf.org; draft-ietf-nvo3-hpvr2nve-cp-req.all@ietf.org
Subject: Genart telechat review of draft-ietf-nvo3-hpvr2nve-cp-req-13

Reviewer: Brian Carpenter
Review result: Ready with Issues

Gen-ART Last Call review of draft-ietf-pce-pcep-exp-codepoints-04

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-nvo3-hpvr2nve-cp-req-13.txt
Reviewer: Brian Carpenter
Review Date: 2018-02-07
IETF LC End Date: 2018-02-20
IESG Telechat date: 2018-02-22

Summary: Ready (with minor issue)
--------

Comment:
--------

This is a Last Call review despite the subject field.

Minor issue:
------------

   Req-10: The protocol MUST allow an End Device initiating a request to
   add, remove or update address(es) associated with a TSI instance on
   the external NVE. Addresses can be expressed in different formats,
   for example, MAC, IP or pair of IP and MAC.

Here and elsewhere, it seems necessary to specify that an IP address can be in either IPv4 or IPv6 format. (This is implied in Table 1 and at the end of Appendix A, but that's quite well hidden.) I suggest clarifying this early, in Section 1.2 "Target Scenarios".