Re: [Gen-art] Genart last call review of draft-ietf-mpls-rfc8287-len-clarification-02
Alissa Cooper <alissa@cooperw.in> Tue, 06 August 2019 19:11 UTC
Return-Path: <alissa@cooperw.in>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9F5C712003F; Tue, 6 Aug 2019 12:11:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=zeXPr6CB; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=nhhxElGk
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s3lii41Ifgu1; Tue, 6 Aug 2019 12:11:54 -0700 (PDT)
Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 32D34120059; Tue, 6 Aug 2019 12:11:54 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2CC6A451; Tue, 6 Aug 2019 15:11:53 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 06 Aug 2019 15:11:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm3; bh=X regXEOgTXAKp/E51oVDXPrB4mp/prlABjVtlp5d3N4=; b=zeXPr6CBarZgzHhq+ j0XM9wbxjbYiZV36d1R/uQk1Z0+fgmy1BThSFeuwX+YprqWgJ4XQmDHZ6/tMHUJ+ 4bgA5RBz3l/2L3BIkbSeFZ4w2GiuBL9MNoiJO9h30InLg0no7/TbmVPAa5jporns G2HDGCDptXgQNUHfJyS9hsgIJ01HmXxaOOqlUgwAyvArn0uEMBNM3egICJNp65Jn NyEhV1H+hY6z9YbkVucqUuSpxWE4E2ftSM4C4zwnpXBRIJ9G95+yqSbH/1wZDJUl BG0y2oWd+cey6dGSasoq2Xx0fukpjHec9NBHfvfgs+kq320jh3Zz3MCs64S5i3AV ztqBg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=XregXEOgTXAKp/E51oVDXPrB4mp/prlABjVtlp5d3 N4=; b=nhhxElGk1Y6BPjFG5GCRJw2OkS2Rwuxc3tF76y9+6+mOBODooihjRnw/x E5GouKqxzcK9Yz3YZ4o4dSlAibVrnwzTH0aZRsJd+Y90Ftw0F/eES95L42FCCfLN ZRKcqezg9rFpvTa6y9jvJ2DidR5mhX6wZEoQCUEWDKGi72eIf3aKoDjhHbt7lJMv V4rnn94ygz1YQodq8gkQQbZwpqUIHcILrzTMDHVdnVytCzuWLNdHt+oNxWzFyrUv NcaPnl7iSk5XfIwzu/RAfTgh/OxeBluaMZSuuynfF3mNV1HKZIien8wjwqARq1Wf o9afm8FYowyBvsTL/VmwugDsp5LxA==
X-ME-Sender: <xms:99BJXbmRx7Hkr_BAj7Rk3ALUSoIbg9W7BIQBw2ZMBVPKuEZGuBcKyg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddruddutddgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeetlhhi shhsrgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomh grihhnpehivghtfhdrohhrghenucfkphepuddtkedrhedurddutddurdelkeenucfrrghr rghmpehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinhenucevlhhush htvghrufhiiigvpedt
X-ME-Proxy: <xmx:-NBJXS0yBAbSV_oV5YrfP5Valbw2lC5pmA-P7Lbx0PowI0EKyZ50Lg> <xmx:-NBJXSQACnBw0hYv0pJcKNxgKPDAjofffuR-kG4oWqJLpRs3RadGFA> <xmx:-NBJXTe1lZ4ShmSAEliJPL8V2ymrUA6jm0JU0ns0fUH1y5Gc_7py1w> <xmx:-NBJXbC9ydyMTBGFoLSEj9Ye9RMgwmJov004xv9sbcD1sgZ4xO5ujQ>
Received: from alcoop-m-c46z.fios-router.home (pool-108-51-101-98.washdc.fios.verizon.net [108.51.101.98]) by mail.messagingengine.com (Postfix) with ESMTPA id 6D95380060; Tue, 6 Aug 2019 15:11:51 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <156448869146.2787.8676709133801114398@ietfa.amsl.com>
Date: Tue, 06 Aug 2019 15:11:50 -0400
Cc: gen-art@ietf.org, mpls@ietf.org, ietf@ietf.org, draft-ietf-mpls-rfc8287-len-clarification.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <10B18110-50E1-4969-841F-084158A3EFEE@cooperw.in>
References: <156448869146.2787.8676709133801114398@ietfa.amsl.com>
To: Ines Robles <mariainesrobles@googlemail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/LloHEOtfZl4583--ruA56br8jRw>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-mpls-rfc8287-len-clarification-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Aug 2019 19:11:57 -0000
Ines, thanks for your review. I entered a DISCUSS ballot to get the figure fixed in Section 4.2. Alissa > On Jul 30, 2019, at 8:11 AM, Ines Robles via Datatracker <noreply@ietf.org> wrote: > > Reviewer: Ines Robles > Review result: Ready with Issues > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being processed > by the IESG for the IETF Chair. Please treat these comments just > like any other last call comments. > > For more information, please see the FAQ at > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. > > Document: draft-ietf-mpls-rfc8287-len-clarification-02 > Reviewer: Ines Robles > Review Date: 2019-07-30 > IETF LC End Date: 2019-07-31 > IESG Telechat date: Not scheduled for a telechat > > Summary: > > I believe the draft is technically good. This document is well written. > > The document updates RFC8287 by clarifying the length for the following Segment > ID Sub-TLVs: IPv4 IGP-Prefix Segment ID Sub-TLV, IPv6 IGP-Prefix Segment ID > Sub-TLV and IGP-Adjacency Segment ID Sub-TLV. > > There are some minor issues detailed below that should be addressed. > > Major issues: Not found > > Minor issues: > > 1- Section 3 - Requirements notation is not complete, it should be added: "NOT > RECOMMENDED" and "...are to be interpreted as described in BCP 14 [RFC2119] > [RFC8174] when, and only when, they appear in all capitals, as shown here." > > 2- Figure of Section 4.2: Type = 35 (IPv4 IGP-Prefix SID) ---> Type = 35 (IPv6 > IGP-Prefix SID) > > 2.1- It would be nice if the figures have a caption where we can point to the > figure number, and the figure number is referenced in the text. The same for > the table of Section 4.3. > > 3- Question: What do you think? > > I think it would be nice to explain a bit more the length for the different > combinations of the table of Section 4.3, e.g. with tables as detailed below: > > +-----------------------------+-------------------+ > | Field | Parallel (octets) | > | rfc8287#section-5.3 +-----+------+------+ > | | Any | OSPF | ISIS | > +-----------------------------+-----+------+------+ > | Local Interface ID | 4 | 4 | 4 | > +-----------------------------+-----+------+------+ > | Remote Interface ID | 4 | 4 | 4 | > +-----------------------------+-----+------+------+ > | Advertising Node Identifier | 4 | 4 | 6 | > +-----------------------------+-----+------+------+ > | Receiving Node Identifier | 4 | 4 | 6 | > +-----------------------------+-----+------+------+ > | Reserved | 2 | 2 | 2 | > +-----------------------------+-----+------+------+ > | Adj. Type + Protocol | 2 | 2 | 2 | > +-----------------------------+-----+------+------+ > | Sum Total octets = | 20 | 20 | 24 | > +-----------------------------+-----+------+------+ > > +-----------------------------+-------------------+ > | Field | IPv4 (octets) | > | rfc8287#section-5.3 +-----+------+------+ > | | Any | OSPF | ISIS | > +-----------------------------+-----+------+------+ > | Local Interface ID | 4 | 4 | 4 | > +-----------------------------+-----+------+------+ > | Remote Interface ID | 4 | 4 | 4 | > +-----------------------------+-----+------+------+ > | Advertising Node Identifier | 4 | 4 | 6 | > +-----------------------------+-----+------+------+ > | Receiving Node Identifier | 4 | 4 | 6 | > +-----------------------------+-----+------+------+ > | Reserved | 2 | 2 | 2 | > +-----------------------------+-----+------+------+ > | Adj. Type + Protocol | 2 | 2 | 2 | > +-----------------------------+-----+------+------+ > | Sum Total octets = | 20 | 20 | 24 | > +-----------------------------+-----+------+------+ > > +-----------------------------+-------------------+ > | Field | IPv6 (octets) | > | rfc8287#section-5.3 +-----+------+------+ > | | Any | OSPF | ISIS | > +-----------------------------+-----+------+------+ > | Local Interface ID | 16 | 16 | 16 | > +-----------------------------+-----+------+------+ > | Remote Interface ID | 16 | 16 | 16 | > +-----------------------------+-----+------+------+ > | Advertising Node IdentifieR | 4 | 4 | 6 | > +-----------------------------+-----+------+------+ > | Receiving Node Identifier | 4 | 4 | 6 | > +-----------------------------+-----+------+------+ > | Reserved | 2 | 2 | 2 | > +-----------------------------+-----+------+------+ > | Adj. Type + Protocol | 2 | 2 | 2 | > +-----------------------------+-----+------+------+ > | sum Total octets = | 44 | 44 | 48 | > +-----------------------------+-----+------+------+ > > Nits/editorial comments: Issue tool: Summary: 0 errors (**), 0 flaws (~~), 0 > warnings (==), 1 comment (--). > > Thanks for this document, > > Ines > > _______________________________________________ > Gen-art mailing list > Gen-art@ietf.org > https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Genart last call review of draft-ietf-m… Ines Robles via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Alissa Cooper
- Re: [Gen-art] Genart last call review of draft-ie… Carlos Pignataro (cpignata)
- Re: [Gen-art] Genart last call review of draft-ie… Ines Robles