IETF Logo Mail Archive

Re: [Gen-art] [Curdle] Genart last call review of draft-ietf-curdle-ssh-kex-sha2-14

Ron Frederick <ronf@timeheart.net> Mon, 15 February 2021 21:16 UTC

Return-Path: <ronf@timeheart.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A7FA3A1182 for <gen-art@ietfa.amsl.com>; Mon, 15 Feb 2021 13:16:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.199
X-Spam-Level:
X-Spam-Status: No, score=-0.199 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=timeheart.net
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tCnpo1OF1hre for <gen-art@ietfa.amsl.com>; Mon, 15 Feb 2021 13:16:54 -0800 (PST)
Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 55AFE3A1185 for <gen-art@ietf.org>; Mon, 15 Feb 2021 13:16:54 -0800 (PST)
Received: by mail-pj1-x102f.google.com with SMTP id q72so4427192pjq.2 for <gen-art@ietf.org>; Mon, 15 Feb 2021 13:16:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=timeheart.net; s=mail; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=TDASMEAns0aPxreCDkWdVd4faVn1xpj3hFH55B+wSy0=; b=H3fQIam+yLemxYmiJVYYUfagaVaWjx1A/wtWhF1TxzP46pgeOcjjTXOTkvpwHunRlJ 6A5nvVfphNEui1G+ycoQ0fdjDQtllEN8khNZSpljzptRK3DSXnanSDHvYpo/MTyn0s1g uyUYESGdmg3J2ima6/kXVq6I5InQm1QFtFlxs=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=TDASMEAns0aPxreCDkWdVd4faVn1xpj3hFH55B+wSy0=; b=qhbhPsJY5K1R8YY1YzqMQBEIfU1UPZTxGpFDpo7CQvcjL1Zgotc7uDFNbiln3ThobL kkpSoRGjKqP6hoQVlbIs078qbGw1dK53vqN4CCf+B8BAiTNERnTzMZG3RJ4PaoOPWwYb Y4mTyKy7/SqjxiRaazDzTWs2yE/qYMPTi51HhjNVU9hyXxFzaEK8Zno4b8xV/9poCuH2 ioDQOYxKfBjYP1j6xY733GkX8tTlXOWcy1S1ZJwtWrsFriSOrx4CuIa7dTm+PP/j1RfX /A3yItKg7JLk/ZEYsZ4qptGku+Z0ukOQR30zBSOoPhQj6yXbHOoJieYwuQZkgkPgoMbJ bLUQ==
X-Gm-Message-State: AOAM533D05JjbojAsN/Dy6a7LUXQbanY9AM4X+HYoN3K5Wj0jQGxwqBf Tn/J5Z0y7tkGIUK0aJnClcc/+g==
X-Google-Smtp-Source: ABdhPJwlYVXVtn1aPRokl4KgWcTgoEMkxYsdbRbb83kvkAV37oDmI4PcCuZM3ufVWhEWUaDRaVkQPQ==
X-Received: by 2002:a17:903:8b:b029:e2:d409:cba2 with SMTP id o11-20020a170903008bb02900e2d409cba2mr16389896pld.79.1613423813788; Mon, 15 Feb 2021 13:16:53 -0800 (PST)
Received: from quad.timeheart.net ([74.93.13.193]) by smtp.gmail.com with ESMTPSA id y73sm19798332pfb.17.2021.02.15.13.16.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Feb 2021 13:16:53 -0800 (PST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\))
From: Ron Frederick <ronf@timeheart.net>
In-Reply-To: <23259.1613423218@svl-bsdx-06.juniper.net>
Date: Mon, 15 Feb 2021 13:16:48 -0800
Cc: Roni Even <ron.even.tlv@gmail.com>, last-call@ietf.org, gen-art@ietf.org, Curdle Mailing List <curdle@ietf.org>, draft-ietf-curdle-ssh-kex-sha2.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <E7F88714-A7B1-4A6B-AF6A-6D662FA64DCB@timeheart.net>
References: <161338412196.6190.4594634347573267176@ietfa.amsl.com> <13529.1613415279@svl-bsdx-06.juniper.net> <5693EC80-A600-4B00-8D22-9E6F52755328@timeheart.net> <23259.1613423218@svl-bsdx-06.juniper.net>
To: "Mark D. Baushke" <mdb@juniper.net>
X-Mailer: Apple Mail (2.3445.104.17)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/LqCfp1YJjcezgkS0Yz1SAAl6aUc>
Subject: Re: [Gen-art] [Curdle] Genart last call review of draft-ietf-curdle-ssh-kex-sha2-14
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Feb 2021 21:16:57 -0000

Hi Mark,

On Feb 15, 2021, at 1:06 PM, Mark D. Baushke <mdb@juniper.net> wrote:
> Ron Frederick <ronf@timeheart.net> writes:
>> On Feb 15, 2021, at 10:54 AM, Mark D. Baushke <mdb=40juniper.net@dmarc.ietf.org> wrote:
>>> Suggestion to the reviewer of replacement paragraphs before the table in
>>> section 4 "Summary Guidance for Key Exchange Method Names Implementations"
>>> 
>>>    [snip]
>>>   It is suggested that the MUST NOT key exchange method code be
>>>   removed from the any implementations using them.
>> 
>> This should be “from any” instead of “from the any”.
> 
> Hmmm... I seem to have managed to lose what I intended to write. I will
> suggest this as a replacement:
> 
>    It is suggested that the code which implements a "MUST NOT" key
>    exchange method have that implementation code be removed.

There’s some redundancy with “code” here twice, and “have..be” still doesn’t read right. I’d suggest:

   It is suggested that the code which implements a "MUST NOT" key
   exchange method be removed from implementations that contain it.


> Thank you very much for your review of the text I wrote.


No problem!
-- 
Ron Frederick
ronf@timeheart.net

v2.23.0 | Report a Bug | By Email