IETF Logo Mail Archive

Re: [Gen-art] Genart last call review of draft-ietf-core-senml-13

Ari Keränen <ari.keranen@ericsson.com> Fri, 30 March 2018 11:03 UTC

Return-Path: <ari.keranen@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F19E61200A0 for <gen-art@ietfa.amsl.com>; Fri, 30 Mar 2018 04:03:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.321
X-Spam-Level:
X-Spam-Status: No, score=-4.321 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EzYUTLmmf9Uq for <gen-art@ietfa.amsl.com>; Fri, 30 Mar 2018 04:03:41 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CD0AC12D7E8 for <gen-art@ietf.org>; Fri, 30 Mar 2018 04:03:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1522407819; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6OWvuBXE4B1kiMcHLN3fF05rb9EpUNEBjJ/2Itzz6dw=; b=LP+jdQczfaZ2rPdthSwlMJVXDIeOTSTolYVDsI4BORWBr56nIEzk1x9LKud2l8LB JmqH1PUKRVf3OM/VCgYhOGA2xrYnXWMD+F46D7jZyhDmnVVYI3vZxfvVxAa5NoKt rBwqO4GVGygTAmHnXtlj7docZgxKsU7KmbLDJ+PiW8o=;
X-AuditID: c1b4fb2d-e31ff700000073d9-40-5abe198a6666
Received: from ESESSHC022.ericsson.se (Unknown_Domain [153.88.183.84]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 90.38.29657.A891EBA5; Fri, 30 Mar 2018 13:03:39 +0200 (CEST)
Received: from ESESSMB109.ericsson.se ([169.254.9.115]) by ESESSHC022.ericsson.se ([153.88.183.84]) with mapi id 14.03.0382.000; Fri, 30 Mar 2018 13:03:38 +0200
From: Ari Keränen <ari.keranen@ericsson.com>
To: Roni Even <ron.even.tlv@gmail.com>
CC: "gen-art@ietf.org" <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "core@ietf.org" <core@ietf.org>, "draft-ietf-core-senml.all@ietf.org" <draft-ietf-core-senml.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-core-senml-13
Thread-Index: AQHTxlenmfCuQp7tKkSc1i2gojum5aPof0qA
Date: Fri, 30 Mar 2018 11:03:38 +0000
Message-ID: <16FAE862-3F10-4325-AB87-5DF31FBADF09@ericsson.com>
References: <152221578820.29905.10455247933119493699@ietfa.amsl.com>
In-Reply-To: <152221578820.29905.10455247933119493699@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [87.95.226.8]
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <C89E1887D5321946BD3B96174D352935@ericsson.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsUyM2J7iG635L4og98zeSz2vV3PbHHu4RYm i6uvPrNYPNs4n8XibzuzA6vHzll32T2WLPnJFMAUxWWTkpqTWZZapG+XwJUx75FOQRt3xeuJ O9kaGF9wdDFyckgImEh8u3WJpYuRi0NI4AijxIG/V9khnCWMEvM+TWMGqWITsJeYvOYjI4gt IqAm8XrtZzYQm1lgF6PErz/VILawgIPE6q4JLBA1jhLTe89D1RtJNJw/BDSHg4NFQFVi+uZQ kDAv0MjF2xvBSoQEXCTm31wDNpJTwFVi3o+NrCA2o4CYxPdTa5ggVolL3HoynwniaAGJJXvO M0PYohIvH/9jhbDlJWacvQVVrydxY+oUqDOtJR70n4aytSWWLXzNDHGDoMTJmU9YJjCKzUKy YhaS9llI2mchaZ+FpH0BI+sqRtHi1OLi3HQjY73Uoszk4uL8PL281JJNjMCIO7jlt+4OxtWv HQ8xCnAwKvHwhkrsixJiTSwrrsw9xCjBwawkwmt1cm+UEG9KYmVValF+fFFpTmrxIUZpDhYl cV69VXuihATSE0tSs1NTC1KLYLJMHJxSDYzqmwW2PbL8xLT10qRZjnl7JhuemP9k56uFQg0B hYwRd++qOYrF+5vFTZgue7/OwmVn65rSywzbgrpuFHnO18gPYT86M29WttM8tWjDZsYFnRO5 uxRkEg3PppWHaU9I8fSsjTpYdf9vydVzPMkmJSsEa075aTBkhp5lFi498OecvGrQ9YIt/5VY ijMSDbWYi4oTAQs+Tde0AgAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/M6Zn3oCeXZ-HtMLZIyn0yMI5pYI>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-core-senml-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Mar 2018 11:03:49 -0000

Thank you for the review Roni! Good catches. 

Seems we forgot to update the EXI example offsets when regenerated the examples. I made a PR to include these fixes in the next revision: https://github.com/core-wg/senml-spec/pull/102/files


Cheers,
Ari

> On 28 Mar 2018, at 8.43, Roni Even <ron.even.tlv@gmail.com> wrote:
> 
> Reviewer: Roni Even
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-core-senml-??
> Reviewer: Roni Even
> Review Date: 2018-03-27
> IETF LC End Date: 2018-03-30
> IESG Telechat date: 2018-04-19
> 
> Summary:
> The document is ready for publication as a standard track RFC with nits
> 
> Major issues:
> 
> Minor issues:
> 
> Nits/editorial comments:
> 
> 1. in section 5.1.6 "another devices" should be "other devices" or "another
> device" 2. in section 8  "It can simply hard code the output replacing the
> 1-wire device ID starting at byte 0x20 and going to byte 0x2F with it's device
> ID". I think that the offset ix 0x10 to 0x1f
> 
>

v2.23.0 | Report a Bug | By Email