[Gen-art] Genart last call review of draft-ietf-curdle-ssh-ext-info-10
Matthew Miller <linuxwolf+ietf@outer-planes.net> Mon, 24 July 2017 21:02 UTC
Return-Path: <linuxwolf+ietf@outer-planes.net>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 61F18131F20; Mon, 24 Jul 2017 14:02:39 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Matthew Miller <linuxwolf+ietf@outer-planes.net>
To: gen-art@ietf.org
Cc: curdle@ietf.org, ietf@ietf.org, draft-ietf-curdle-ssh-ext-info.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.57.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <150093015937.32021.12465797358778837950@ietfa.amsl.com>
Date: Mon, 24 Jul 2017 14:02:39 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/MA49miT0Qgx2Ai4_Nlc1Frw-YJ4>
Subject: [Gen-art] Genart last call review of draft-ietf-curdle-ssh-ext-info-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Jul 2017 21:02:39 -0000
Reviewer: Matthew Miller Review result: Ready with Issues I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-curdle-ssh-ext-info-10 Reviewer: Matthew Miller Review Date: 2017-07-24 IETF LC End Date: 2017-07-30 IESG Telechat date: N/A Summary: This document is ready with an issue. I found this document very coherent and easy to follow. Major issues: Minor issues: My only issue borders on nit, but sided with nit as I can see it potentially causing confusion for an implementer in the future. Section 2.5. "Interpretation of Extension Names and Values" explicitly states in the second paragraph a condition where the relative order of extension-names in an EXT_INFO message is irrelevant. However, the rest of the section seems to imply to me that relative order is not important; so to explicitly call out a scenario seems to imply that relative order *is* relevant/important, sometimes. If relative order is expected to be important most of the time, I think it helpful to explicitly state that and give a rationale for it. Nits/editorial comments: * RFC 5226 is referenced by this document, but is obsoleted by RFC 8126.
- [Gen-art] Genart last call review of draft-ietf-c… Matthew Miller
- Re: [Gen-art] [Curdle] Genart last call review of… denis bider
- Re: [Gen-art] [Curdle] Genart last call review of… Matthew A. Miller
- Re: [Gen-art] [Curdle] Genart last call review of… denis bider
- Re: [Gen-art] [Curdle] Genart last call review of… denis bider
- Re: [Gen-art] [Curdle] Genart last call review of… Matthew A. Miller
- Re: [Gen-art] Genart last call review of draft-ie… Mirja Kühlewind