Re: [Gen-art] [bfcpbis] Genart last call review of draft-ietf-bfcpbis-rfc4583bis-26

"Charles Eckel (eckelcu)" <eckelcu@cisco.com> Sun, 21 October 2018 18:47 UTC

Return-Path: <eckelcu@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B8DED130E90; Sun, 21 Oct 2018 11:47:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.564
X-Spam-Level:
X-Spam-Status: No, score=-14.564 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.064, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rtTGYfRbKT59; Sun, 21 Oct 2018 11:47:35 -0700 (PDT)
Received: from alln-iport-6.cisco.com (alln-iport-6.cisco.com [173.37.142.93]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 89FBD130E7E; Sun, 21 Oct 2018 11:47:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4686; q=dns/txt; s=iport; t=1540147655; x=1541357255; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ghz5Ay3tpGffgi4XcaRSIPcPLngp+Uaf59Ne5yKe2BM=; b=e/8QgRB+mXTp7Us8Y3lJ+weSbYxl+cqHSMjOWuawee1zrP/4TdXgfCS6 Hj7yT+sjjM8LYaolsfiDsFSI5MxbKIJzXnOVdmWNpbHE7Ndv+aa4Z3vPr MY6ypF+Y1GtY0gnI7Uk8QgjvTUi0rV/D/XbEZUmjZz5iIl//b9HVg3dBS c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0AFAADgyMxb/4sNJK1YChkBAQEBAQEBAQEBAQEHAQEBAQEBgVEEAQEBAQELAYIEZn8oCoNriBiMGYINlxWBegsBARgLhANGAheEcSE0DQ0BAwEBAgEBAm0cDIU6AQEBBAEBIRE6CwwEAgEIEQMBAgMCJgICAiULFQgIAgQBDQWDIQGCAQ+kDYEuig4FgQuKRxeCAIERJx+CTIMbAQGBNoMuMYImAokYlTAJAoZgihAXgVKEc4lpjFiJXgIRFIEmHTiBVXAVGiEqAYJBixmFPm+KWoEfAQE
X-IronPort-AV: E=Sophos;i="5.54,409,1534809600"; d="scan'208";a="188746590"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by alln-iport-6.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2018 18:47:34 +0000
Received: from XCH-ALN-017.cisco.com (xch-aln-017.cisco.com [173.36.7.27]) by alln-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id w9LIlY5t029278 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Sun, 21 Oct 2018 18:47:34 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-ALN-017.cisco.com (173.36.7.27) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 21 Oct 2018 13:47:33 -0500
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1395.000; Sun, 21 Oct 2018 13:47:33 -0500
From: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>
To: Pete Resnick <resnick@episteme.net>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-bfcpbis-rfc4583bis.all@ietf.org" <draft-ietf-bfcpbis-rfc4583bis.all@ietf.org>
Thread-Topic: [bfcpbis] Genart last call review of draft-ietf-bfcpbis-rfc4583bis-26
Thread-Index: AQHUZxGOcx7bA55xwUalLFb+pSWDzKUp7WIA
Date: Sun, 21 Oct 2018 18:47:33 +0000
Message-ID: <A84EF151-9AF4-419C-85F6-ABCA11B42846@cisco.com>
References: <153988781132.22176.3648266052386529933@ietfa.amsl.com>
In-Reply-To: <153988781132.22176.3648266052386529933@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.3.181015
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.61.69.74]
Content-Type: text/plain; charset="utf-8"
Content-ID: <7BCF3CE9EC97364D89B62540A10934FC@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.36.7.27, xch-aln-017.cisco.com
X-Outbound-Node: alln-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/MLpV3t-SGfIURuR0WCCJ_5C7Puo>
Subject: Re: [Gen-art] [bfcpbis] Genart last call review of draft-ietf-bfcpbis-rfc4583bis-26
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Oct 2018 18:47:39 -0000

HI Pete,

Thank you for this careful review. Please see comments inline [cue].

-----Original Message-----
From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Pete Resnick <resnick@episteme.net>
Date: Thursday, October 18, 2018 at 8:36 PM
To: "gen-art@ietf.org" <gen-art@ietf.org>
Cc: "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "draft-ietf-bfcpbis-rfc4583bis.all@ietf.org" <draft-ietf-bfcpbis-rfc4583bis.all@ietf.org>
Subject: [bfcpbis] Genart last call review of draft-ietf-bfcpbis-rfc4583bis-26

    Reviewer: Pete Resnick
    Review result: Ready with Issues
    
    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.
    
    For more information, please see the FAQ at
    
    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
    
    Document: draft-ietf-bfcpbis-rfc4583bis-26
    Reviewer: Pete Resnick
    Review Date: 2018-10-18
    IETF LC End Date: 2018-10-17
    IESG Telechat date: 2018-10-25
    
    Summary: Ready, but one issue with the IANA Considerations section.
    
    I reviewed the diff with 4583. The changes were easily understandable and the
    improvements were obvious. Well done. No major issues at all. I think section
    13 isn't as clear as it ought to be, but not a showstopper. A couple of nits
    noted.
    
    Major issues: None.
    
    Minor issues:
    
    13: I found this section confusing. You could just explain this interactively
    with IANA, as I suspect they will find it confusing too, but I'd suggest:
    
    - Where you need to have IANA do something new, identify that to IANA as "IANA
    is requested to register...", replacing "This document defines" in 13.6.
    
    - For the remainder, identify those with "IANA has registered...", replacing
    "This document defined" in 13.2 through 13.5. You can put a parenthetical note
    next to each one that says, "No new IANA action requested here"
    
    This all gets cleaned up by the RFC Editor anyway, but the whole idea of the
    IANA Considerations is to make it clear what IANA needs to do, not format the
    section for what it should look like when published.

[cue] Good catch, and spot on. The IANA review raised these exact questions, to which we provided the clarifications you suggested.
    
    Finally, I don't see a need for the "contact iesg@ietf.org" bit. This is going
    to be a standards track document, and that is always the case for standards
    track documents.

[cue] Will check with RFC editor about removing this.
    
    Nits/editorial comments:
    
    5.1:
    
    - Table 1 contains "c-s", but it has not yet been explained. I would move it
    below the subsequent paragraph.	

[cue] Good idea.
    
    - In the paragraph that begins, "Endpoints compliant with [RFC4583]", the comma
    in the second sentence belongs after "present", not "client".

[cue] Yes, thanks.
    
    5.2:
    
    - In the section title, s/Attributes/Attribute

[cue] Yes, thanks.

Cheers,
Charles
    
    
    _______________________________________________
    bfcpbis mailing list
    bfcpbis@ietf.org
    https://www.ietf.org/mailman/listinfo/bfcpbis