[Gen-art] Gen-ART Last Call review of draft-ietf-bess-mvpn-bidir-ingress-replication-02

Brian E Carpenter <brian.e.carpenter@gmail.com> Wed, 30 September 2015 02:50 UTC

Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7E9261B5A3A; Tue, 29 Sep 2015 19:50:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.006
X-Spam-Level:
X-Spam-Status: No, score=-1.006 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FS_REPLICA=0.994, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7qB7VujbaiN3; Tue, 29 Sep 2015 19:50:17 -0700 (PDT)
Received: from mail-pa0-x233.google.com (mail-pa0-x233.google.com [IPv6:2607:f8b0:400e:c03::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3123E1B5A39; Tue, 29 Sep 2015 19:50:14 -0700 (PDT)
Received: by padhy16 with SMTP id hy16so24456749pad.1; Tue, 29 Sep 2015 19:50:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:organization:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=O8N2HS1Xwt4qMFPAz9nGVu3QjLLHb9zvG11LzR7WM4M=; b=KPKhxhN7YEULNN4xlQYishLmyOvEPq3dsyrsFVhtwPArL6Oz2u1rk8FdQPLB4CMReF RP7VxcleANkORKIUVnzQ0yjArbdWTdCKlVaXElSOJNrIE9d044hJGw/GDOqo34PKfw/C F7776pZGSRyxap6Cd1NZSbgwmrg/SCifcqx0NCflWEassbautNWXizUdQCJcy8Gd0mnv NtNomjggSI8W5ERYROSg0QAaOjF1g8Wb8BWRX429fgzqvP/G5J9vh2NnoQak+pfrwsRF 0XlAgpYbzZk9BN2lGYZTFDUeeiTZC06LsB8ntjxo3kg781ft9iZeOomAZ8QE7aoneb4g R6VA==
X-Received: by 10.68.100.226 with SMTP id fb2mr1789885pbb.92.1443581413792; Tue, 29 Sep 2015 19:50:13 -0700 (PDT)
Received: from ?IPv6:2406:e007:6e4b:1:28cc:dc4c:9703:6781? ([2406:e007:6e4b:1:28cc:dc4c:9703:6781]) by smtp.gmail.com with ESMTPSA id qy5sm28188870pbb.16.2015.09.29.19.50.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2015 19:50:12 -0700 (PDT)
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
To: draft-ietf-bess-mvpn-bidir-ingress-replication.all@ietf.org, General Area Review Team <gen-art@ietf.org>
Organization: University of Auckland
Message-ID: <560B4DE6.80704@gmail.com>
Date: Wed, 30 Sep 2015 15:50:14 +1300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/MRUyd4fzTYmMxxwb_qWAm4ho_d4>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-bess-mvpn-bidir-ingress-replication-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Sep 2015 02:50:18 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-bess-mvpn-bidir-ingress-replication-02.txt
Reviewer: Brian Carpenter
Review Date: 2015-09-30
IETF LC End Date: 2015-10-08
IESG Telechat date:

Summary: Ready with issues
--------

Comments:
---------

According to the writeup:
"Good consensus among a solid although small set of contributors
(two vendors on the draft and a third vendor supporting the proposal)."
I wonder if that really means "Nobody else cares." Going back in the
bess and l3vpn mail archives, I only found one significant technical
discussion (on the original individual draft version).

The AD Review asks for a number of changes. To be frank, it's a bit annoying
to be asked to do a review of a draft that will change during the Last Call.

All that said, I didn't identify any protocol issues and it seems like
a reasonable solution.

Major Issues:
-------------

>  This document
>  describes how the MP2MP tunnel can be simulated with a mesh of P2MP
>  tunnels, each of which is instantiated by Ingress Replication
>  [I-D.ietf-bess-ir]

You can't understand the current document without consulting ietf-bess-ir.
For example, there are numerous instances of the phrase "IR P-tunnel" which
is defined by ietf-bess-ir. IMHO, it's therefore a normative reference.

> The label may be shared
> with other P-tunnels, subject to the anti-ambiguity rules for
> extranet [I-D.ietf-bess-mvpn-extranet].

This or similar words appear several times. An implementer cannot implement
the current document without consulting ietf-bess-mvpn-extranet. IMHO, it's
therefore a normative reference.

Minor Issues:
-------------

> These specifications update RFC 6514.

Is that actually true? Or is it just an *extension* of RFC 6514, which
doesn't merit a formal "Updates: 6514"? [In other words, will anything bad
happen if an implementation of RFC 6514 doesn't add this?]

> 1.  Introduction
>
>   Section 11.2 of RFC 6513, "Partitioned Sets of PEs", describes two
>   methods of carrying bidirectional C-flow traffic over a provider core
>   without using the core as RPL or requiring Designated Forwarder
>   election.

Which RPL is that? Propbably not RFC6550. Whatever it means, it needs
to be expanded when first used.