Re: [Gen-art] [babel] Genart last call review of draft-ietf-babel-rfc6126bis-10

Juliusz Chroboczek <jch@irif.fr> Fri, 28 June 2019 00:39 UTC

Return-Path: <jch@irif.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ACE241200F7; Thu, 27 Jun 2019 17:39:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lp9gNuBEVFEu; Thu, 27 Jun 2019 17:39:00 -0700 (PDT)
Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2879D1200B2; Thu, 27 Jun 2019 17:38:59 -0700 (PDT)
Received: from potemkin.univ-paris7.fr (potemkin.univ-paris7.fr [IPv6:2001:660:3301:8000::1:1]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/82085) with ESMTP id x5S0ctVJ029709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 28 Jun 2019 02:38:55 +0200
Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by potemkin.univ-paris7.fr (8.14.4/8.14.4/relay2/82085) with ESMTP id x5S0ct6O028979; Fri, 28 Jun 2019 02:38:55 +0200
Received: from mailhub.math.univ-paris-diderot.fr (localhost [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id A94E648EBA; Fri, 28 Jun 2019 02:38:57 +0200 (CEST)
X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr
Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id twm-dKLVtOEJ; Fri, 28 Jun 2019 02:38:56 +0200 (CEST)
Received: from pirx.irif.fr (unknown [78.194.40.74]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id 6C80048EB8; Fri, 28 Jun 2019 02:38:56 +0200 (CEST)
Date: Fri, 28 Jun 2019 02:38:56 +0200
Message-ID: <87woh6a6hr.wl-jch@irif.fr>
From: Juliusz Chroboczek <jch@irif.fr>
To: Russ Housley <housley@vigilsec.com>
Cc: gen-art@ietf.org, draft-ietf-babel-rfc6126bis.all@ietf.org, ietf@ietf.org, babel@ietf.org
In-Reply-To: <156122420684.16418.15464371573444699739@ietfa.amsl.com>
References: <156122420684.16418.15464371573444699739@ietfa.amsl.com>
User-Agent: Wanderlust/2.15.9
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]); Fri, 28 Jun 2019 02:38:55 +0200 (CEST)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (potemkin.univ-paris7.fr [194.254.61.141]); Fri, 28 Jun 2019 02:38:55 +0200 (CEST)
X-Miltered: at korolev with ID 5D15619F.002 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-Miltered: at potemkin with ID 5D15619F.002 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Enveloppe: 5D15619F.002 from potemkin.univ-paris7.fr/potemkin.univ-paris7.fr/null/potemkin.univ-paris7.fr/<jch@irif.fr>
X-j-chkmail-Enveloppe: 5D15619F.002 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/<jch@irif.fr>
X-j-chkmail-Score: MSGID : 5D15619F.002 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Score: MSGID : 5D15619F.002 on potemkin.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Status: Ham
X-j-chkmail-Status: Ham
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/MwtGwHVEEJZqpwhF47Ag24U_3eo>
Subject: Re: [Gen-art] [babel] Genart last call review of draft-ietf-babel-rfc6126bis-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jun 2019 00:39:03 -0000

Dear Russ,

Thank you very much for your review.  I agree with all of your comments
save one, I'll publish a new revision taking your comments into account as
soon as possible.

>    ...  A node SHOULD NOT send triggered updates
>    for other reasons, such as when there is a minor fluctuation in a
>    route's metric, when the selected next hop changes, or to propagate a
>    new sequence number (except to satisfy a request, as specified in
>    Section 3.8).

> This seem backwards to me.  Perhaps:

>    ...  The node MUST send triggered updates to satisfy a request, as
>    specified in Section 3.8; however, a node SHOULD NOT send
>    triggered updates for other reasons, including a minor fluctuation
>    in a metric for a route, the selected next hop changes, or to
>    propagate a new sequence number.

I disagree.  The requirement to send triggered updates is already present
in 3.8.1.1, we should not repeat it.  This section is concerned with
avoiding excessive noise.

> Section 4 says:

>    A Babel packet is sent as the body of a UDP datagram, with network-
>    layer hop count set to 1, destined to a well-known multicast address
>    or to a unicast address, over IPv4 or IPv6; in the case of IPv6,
>    these addresses are link-local.
   
> It seems to me that this should be reworded as MUST statements.

Agreed.

> Section 4.1.2 says:

>    A router-id is an arbitrary 8-octet value.  A router-id MUST NOT
>    consist of either all zeroes or all ones.
   
> I do not think you are referring to octets with a value of one.  I
> think you mean that the router-id cannot be 0x0000000000000000 or
> 0xffffffffffffffff.  Please reword.

Agreed.

Thanks again,

-- Juliusz