[Gen-art] Gen-ART telechat review of draft-ietf-pwe3-iccp-stp-04
Brian E Carpenter <brian.e.carpenter@gmail.com> Fri, 25 September 2015 00:56 UTC
Return-Path: <brian.e.carpenter@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BD141B2F55; Thu, 24 Sep 2015 17:56:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9hKlvU57e6R2; Thu, 24 Sep 2015 17:56:24 -0700 (PDT)
Received: from mail-pa0-x22f.google.com (mail-pa0-x22f.google.com [IPv6:2607:f8b0:400e:c03::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D1331B2F54; Thu, 24 Sep 2015 17:56:24 -0700 (PDT)
Received: by pacfv12 with SMTP id fv12so89761178pac.2; Thu, 24 Sep 2015 17:56:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:organization:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=+pwlgHJBCmE4+UiAFva3ZZ1qcNWVGXTRUw1ZUKnK/KA=; b=uK1uCjGuId9h4yWpfg331Lo0tAmyKaafbziRAkVW3OVnNiMWYGqTyi4MbJ5S1XJyIY 51WIjA6ghnMwGfUw1yaAzi+4rPkXlunQf9aqTE8SjLSuwKiZGlIUC9C98A+BWjm6eGCX MkzYYpMsHoPstFaH1VDmzSUj7H486ltK133rjMtRluBW9GTdYq1hoBm7eStaZLkcoeC8 S5vwzqBdvhn8alFWPKFjRD8paBfC67Lbiwy0ZsuFu5salasZ+D5a3ibRFGOCjHeg0+q9 fmX7YxSYKY/TG5sZC7FKPpfqA8y7mGgX9T1DEJqF0bYp0gkmJELAdUCIRbqlrDcKDXTp aiRQ==
X-Received: by 10.66.236.10 with SMTP id uq10mr3289623pac.55.1443142584170; Thu, 24 Sep 2015 17:56:24 -0700 (PDT)
Received: from [192.168.178.25] (142.23.255.123.dynamic.snap.net.nz. [123.255.23.142]) by smtp.gmail.com with ESMTPSA id rw8sm679708pac.11.2015.09.24.17.56.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Sep 2015 17:56:23 -0700 (PDT)
From: Brian E Carpenter <brian.e.carpenter@gmail.com>
To: draft-ietf-pwe3-iccp-stp.all@ietf.org, General Area Review Team <gen-art@ietf.org>
Organization: University of Auckland
Message-ID: <56049BBE.5090300@gmail.com>
Date: Fri, 25 Sep 2015 12:56:30 +1200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/NBiGD94BfcvkP81JDLU0zx6XMNI>
Subject: [Gen-art] Gen-ART telechat review of draft-ietf-pwe3-iccp-stp-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Sep 2015 00:56:26 -0000
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please wait for direction from your document shepherd or AD before posting a new version of the draft. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Document: draft-ietf-pwe3-iccp-stp-04.txt Reviewer: Brian Carpenter Review Date: 2015-09-25 IETF LC End Date: 2015-09-23 IESG Telechat date: 2015-10-01 Summary: Ready with issues -------- Comments: --------- The author responded helpfully to the following Last Call comments but a new version is needed to fix them. It's impossible for a reviewer who is not expert in the details of 802.1Q to check many details in this draft, so I didn't. Major Issues: ------------- The draft does not properly explain the theory of operation. The messages are defined but it is not explained when a spanning tree is formed. Section 4 does not help with this. I think it should be explained at the end of the Use Case section. The main normative reference appears to be IEEE 802.1Q-2005. The current standard is IEEE 802.1Q-2014, which appears to be very different. I think this should be discussed in the text to avoid confusion. > 3.6. STP Synchronization Data TLV ... > When the total size of the TLVs to be transmitted > exceeds the maximal size of a fragment, these TLVs SHOULD be divided > into multiple sets, delimited by multiple pairs of STP > Synchronization Data TLVs, and filled into multiple fragments. There needs to be discussion of what happens if a fragment is lost. Minor Issues: ------------- > 3.2.1. STP Disconnect Cause sub-TLV ... > - Disconnect Cause String > > Variable length string specifying the reason for the disconnect, > to be used for operational purposes. Should it be specified whether this is ASCII, UTF-8,...? Nits: ----- Please expand Spanning Tree Protocol in the main title. Abbreviation PE used but not defined. Also, "provider edge" means an edge, which is an abstract concept, not a device. If the draft is discussing specific devices, it should say "PE device" or "PE router" or "PE switch". Abbreviation AC used but not defined. Abbreviation CE used but not defined.
- [Gen-art] Gen-ART telechat review of draft-ietf-p… Brian E Carpenter
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Andrew G. Malis
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Brian E Carpenter
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Andrew G. Malis
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Jari Arkko
- Re: [Gen-art] Gen-ART telechat review of draft-ie… Mingui Zhang