[Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

Brian Carpenter via Datatracker <noreply@ietf.org> Sun, 12 July 2020 22:40 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 3845B3A0913; Sun, 12 Jul 2020 15:40:23 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Brian Carpenter via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: draft-ietf-mmusic-msrp-usage-data-channel.all@ietf.org, mmusic@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.7.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159459362316.14150.6160122631877971567@ietfa.amsl.com>
Reply-To: Brian Carpenter <brian.e.carpenter@gmail.com>
Date: Sun, 12 Jul 2020 15:40:23 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/NRsOhH878PLxXYL0QUFZYjI55sU>
Subject: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Jul 2020 22:40:23 -0000

Reviewer: Brian Carpenter
Review result: Ready with Nits

Gen-ART Last Call review of draft-ietf-mmusic-msrp-usage-data-channel-21

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-mmusic-msrp-usage-data-channel-21
Reviewer: Brian Carpenter
Review Date: 2020-07-13
IETF LC End Date: 2020-07-21
IESG Telechat date:  

Summary: Ready with nits
--------

Nits:
-----

>> 4.1.  MSRP URI
...
>>     transport  /= "dc"

I see that RFC7977 takes a slightly different approach to updating the ABNF:

>>     transport  =  "tcp" / "ws" / 1*ALPHANUM

The advantage of listing out

  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM

would be that the reader sees the full list.

>>                  ; Add "dc" to existing transports per [RFC4975]

I suggest

                 ; Add "dc" to existing transports per Section 9 of [RFC4975]

>>4.6.  Session Closing

>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>   present in the SDP answer if no corresponding attributes are present
>>   in the received SDP offer.

Should that be MUST?

>> B2BUA

Define the acronym please.

>> 9.2.  Subprotocol Identifier MSRP
>>
>>   A reference to this document is added to the subprotocol identifier
>>   "msrp" in the "WebSocket Subprotocol Name Registry"

s/this document/RFCXXXX/

>> 11.  CHANGE LOG

Mark this section for deletion by the RFC Editor