Re: [Gen-art] Gen-ART review of draft-ietf-pim-ecmp-03.txt

Liming Wei <lwei@cisco.com> Wed, 20 June 2012 01:05 UTC

Return-Path: <lwei@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8EC0D11E8121 for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 18:05:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.599
X-Spam-Level:
X-Spam-Status: No, score=-10.599 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, RCVD_IN_DNSWL_HI=-8]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bDzxG6FXM9RC for <gen-art@ietfa.amsl.com>; Tue, 19 Jun 2012 18:05:56 -0700 (PDT)
Received: from mtv-iport-1.cisco.com (mtv-iport-1.cisco.com [173.36.130.12]) by ietfa.amsl.com (Postfix) with ESMTP id F2E5811E8117 for <gen-art@ietf.org>; Tue, 19 Jun 2012 18:05:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=lwei@cisco.com; l=2525; q=dns/txt; s=iport; t=1340154355; x=1341363955; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; bh=iB3chPjbItwN/texCcSs/hEQCRP0sJOEnKYgerw+kMI=; b=AonhXfsAj8yC1+Ed2z/SqoCGaV/58U1UtE0LMnm9n8V1+B4yKr/afGHd lBThiga+Fh9Pg0kZSnD6tweLy8VBT7jcR5aPGSk2Cd3xJa+Si3+mgRKom crArrq0mHamGhyc7gGTKGqRdwQTdtUkvODtekHEeESonCDL4rk7M9z00E M=;
X-IronPort-AV: E=Sophos;i="4.77,439,1336348800"; d="scan'208";a="46442159"
Received: from mtv-core-2.cisco.com ([171.68.58.7]) by mtv-iport-1.cisco.com with ESMTP; 20 Jun 2012 01:05:55 +0000
Received: from lwei-mac.local ([10.155.34.217]) by mtv-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id q5K15tLU019458; Wed, 20 Jun 2012 01:05:55 GMT
Message-ID: <4FE12294.4000008@cisco.com>
Date: Tue, 19 Jun 2012 18:08:36 -0700
From: Liming Wei <lwei@cisco.com>
Organization: cisco systems Inc.
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: "Miguel A. Garcia" <Miguel.A.Garcia@ericsson.com>
References: <4FD59EA1.9030008@ericsson.com>
In-Reply-To: <4FD59EA1.9030008@ericsson.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Mailman-Approved-At: Tue, 19 Jun 2012 18:14:15 -0700
Cc: "draft-ietf-pim-ecmp.authors@tools.ietf.org" <draft-ietf-pim-ecmp.authors@tools.ietf.org>, Adrian Farrel <adrian@olddog.co.uk>, "mmcbride7@gmail.com" <mmcbride7@gmail.com>, General Area Review Team <gen-art@ietf.org>, "pim-chairs@tools.ietf.org" <pim-chairs@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-pim-ecmp-03.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2012 01:05:56 -0000

Hi Miguel,

Response to your comments inline..

On 6/11/12 12:30 AM, Miguel A. Garcia wrote:
> I have been selected as the General Area Review Team (Gen-ART)
> reviewer for this draft. For background on Gen-ART, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
>
> Please resolve these comments along with any other comments you may receive.
>
> Document: draft-ietf-pim-ecmp-03.txt
> Reviewer: Miguel Garcia<Miguel.A.Garcia@ericsson.com>
> Review Date: 2012-06-11
> IETF LC End Date: 2012-06-12
> IESG Telechat date: 2012-06-21
>
> Summary: The document is ready for publication as a standards track RFC.
>
> Major issues: none
>
> Minor issues: none
>
> Nits/editorial comments:
>
> - The Abstract should not include references. Just delete "[RFC4601]".

Will remove "[RFC4601]".

>
> - Perhaps this is a matter of personal taste... but Section 3.5.2 is
> devoted to describe the format of the PIM ECMP Redirect message. I think
> this is a section where you should describe the format, but you shouldn't
> write normative statements as for what to do with those fields. For
> example, I am referring to statements like:
>
>         Address of desired upstream
>         neighbor where the downstream receiver SHOULD redirect PIM
>         Joins
>
>         the receiving
>         router of this message MUST use the "Interface ID", instead of
>         "Neighbor Address", to identify the new RPF neighbor
>
>         an ECMP
>         Redirect message MUST be discarded if the "Interface ID" field...
>
> I think all these sentences including a normative MUST, SHOULD, etc.
> should be written in Sections 3.1. or 3.2 (Procedures). This means that
> the format (current section 3.5) should be moved to a place prior to 3.1
> and 3.2, because the procedures needs to explain what to do with all
> these fields.

Good point. Our original consideration was that when a protocol
implementer refers to the packet format and the fields,
it is more convenient for them to see that type of explanation
in the same place, as opposed to scattered in other parts of the spec.  
On the
other hand, doing what you suggested makes the spec look "cleaner", as the
format does not explain the protocol behavior, and the explanations occur in
places they are supposed to be explained.

So, we will move the explanation for the "Neighbor Address", and the 
"Interface
ID" to the end of section 3.1.

  Thanks,

-Liming Wei


/Miguel