[Gen-art] Genart last call review of draft-ietf-pce-pcep-extension-native-ip-32

Mallory Knodel via Datatracker <noreply@ietf.org> Mon, 05 August 2024 14:19 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from [10.244.2.66] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id D54CAC151071; Mon, 5 Aug 2024 07:19:17 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Mallory Knodel via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.21.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <172286755749.656716.16040347174924215132@dt-datatracker-6dd76c4557-2mkrj>
Date: Mon, 05 Aug 2024 07:19:17 -0700
Message-ID-Hash: D7VRJXD4W6GXG2WWG4GKXJWJJBMPUL5N
X-Message-ID-Hash: D7VRJXD4W6GXG2WWG4GKXJWJJBMPUL5N
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-gen-art.ietf.org-0; header-match-gen-art.ietf.org-1; header-match-gen-art.ietf.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: draft-ietf-pce-pcep-extension-native-ip.all@ietf.org, last-call@ietf.org, pce@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Mallory Knodel <mknodel@cdt.org>
Subject: [Gen-art] Genart last call review of draft-ietf-pce-pcep-extension-native-ip-32
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/OL_XqN1dmJRBYFfP3cD213QDOmw>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Owner: <mailto:gen-art-owner@ietf.org>
List-Post: <mailto:gen-art@ietf.org>
List-Subscribe: <mailto:gen-art-join@ietf.org>
List-Unsubscribe: <mailto:gen-art-leave@ietf.org>

Reviewer: Mallory Knodel
Review result: Ready with Issues

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-pce-pcep-extension-native-ip-32
Reviewer: Mallory Knodel
Review Date: 2024-08-05
IETF LC End Date: 2024-08-12
IESG Telechat date: Not scheduled for a telechat

Summary: I've reviewed this document and I want to focus my feedback on the
security considerations section, though there are several nits within the
document that I imagine will be picked up during the editorial process.

Major issues: None.

Minor issues: Security considerations are helpful because they provide pointers
to other RFCs that contain relevant security considerations in related drafts.
However, a reader does not have a useful overview of what those security issues
are. I would encourage the authors to provide a short summary of the security
considerations for this specification as well as linking to the primary source
that goes into more depth about those considerations and how to mitigate them.
That will give the reader more of an idea about which additional documents they
should read, instead of asking them to read all of them and decide for
themselves. I believe the experts who have authored this specification could
provide more guidance to implementers about what are the security issues with
this specification as well as guidance on where to look for deeper explanations
(eg the already cited RFCs).

Nits/editorial comments: The document requires significant and thorough
copyediting, which would be nice to do before passing along to the RFC Editor.
Automated spelling and grammar tools could catch many of these.