[Gen-art] Genart last call review of draft-ietf-cellar-ffv1-16
Joel Halpern via Datatracker <noreply@ietf.org> Tue, 14 July 2020 04:17 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 59CDB3A0D58; Mon, 13 Jul 2020 21:17:53 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joel Halpern via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
Cc: cellar@ietf.org, last-call@ietf.org, draft-ietf-cellar-ffv1.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.8.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <159470027331.24170.16229303627582288772@ietfa.amsl.com>
Reply-To: Joel Halpern <jmh@joelhalpern.com>
Date: Mon, 13 Jul 2020 21:17:53 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Op92jtMDEPPMqRrM4rZlilo_uLg>
Subject: [Gen-art] Genart last call review of draft-ietf-cellar-ffv1-16
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2020 04:17:54 -0000
Reviewer: Joel Halpern Review result: Ready I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-cellar-ffv1-16 Reviewer: Joel Halpern Review Date: 2020-07-13 IETF LC End Date: 2020-07-16 IESG Telechat date: Not scheduled for a telechat Summary: This document appears to be ready for publication as an Informational RFC. *I would have raised question about the intended status, but it appears that this is an established IETF convention and I see no reason to argue.) Major issues: Minor issues: Section 3.4 (Context) introduces the notation Q_{#}[ subscript }. As that is the first reference to Q_{#}, it is rather confusing to the reader. I grant that the term is defined in the next section (3.5). Couldn't they be reversed? Section 3.8.1.1 refers to C(i), C_{i}, and C_i. Are these all the same thing. Section 3.8.1.2 refers to get-rac (which is treated as a function in the pseudo-code) as being the process described in section 3.8.1.1. The text in 3.8.1.1 does not call out any of its computed values as an explicit result or return. While I would guess that the intention is to use the byte stream (B()), the text does not actually say that. If that is the intention, could the last line of 3.8.1.1 be "get_rac() returns sequential bytes from the Byte Stream (B()) as computed by the computation described in section 3.8.1.1"? Nits/editorial comments:
- [Gen-art] Genart last call review of draft-ietf-c… Joel Halpern via Datatracker
- Re: [Gen-art] Genart last call review of draft-ie… Spencer Dawkins at IETF
- Re: [Gen-art] Genart last call review of draft-ie… Alissa Cooper