IETF Logo Mail Archive

Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd

"Ralph Droms (rdroms)" <rdroms@cisco.com> Mon, 26 October 2015 19:13 UTC

Return-Path: <rdroms@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38AFC1B5122; Mon, 26 Oct 2015 12:13:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.511
X-Spam-Level:
X-Spam-Status: No, score=-14.511 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KQS9y82R4MJB; Mon, 26 Oct 2015 12:13:32 -0700 (PDT)
Received: from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5A4021B512A; Mon, 26 Oct 2015 12:13:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2404; q=dns/txt; s=iport; t=1445886797; x=1447096397; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=wIw3EtqL2zeYkINlOo24EhArL7q53EAEnEybAKo6kXU=; b=ALXk5n5DllILyHyjiIYD4jNPGsHFth2cOGRLniqrysXPD1oR/v0K3UW3 LxibHDytnT7yEpW8HvTfNfJQPvSoOe4ZnSFJ5He0bQjzSB6F6pgdvabT+ 8IK1LYuYh5AOR0Ec1/NaIkpZy8RMFT87ODTdKSCeytP3wSreK2xD38Run c=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ACAgBpei5W/4kNJK1egzaBQwa+PwENgVqGHQKBNzgUAQEBAQEBAYEKhDIBAQEDATo/BQsCAQgRBAEBAR4JByERFAkIAgQOBYgbAwoIwRsNhEUBAQEBAQEBAQEBAQEBAQEBAQEBAQEYhneCEIJuglCBWhEBHjMHBoMUgRQFljYBimlDgXWBWRWHToskg1+DbwEfAQFCghEdgVVyhVg6gQYBAQE
X-IronPort-AV: E=Sophos;i="5.20,201,1444694400"; d="scan'208";a="41079813"
Received: from alln-core-4.cisco.com ([173.36.13.137]) by rcdn-iport-4.cisco.com with ESMTP; 26 Oct 2015 19:13:16 +0000
Received: from XCH-RCD-019.cisco.com (xch-rcd-019.cisco.com [173.37.102.29]) by alln-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id t9QJDGcs031786 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 26 Oct 2015 19:13:16 GMT
Received: from xch-aln-016.cisco.com (173.36.7.26) by XCH-RCD-019.cisco.com (173.37.102.29) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Mon, 26 Oct 2015 14:12:52 -0500
Received: from xch-aln-016.cisco.com ([173.36.7.26]) by XCH-ALN-016.cisco.com ([173.36.7.26]) with mapi id 15.00.1104.000; Mon, 26 Oct 2015 14:12:53 -0500
From: "Ralph Droms (rdroms)" <rdroms@cisco.com>
To: "Shah, Himanshu" <hshah@ciena.com>
Thread-Topic: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
Thread-Index: AQHRBrtB0K0DtUmA2kyW/x0Nq3/Sjp57F8ewgAAfkhCAAAiqAIADJqGA//+sllCAAGWRgIAAAG2AgAAR3YA=
Date: Mon, 26 Oct 2015 19:12:53 +0000
Message-ID: <8D144BAF-E93F-4BCE-A940-E1AB48947C12@cisco.com>
References: <095AB7C0-C1B7-4963-852C-A5A613AD261A@cisco.com> <40746B2300A8FC4AB04EE722A593182B9ACC4AF3@ONWVEXCHMB04.ciena.com> <D98030BB-32EB-4859-A71B-8D54BDBF031C@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C37860E@ONWVEXCHMB04.ciena.com> <2F4FBE17-D7D8-4B96-AB1C-8ACFE48B2630@cisco.com> <40746B2300A8FC4AB04EE722A593182B9C378941@ONWVEXCHMB04.ciena.com> <CAA=duU0Jeva2=1CdKxW3D3wHonFnWv7JpwWkyD6ORePzQfmSYg@mail.gmail.com> <40746B2300A8FC4AB04EE722A593182B9C3789B3@ONWVEXCHMB04.ciena.com>
In-Reply-To: <40746B2300A8FC4AB04EE722A593182B9C3789B3@ONWVEXCHMB04.ciena.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.131.118.41]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5C6EDF75998A9749944F7C81801D8144@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/PD4VF8TPmx2kBs7IY9p6vY99Xms>
Cc: General Area Review Team <gen-art@ietf.org>, "draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org" <draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org>, "Andrew G. Malis" <agmalis@gmail.com>, The IESG <iesg@ietf.org>
Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2015 19:13:34 -0000

Himanshu - I've been tied up in meetings most of the day today and am about to go into more meetings that will last until the end of the day.

I reviewed your revised draft briefly and it mostly looks OK.  I have one substantive comment, which is about an issue I didn't notice until now:

How is the Mac Withdraw sub-TLV registry from which the "Sequence Number" code point is taken differentiated from the LDP Parameters sub-TLV registry from which the "MAC List" and "MAC Flush Parameter" code points are taken?  In other words, how does the receciver know to interpret the code point on the Sequence Number TLV as a code point in the Mac Withdraw sub-TLV registry while the code points on the MAC List TLV and the MAC Flush Paramter TLV are interpreted as code points in the LDP Paramteres sub-TLV?  Shouldn't all the code points on the TLVs in this message come from a single registry?

I also have an editorial comment from my earlier review: the ifrst paragraph of section 3 is mostly redundant with section 4.1 and that text in section 3 should be merged into the text in section 4.1

- Ralph

> On Oct 26, 2015, at 2:09 PM 10/26/15, Shah, Himanshu <hshah@ciena.com> wrote:
> 
> Thanks Andy.
> He did re-send the email without MIME and I was able to read and reply.
>  
> Thanks,
> Himanshu
>  
> From: Andrew G. Malis [mailto:agmalis@gmail.com] 
> Sent: Monday, October 26, 2015 2:08 PM
> To: Shah, Himanshu
> Cc: Ralph Droms (rdroms); A. Jean Mahoney; General Area Review Team; draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG
> Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd
>  
> Himanshu,
>  
> Ralph said:
>  
> Himanshu - I've received your revised draft.  I've been stuck in a variety of meetings Monday and haven't had time to review it.  I should be able to look at it before the end of the day.
> 
> - Ralph
>  
> On Mon, Oct 26, 2015 at 1:04 PM, Shah, Himanshu <hshah@ciena.com> wrote:
> Can you send the email without MIME signature?
>  
> Thanks,
> Himanshu
>  
> From: Ralph Droms (rdroms) [mailto:rdroms@cisco.com] 
> Sent: Monday, October 26, 2015 1:02 PM
> To: Shah, Himanshu
> Cc: A. Jean Mahoney; General Area Review Team; draft-ietf-pals-mpls-tp-mac-wd.all@ietf.org; The IESG
> Subject: Re: [Gen-art] Review: draft-ietf-pals-mpls-tp-mac-wd

v2.23.0 | Report a Bug | By Email