[Gen-art] review of draft-kivinen-ipsecme-oob-pubkey-11.txt

Francis Dupont <Francis.Dupont@fdupont.fr> Mon, 14 September 2015 13:16 UTC

Return-Path: <Francis.Dupont@fdupont.fr>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A4ABC1B37B0 for <gen-art@ietfa.amsl.com>; Mon, 14 Sep 2015 06:16:40 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.337
X-Spam-Level:
X-Spam-Status: No, score=0.337 tagged_above=-999 required=5 tests=[BAYES_20=-0.001, HELO_EQ_FR=0.35, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aDrClMiHx5cT for <gen-art@ietfa.amsl.com>; Mon, 14 Sep 2015 06:16:39 -0700 (PDT)
Received: from givry.fdupont.fr (givry.fdupont.fr [IPv6:2001:41d0:1:6d55:211:5bff:fe98:d51e]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 73FB91B35C5 for <gen-art@ietf.org>; Mon, 14 Sep 2015 06:16:39 -0700 (PDT)
Received: from givry.fdupont.fr (localhost [IPv6:::1]) by givry.fdupont.fr (8.14.7/8.14.7) with ESMTP id t8EDFIDA027591; Mon, 14 Sep 2015 15:15:18 +0200 (CEST) (envelope-from dupont@givry.fdupont.fr)
Message-Id: <201509141315.t8EDFIDA027591@givry.fdupont.fr>
From: Francis Dupont <Francis.Dupont@fdupont.fr>
To: gen-art@ietf.org
Date: Mon, 14 Sep 2015 15:15:18 +0200
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/PJvlDbMtSfDLssL6uAaogCBXzm0>
Cc: draft-kivinen-ipsecme-oob-pubkey.all@tools.ietf.org
Subject: [Gen-art] review of draft-kivinen-ipsecme-oob-pubkey-11.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Sep 2015 13:16:40 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-kivinen-ipsecme-oob-pubkey-11.txt
Reviewer: Francis Dupont
Review Date: 20150911
IETF LC End Date: 20150923
IESG Telechat date: unknown

Summary: Ready

Major issues: None

Minor issues: None

Nits/editorial comments:
 - ToC page 2 and 6 page 6: Acknowledgements -> Acknowledgments

 - 1 page 3: IMHO the choice of the SubjectPublicKeyInfo format is
  the right one.

 - 3 page 4: is a a very -> is a very

 - A.1 page 8 and A.2 page 10: i.e. -> i.e.,

 - A pages 7 - 10: BTW I used your 2 examples to add new unit tests in
  an application crypto library so I can confirm the 2 SPKIs are correct.

Regards

Francis.Dupont@fdupont.fr