Re: [Gen-art] Genart last call review of draft-ietf-httpapi-link-template-02

Mark Nottingham <mnot@mnot.net> Thu, 18 May 2023 13:04 UTC

Return-Path: <mnot@mnot.net>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C0C1CC151067; Thu, 18 May 2023 06:04:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=mnot.net header.b="K0Si6brw"; dkim=pass (2048-bit key) header.d=messagingengine.com header.b="YuZ+SAaa"
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 409ktJIuKhlM; Thu, 18 May 2023 06:03:55 -0700 (PDT)
Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA4D0C151065; Thu, 18 May 2023 06:03:55 -0700 (PDT)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D10613200A52; Thu, 18 May 2023 09:03:54 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 18 May 2023 09:03:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mnot.net; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1684415034; x=1684501434; bh=+EuBxStaKnIPdoDOrSXxuXOqhXCqV7CDUY0 ll2algFs=; b=K0Si6brwRg2AQNVEHXDqL5RP3ViNU4n1/EifBO69HnRe9hCJjvM 3yPRIah7tt7ph0+qUKUaglSKuVYFeRUIbS9jB4DzRdn62lpxcW7I0H/zdo1hMjAU eToUyHkHPzlWng6I/Jr1aD9O8+Oa+4DTUZGlDJcojGFNMKtIyvPcgUCre8FpP7oH N3w7rgNFn/VTQJf9xB143cfHCaLnW47dAGfrfK0HafS+ZB74NSwxBESLyf+35ZE/ HnpC+TjOmfxY5NVRWMMHzTFNtrwRLmDdLIHa+GLy2CSwrR2xRtsAPbjVCIh0y9uz NnkEEYcokBjk3v97QXVxGgpjJK24rl8wnuQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684415034; x=1684501434; bh=+EuBxStaKnIPdoDOrSXxuXOqhXCqV7CDUY0 ll2algFs=; b=YuZ+SAaaooVsDQuGNEw2csZQZiJEHS3cBaEWCzqOy6e7qXPX46f 1Ml7/+0guPoqJpqtWqQI9jZIHGWRiKkUmaWzkCxSA3zot4uGuqQWgt2xYoKSTFtR lzyUZoYgzpAAieAQiixrTWx0Bmj2QWQqZplIXeEEo7aBpAs58XXP9iENZ5IBcJ22 NMYyeJJVci4khYu8Mu3YiTwszM1dZtZC69E5jSUGvZZ3qiWe8Xp5dgdcPWF/nS5t ClpYxLUNBvyQRSxgsQejVselejeExLvHqkPijseB//Jo/avXtTvqBwFJUjo9QK72 QKf+hdYyOZCZLqiZhy7sda9/OO5NnUkpJNQ==
X-ME-Sender: <xms:OSJmZP4NJxwMIbX6XU_afy8wY3toH2Q-45kLKuRdfp_Ee1s77HKgBw> <xme:OSJmZE5FUYVj2oTw0fEH6YZJrvNJVDipHWG3cLs0cBso5jWBZxAJstxidsnMJ7f_5 0vOGrH8Cj-b_gNSvA>
X-ME-Received: <xmr:OSJmZGfuJkfSq2rlXbpfzmvuJ-pdnKA2Li36hjOK-q8lN2UL10BjJrA-pPQKB4UZdNs>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeifedgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffvefgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeforghr khcupfhothhtihhnghhhrghmuceomhhnohhtsehmnhhothdrnhgvtheqnecuggftrfgrth htvghrnhepueehgeeujeehfeffhedttdfgkeegffdtteffgfelgfefudekvdeuueeuueeu ledtnecuffhomhgrihhnpegvgigrmhhplhgvrdhorhhgpdhmnhhothdrnhgvthenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmnhhothesmhhn ohhtrdhnvght
X-ME-Proxy: <xmx:OiJmZAJ4m6NkHaq-hLhPVBSCI-L1JYpF0dgKqcsdNefCw83FcvsyYA> <xmx:OiJmZDKpH_E0mrNqZE20WjKhHlnV-fFtkPf8uXojgt13FvVa6zp4zw> <xmx:OiJmZJySfPMc6M4GmvFm6tb561WF_QdKYOjIo1t83xk_McwjZ-XHwA> <xmx:OiJmZKXqL_4WgfMg9rMt9gGr0lSf_B3tJbQNnIrT55BNe0GxQykugA>
Feedback-ID: ie6694242:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 18 May 2023 09:03:53 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
From: Mark Nottingham <mnot@mnot.net>
In-Reply-To: <168424064858.44084.3692769234533396629@ietfa.amsl.com>
Date: Thu, 18 May 2023 14:03:52 +0100
Cc: gen-art@ietf.org, HTTP APIs Working Group <httpapi@ietf.org>, Last Call <last-call@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <34AA44A9-B351-4798-8920-90724F600D8D@mnot.net>
References: <168424064858.44084.3692769234533396629@ietfa.amsl.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3731.500.231)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/PzPLX9WOF8VjNUM3T5rD5XBndC4>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-httpapi-link-template-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 May 2023 13:04:01 -0000

Hi Christer,

Thanks for the review; responses below.

> On 16 May 2023, at 1:37 pm, Christer Holmberg via Datatracker <noreply@ietf.org> wrote:
[...]
> Q2_1: There is no ABNF for the header field. There are examples using both
> quotes ("/{username}") and angle brackets (</books/{book_id}/author>), so
> please include the ABNF.

This is a Structured Field; in the HTTP community, we've agreed that documenting them with ABNF is not good practice.

> Q2_2: The text says "Parameter values MUST be Strings."
> 
> It is unclear what "Strings" means. Does it mean that parameter values must be
> encoded as quoted-strings? If so, why? RFC8288 says that parameter values can
> be encoded both as token and quoted-string.

S 1.1: "This specification uses the following terms from [STRUCTURED-FIELDS]: List, String, Parameter."

> Q2_3: The text says:
> 
>      Link-Template: </books/{book_id}/author>;
>                       rel="author" anchor="#{book_id}"
> 
> Is there a ";" missing between the rel and anchor parameters?

Yes; already fixed.

> Q2_4: The text says:
> 
>        Link-Template: "/widgets/{widget_id}"
>                       rel="https://example.org/rel/widget";
>                       var-base="https://example.org/vars/"
> 
> Is there a ";" missing at the end of the first line?

Yes - thanks!

Cheers,

--
Mark Nottingham   https://www.mnot.net/