IETF Logo Mail Archive

Re: [Gen-art] Gen-ART telechat review of draft-ietf-idr-ls-distribution-10

"Adrian Farrel" <adrian@olddog.co.uk> Sun, 10 May 2015 19:51 UTC

Return-Path: <adrian@olddog.co.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 671B61A9046 for <gen-art@ietfa.amsl.com>; Sun, 10 May 2015 12:51:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.599
X-Spam-Level:
X-Spam-Status: No, score=-102.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PTybjPPsUkYm for <gen-art@ietfa.amsl.com>; Sun, 10 May 2015 12:51:18 -0700 (PDT)
Received: from asmtp1.iomartmail.com (asmtp1.iomartmail.com [62.128.201.248]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 58C771A9047 for <gen-art@ietf.org>; Sun, 10 May 2015 12:51:17 -0700 (PDT)
Received: from asmtp1.iomartmail.com (localhost.localdomain [127.0.0.1]) by asmtp1.iomartmail.com (8.13.8/8.13.8) with ESMTP id t4AJp7Nj026538; Sun, 10 May 2015 20:51:07 +0100
Received: from 950129200 (dsl-sp-81-140-15-32.in-addr.broadbandscope.com [81.140.15.32]) (authenticated bits=0) by asmtp1.iomartmail.com (8.13.8/8.13.8) with ESMTP id t4AJp6gM026527 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sun, 10 May 2015 20:51:06 +0100
From: Adrian Farrel <adrian@olddog.co.uk>
To: sairay@cisco.com, afarrel@juniper.net, sprevidi@cisco.com, jmedved@cisco.com, hannes@juniper.net
Date: Sun, 10 May 2015 20:51:04 +0100
Message-ID: <00d901d08b5a$a6fcb080$f4f61180$@olddog.co.uk>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_00DA_01D08B63.08C38980"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdCLWhQrDvGCRoFrR76mtFbde6lBAQ==
Content-Language: en-gb
X-TM-AS-MML: disable
X-TM-AS-Product-Ver: IMSS-7.1.0.1576-7.5.0.1018-21536.002
X-TM-AS-Result: No--30.077-10.0-31-10
X-imss-scan-details: No--30.077-10.0-31-10
X-TMASE-MatchedRID: UP6whsI5SHI7iuZ/mdYYtmHnVzXwG5G6oCbNFYvE9ucHcn43hG8LIOa7 bWQUrZk7yTFHn2d6nuaNZ7kc4Uq+4y4tncCojEfcbjszmzF92gg9dagwNh/l7OmMGMHVq5QmVcu iE76FYvQLazoQyrpm0nNpt3uWj96mcHdSqDyzIhSX1RWcrwojHDJsMcRxpvl6aRMTbdv+MwptCU fRYcqcQ3OyDIdCVNAEwCZxkTHxccmz5LIh2+IOfPHFoBcOsKezK9cv8CB/xsb2netXH3Tt1Ctdn IraA9p0DpfVsOpEdC9sG7r4Qh7N3CIEB/X0tggGs/uo6bL1AFQXQU5a094toqfOccI8nXPJLyrI O97pdQAtj0Ce93dF0rU+IyHhkXf1QZXZg2I8Jaabkr+En8YSt+//vbMLiEkVWFQNk4+HCoiHMqV ObyPMMsNYV73vYBFQjtK7dC6UBnkUqWKocoJo6esoDDE6CvPdp4WcmyqBbFx/vkHgSlwJzeBe5Q RmIfivPwbcb/CNUOlwvDydhBUuyCAXLFyLhL5W5GdZsk1yqBcqoeXFMnt4lSJunynLhcivKEdCt wyfJsLWV8MKb34RlRZU/yoIC8o9JVsoL7U3JcBWoRkbdZaAblQ+CF9xoc5LnE2RogVHfH2sEFKe f8ZUxtsoDJz5OAzcthSuSdSoQvvTMQ/93vE8XUbaqUVvLFsimpFVmGA1607MDEuDg15grJ7jobR LBotGT+Zs2lM+sECdCtkMrsOtOpkShYcLpGH9ZM25ZAWwDYZgEEZ9y/pY4Y0id0pIhqxT15LlVZ STLD2ceiJYn/Dsxq73FVUimLHPyiBjGmb09NubKItl61J/yZUdXE/WGn0FSXhbxZVQ5H9ligLsP FvyJQUZpJZ0vFtNvfP6RL0lxWq+0G8RULDgIqj5aew842em
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/QEkViGbVnBEBVMRAGLWXGlA-REE>
Cc: idr-chairs@tools.ietf.org, gen-art@ietf.org, rtg-ads@tools.ietf.org
Subject: Re: [Gen-art] Gen-ART telechat review of draft-ietf-idr-ls-distribution-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
Reply-To: adrian@olddog.co.uk
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 10 May 2015 19:51:21 -0000

Forwarding on behalf of Alexey.
 
From: Alexey Melnikov [mailto:alexey.melnikov@isode.com] 
Sent: 10 May 2015 17:22
To: adrian@olddog.co.uk
Subject: Fwd: [Gen-art] Gen-ART telechat review of draft-ietf-idr-ls-distribution-10
 
Hi Adrian,
I am having some problems with the tools.ietf.org alias expansion. Can you forward to your co-editors?
-------- Original Message -------- 

Subject: 
[Gen-art] Gen-ART telechat review of draft-ietf-idr-ls-distribution-10

Date: 
Sun, 10 May 2015 17:18:12 +0100

From: 
Alexey Melnikov  <mailto:alexey.melnikov@isode.com> <alexey.melnikov@isode.com>

To: 
draft-ietf-idr-ls-distribution.all@tools.ietf.org, General Area Review Team  <mailto:gen-art@ietf.org> <gen-art@ietf.org>
 
[Resending]
 
I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
 <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.
 
Please wait for direction from your document shepherd
or AD before posting a new version of the draft.
 
Document: draft-ietf-idr-ls-distribution-10.txt
Reviewer: Alexey Melnikov
Review Date: 2015-05-10
IETF LC End Date: 2015-04-08
IESG Telechat date: N/A
 
My apologies for the late review of this document.
 
Summary: Ready with nits
 
 
Minor (but some of these might be more serious):
 
In 6.2.2:
 
If an implementation of BGP-LS detects a malformed attribute, then it
    SHOULD use the ’Attribute Discard’ action as per
    [I-D.ietf-idr-error-handling] Section 2.
 
This needs to be a Normative reference. Or you can keep it as 
Informative, if you change the sentence not to use RFC 2119 language.
 
In 3.3.1.1 - does this need a new IANA registry? (I am fine if you think 
you don't).
 
In 3.3.1.3/3.3.2.7 - what is "subset of the FQDN"?
 
In 3.3.2.3:
 
       The TE Default Metric TLV carries the TE-metric for this link.
       The length of this TLV is fixed at 4 octets.
 
I am probably showing my ignorance, but is the term "TE-metric" defined 
somewhere? The description below suggests it has substructure, which I 
don't know anything about.
 
        If a source protocol (e.g.
        IS-IS) does not support a Metric width of 32 bits then the high
        order octet MUST be set to zero.
 
Best Regards,
Alexey
 
_______________________________________________
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email