Re: [Gen-art] [mpls] Genart last call review of draft-ietf-mpls-rsvp-shared-labels-06

Russ Housley <housley@vigilsec.com> Mon, 10 December 2018 21:58 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 203DC131256 for <gen-art@ietfa.amsl.com>; Mon, 10 Dec 2018 13:58:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w5HiALR9CV1I for <gen-art@ietfa.amsl.com>; Mon, 10 Dec 2018 13:58:15 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0A76A128BCC for <gen-art@ietf.org>; Mon, 10 Dec 2018 13:58:15 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 2BA53300AC0 for <gen-art@ietf.org>; Mon, 10 Dec 2018 16:49:36 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0iO17ilZD6hM for <gen-art@ietf.org>; Mon, 10 Dec 2018 16:49:33 -0500 (EST)
Received: from [192.168.1.161] (pool-108-45-137-105.washdc.fios.verizon.net [108.45.137.105]) by mail.smeinc.net (Postfix) with ESMTPSA id AA4D8300688; Mon, 10 Dec 2018 16:49:33 -0500 (EST)
From: Russ Housley <housley@vigilsec.com>
Message-Id: <B499EE64-EA69-4965-A46A-0D23A3833E51@vigilsec.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_C1BF5EC2-F0C5-4DBB-9972-E81A5ABC23C6"
Mime-Version: 1.0 (Mac OS X Mail 12.1 \(3445.101.1\))
Date: Mon, 10 Dec 2018 16:49:34 -0500
In-Reply-To: <CA+YzgTt6orUKqcTDdyugcerozMGbg6WTF===mmZBra8Xx6xzEQ@mail.gmail.com>
Cc: IETF Gen-ART <gen-art@ietf.org>, IETF MPLS List <mpls@ietf.org>, IETF <ietf@ietf.org>, draft-ietf-mpls-rsvp-shared-labels.all@ietf.org
To: Vishnu Pavan Beeram <vishnupavan@gmail.com>
References: <154360254979.27470.14714094577368742271@ietfa.amsl.com> <CA+YzgTt6orUKqcTDdyugcerozMGbg6WTF===mmZBra8Xx6xzEQ@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.101.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/QcmJVUViuSz6Zssjb9Gmg4dGKoM>
Subject: Re: [Gen-art] [mpls] Genart last call review of draft-ietf-mpls-rsvp-shared-labels-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Dec 2018 21:58:16 -0000

Yes, those changes resolve my comments.

Russ


> On Dec 10, 2018, at 12:57 AM, Vishnu Pavan Beeram <vishnupavan@gmail.com>; wrote:
> 
> Russ, Hi!
> 
> Much Thanks for the review! We just posted a new rev (-07) to address your comments. Please do go through the diffs (https://tools.ietf.org/rfcdiff?url2=draft-ietf-mpls-rsvp-shared-labels-07.txt <https://tools.ietf.org/rfcdiff?url2=draft-ietf-mpls-rsvp-shared-labels-07.txt>) and let us know if the new version adequately addresses your concern. 
> 
> The term "loose hop" was introduced in RFC3209. So we just added a reference to it in the relevant sentence.
> 
> Regards,
> -Pavan (on behalf of the authors)
> 
> On Fri, Nov 30, 2018 at 1:29 PM Russ Housley <housley@vigilsec.com <mailto:housley@vigilsec.com>> wrote:
> Reviewer: Russ Housley
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>>;.
> 
> Document: draft-ietf-mpls-rsvp-shared-labels-06
> Reviewer: Russ Housley
> Review Date: 2018-11-30
> IETF LC End Date: 2018-12-11 
> IESG Telechat date: unknown
> 
> Summary: Ready
> 
> 
> Major Concerns:
> 
> None
> 
> 
> Minor Concerns:
> 
> Section 5.3: To understand this section, I had to learn about "loose
> hops" from other sources.  Please consider adding this term to the ones
> that are defined in Section 2.
> 
> 
> Nits:
> 
> Throughout document: s/hop by hop/hop-by-hop/
> 
> Section 5.3.1: s/The net result is that by/As a result, by/
> 
> _______________________________________________
> mpls mailing list
> mpls@ietf.org <mailto:mpls@ietf.org>
> https://www.ietf.org/mailman/listinfo/mpls <https://www.ietf.org/mailman/listinfo/mpls>