Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-ippm-stamp-option-tlv-06

Greg Mirsky <gregimirsky@gmail.com> Tue, 21 July 2020 02:01 UTC

Return-Path: <gregimirsky@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B0B743A12AD; Mon, 20 Jul 2020 19:01:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id envZi8DDn34q; Mon, 20 Jul 2020 19:01:19 -0700 (PDT)
Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ED5103A128C; Mon, 20 Jul 2020 19:01:18 -0700 (PDT)
Received: by mail-ot1-x330.google.com with SMTP id g37so13867488otb.9; Mon, 20 Jul 2020 19:01:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RObJfWzamMRIsKtI/jYDAom+n6cFFX+7huTUpotTG7A=; b=M+0NO/7jliGTXPzHLPala/cmoz3rlZSItLjU2COM1FnxvMeOqPNdtou/wmrTS9K4Da AoP7JKaT5RRDmcK0Bd7+iHVi65Luf8lCvdNB19bjuNIs8DRBtvL1eWSqAimBH2BiKqQl XoA4LziCE0X+w0he1yDhXmHLhDFXYYAGTar4+uxlBNacgPGu1re2hI5uUNmcOD2t1EKc DnfmkJ7gBFPOxAX/Is9zsoAX9id1nJA2fyvNB4TbNqncj9/acLGnTapgWlah+y5heD/D EwFaqPdIlZDlQZUH7IYo6wjqO6y6GGtNuDr0FXH5QeAD2fa9V1owSj3o+18HZZgK7QAm BDnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RObJfWzamMRIsKtI/jYDAom+n6cFFX+7huTUpotTG7A=; b=UVSop8nqEBAHT69PLhmr6+pooXCOVClu6Kn0Xrhv9+stdpAZ+kHwqkwxOhbb2G2iMG 98gWMvTlgAcr4mWMnEtplhxRtmHNNYlTBwqrMujhZCHTaq3glz6Yi5ObURtUMY5nlrgu G5wYkYNW+EvW5z8cBkiNEBYdoAz1WfyFYWXCjzz9FKfGN6EKJiCQbaa27Hk7AY0soLTe P7l+qX1+GDPDdTjlvQOYmWsodXM3MHRMOgoRHRHUvkmk2CE7m+s4BzGjCwiAjjNAxdLV L4akyF+FbmAj9a6cZNb40jqfAwYdULTyj1Om7J7spP1j87JFj/RGu6BiyIbnx/YPuzpA ZndA==
X-Gm-Message-State: AOAM530fCaVmTxnHMA2aPKQnJ9dE7eznLJfsFlNFV18KlagC3nP6+5/d /rjhbO56TkyNA0P43eNYz2PYiJq53Wb4CmHnXdUDIOVg
X-Google-Smtp-Source: ABdhPJxdZQ9pEyf7JQEEtMwgNuRff+IgQ/b0wRsgKrjxppKQwZzfyPJ7/hKfj2Ddfingm2D3wPk7OLyt8y5JxwioH60=
X-Received: by 2002:a05:6830:20d8:: with SMTP id z24mr23643511otq.266.1595296878173; Mon, 20 Jul 2020 19:01:18 -0700 (PDT)
MIME-Version: 1.0
References: <159344297273.15718.9292174200591066435@ietfa.amsl.com> <CA+RyBmVjSezyTs=r4zL4OjzzK5eG1SMZHLs+5NoNhwniZYx18w@mail.gmail.com> <20200717223913.GD41010@kduck.mit.edu> <CA+RyBmWhCOzuCYBDPeyywjaiR-vsvRQavBVo7xzYEOEgdBvnZQ@mail.gmail.com> <CAFgnS4Ub0jyp2RL8UOZvWNGAgEZpGpgM2KwZLqP=RjUGo81epw@mail.gmail.com> <20200721014809.GA41010@kduck.mit.edu>
In-Reply-To: <20200721014809.GA41010@kduck.mit.edu>
From: Greg Mirsky <gregimirsky@gmail.com>
Date: Mon, 20 Jul 2020 19:01:06 -0700
Message-ID: <CA+RyBmU9G1T4Xr2dwHXKqYzbPQXxiYDRrGd-Xx6watoH46Lb2w@mail.gmail.com>
To: Benjamin Kaduk <kaduk@mit.edu>
Cc: Dan Romascanu <dromasca@gmail.com>, last-call@ietf.org, gen-art <gen-art@ietf.org>, draft-ietf-ippm-stamp-option-tlv.all@ietf.org, IETF IPPM WG <ippm@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Qwj6gmJ_owJCdhI-Mp1gpBYmdDk>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-ippm-stamp-option-tlv-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Jul 2020 02:01:21 -0000

Hi Ben,
thank you for the suggestions. Would the Informational reference to
draft-gont-numeric-ids-generation be reasonable?

Regards,
Greg

On Mon, Jul 20, 2020 at 6:48 PM Benjamin Kaduk <kaduk@mit.edu> wrote:
>
> Thanks Dan.
>
> Greg, my recommendation would be to refer to the appopriate section of
> https://tools.ietf.org/html/draft-gont-numeric-ids-generation-03 for the
> needs in question.  My understanding is that STAMP needs only unique (not
> ordered) session IDs, and that furthermore, an occasional accidental
> collision would not be catastrophic, in which case we can use the
> "Uniqueness (soft failure)" characterization of Section 7.1 of the linked
> document.
>
> -Ben
>
> On Sat, Jul 18, 2020 at 09:37:08AM +0300, Dan Romascanu wrote:
> > Greg's understanding of my comment is correct.
> >
> > Regards,
> >
> > Dan
> >
> >
> > On Sat, Jul 18, 2020 at 2:56 AM Greg Mirsky <gregimirsky@gmail.com> wrote:
> >
> > > Hi Ben,
> > > thank you for the reference, very helpful. As you've noticed, this method
> > > mentioned as an example. Would you suggest referencing another technique?
> > > As I understood, Dan's comment was not specific to the sequential increment
> > > allocation policy but to provide some guidance to an implementor.
> > >
> > > Regards,
> > > Greg
> > >
> > > On Fri, Jul 17, 2020 at 3:39 PM Benjamin Kaduk <kaduk@mit.edu> wrote:
> > >
> > >> Hi again Greg :)
> > >>
> > >> Reading Dan's review reminded me of one other point (inline)...
> > >>
> > >> On Thu, Jul 02, 2020 at 12:22:04PM -0700, Greg Mirsky wrote:
> > >> > Hi Dan,
> > >> > thank you for your review, detailed questions, and helpful suggestions.
> > >> > Please find my answers and notes below tagged GIM>>.
> > >> >
> > >> > Regards,
> > >> > Greg
> > >> >
> > >> > On Mon, Jun 29, 2020 at 8:02 AM Dan Romascanu via Datatracker <
> > >> > noreply@ietf.org> wrote:
> > >> >
> > >> > > Reviewer: Dan Romascanu
> > >> > > Review result: Ready with Issues
> > >> > >
> > >> > > I am the assigned Gen-ART reviewer for this draft. The General Area
> > >> > > Review Team (Gen-ART) reviews all IETF documents being processed
> > >> > > by the IESG for the IETF Chair.  Please treat these comments just
> > >> > > like any other last call comments.
> > >> > >
> > >> > > For more information, please see the FAQ at
> > >> > >
> > >> > > <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> > >> > >
> > >> > > Document: draft-ietf-ippm-stamp-option-tlv-06
> > >> > > Reviewer: Dan Romascanu
> > >> > > Review Date: 2020-06-29
> > >> > > IETF LC End Date: 2020-07-06
> > >> > > IESG Telechat date: Not scheduled for a telechat
> > >> > >
> > >> > > Summary: Ready with issues
> > >> > >
> > >> > > This is a clear, well-written document. There are a few minor issues
> > >> that
> > >> > > would
> > >> > > benefit from clarifications and possible edits before approval.
> > >> > >
> > >> > > Major issues:
> > >> > >
> > >> > > Minor issues:
> > >> > >
> > >> > > 1. Section 3. Is there any recommended strategy to generate SSIDs? Are
> > >> > > these
> > >> > > supposed to be generated sequentially? Randomly? How soon is the 16
> > >> -bit
> > >> > > space
> > >> > > supposed to wrap-up? Some clarification would be useful I believe.
> > >> > >
> > >> > GIM>> Because test sessions, in general, will be performed for different
> > >> > periods of time, implementation will need to manage the pool of
> > >> available
> > >> > identifiers. I agree, the initial allocation may use sequential
> > >> ascending
> > >> > increment by one method, but at some point, it will be
> > >> > "get-the-next-available number". I propose to update the text as
> > >> follows:
> > >> > OLD TEXT:
> > >> >    A STAMP
> > >> >    Session-Sender MAY generate a locally unique STAMP Session Identifier
> > >> >    (SSID).  SSID is two octets long non-zero unsigned integer.
> > >> > NEW TEXT:
> > >> >    A STAMP
> > >> >    Session-Sender MAY generate a locally unique STAMP Session Identifier
> > >> >    (SSID).  SSID is two octets long non-zero unsigned integer. SSID
> > >> > generation
> > >> >    policy is implementation-specific. For example, sequentially
> > >> ascending
> > >> >    incremented by one method could be used for the initial allocation of
> > >> > SSID.
> > >> >    Because of test sessions lasting different time an implementation
> > >> that
> > >> > uses
> > >> >    SSID MUST monitor the pool of available identifiers. An
> > >> implementation
> > >> >    SHOULD NOT assign the same identifier to different STAMP test
> > >> sessions.
> > >>
> > >> I would actually recommend against mentioning the "sequential increment"
> > >> strategy.  There's some justification for why in
> > >> draft-gont-numeric-ids-sec-considerations (and more in the references),
> > >> which I just completed my AD Evaluation of with intent to AD sponsor as a
> > >> BCP.
> > >>
> > >> Thanks,
> > >>
> > >> Ben
> > >>
> > >