Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05

Russ Housley <housley@vigilsec.com> Fri, 11 September 2015 16:18 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B32801ACF54; Fri, 11 Sep 2015 09:18:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eECRLIxQUeec; Fri, 11 Sep 2015 09:18:24 -0700 (PDT)
Received: from odin.smetech.net (x-bolt-wan.smeinc.net [209.135.219.146]) by ietfa.amsl.com (Postfix) with ESMTP id 465731A893F; Fri, 11 Sep 2015 09:18:24 -0700 (PDT)
Received: from localhost (unknown [209.135.209.5]) by odin.smetech.net (Postfix) with ESMTP id A8EA9F2414F; Fri, 11 Sep 2015 12:18:13 -0400 (EDT)
X-Virus-Scanned: amavisd-new at smetech.net
Received: from odin.smetech.net ([209.135.209.4]) by localhost (ronin.smeinc.net [209.135.209.5]) (amavisd-new, port 10024) with ESMTP id NXaGFd15-X44; Fri, 11 Sep 2015 12:16:56 -0400 (EDT)
Received: from [192.168.2.100] (pool-108-51-128-219.washdc.fios.verizon.net [108.51.128.219]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by odin.smetech.net (Postfix) with ESMTP id EE2C4F24150; Fri, 11 Sep 2015 12:17:52 -0400 (EDT)
Mime-Version: 1.0 (Apple Message framework v1085)
Content-Type: text/plain; charset=us-ascii
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <CAF4+nEGAnyBVrv=Rbc0gfDijYsjraBW62ugC1Rwo07e6PSg_NA@mail.gmail.com>
Date: Fri, 11 Sep 2015 12:17:42 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <53C61587-9F97-4664-9F84-603199B46D3E@vigilsec.com>
References: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com> <4552F0907735844E9204A62BBDD325E7871A2CFE@nkgeml512-mbx.china.huawei.com> <CAF4+nEGAnyBVrv=Rbc0gfDijYsjraBW62ugC1Rwo07e6PSg_NA@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
X-Mailer: Apple Mail (2.1085)
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/ShOuqnKqt_E45jrJMaYvEex2LjE>
Cc: Mingui Zhang <zhangmingui@huawei.com>, IETF Gen-ART <gen-art@ietf.org>, IETF <ietf@ietf.org>, "draft-ietf-trill-pseudonode-nickname.all@ietf.org" <draft-ietf-trill-pseudonode-nickname.all@ietf.org>
Subject: Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Sep 2015 16:18:25 -0000

Donald:

>>> Document: draft-ietf-trill-pseudonode-nickname-05
>>> Reviewer: Russ Housley
>>> Review Date: 2015-08-24
>>> IETF LC End Date: 2015-09-01
>>> IESG Telechat date: unknown
>>> 
>>> Summary: Almost Ready
>>> 
>>> Major Concerns:
>>> 
>>> ...
>> ...
>> 
>>> (2)  Also, in Section 5.2, Step 1, I think the intended sort order depends on all
>>> of the LAALP IDi values being represented with the same number of bits.
>>> Since Section 9.1 provides a variable length field to carry a LAALP ID value, I
>>> assume that they are not always the same length.  Is a step needed to
>>> encode the LAALP ID to a consistent length?
>> 
>> [MZ] The sort is done in the per-LAALP base. It's not necessary to make the LAALP ID to a constant length. Besides, the 'mod' function always returns a value in [0, k-1] whatever the length of LAALP ID is.
> 
> We could add "considering System ID and LAALP ID as byte strings".

I am not sure that is enough unless all of the System IDs are the same length.

Russ