Re: [Gen-art] review of draft-ietf-hip-dex-11.txt

"Eric Vyncke (evyncke)" <evyncke@cisco.com> Sat, 16 November 2019 05:48 UTC

Return-Path: <evyncke@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A119A1200C3; Fri, 15 Nov 2019 21:48:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.501
X-Spam-Level:
X-Spam-Status: No, score=-14.501 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=M6A7FvJW; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=pI5TVOki
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B-7IGUv1jNSy; Fri, 15 Nov 2019 21:48:41 -0800 (PST)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8855812009C; Fri, 15 Nov 2019 21:48:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2982; q=dns/txt; s=iport; t=1573883321; x=1575092921; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=18fLiGtcOLKfJ7S3Gi/7Wvlg6DgLnJy3hjuSgLTfLSo=; b=M6A7FvJWT4EfRazGRuojhzuXpGeYVdva4FdtgGihxq7bxTwBZBs2bC2l RK3fuXLnx4ncfTAMQnyS3RzKXQpfRBa3KfK8VXucVq3veXCa1tS3Jjd0J yUNtFH++c+yKcTH0zosCkkYkGU7vxc+butuW0wjmakIQ0QoetuoIkQwfg w=;
IronPort-PHdr: 9a23:cXpJGhBMVqf9tLPBzjv7UyQJPHJ1sqjoPgMT9pssgq5PdaLm5Zn5IUjD/qs13kTRU9Dd7PRJw6rNvqbsVHZIwK7JsWtKMfkuHwQAld1QmgUhBMCfDkiuIeD7aSc5EexJVURu+DewNk0GUMs=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CuAABpjM9d/51dJa1lGgEBAQEBAQEBAQMBAQEBEQEBAQICAQEBAYF+gUtQBWxYIAQLKoQpg0YDinKCXpgAglIDVAkBAQEMAQEjCgIBAYRAAheCDCQ4EwIDCwEBBAEBAQIBBQRthTcMhVICAQMSEQQNDAEBNwEPAgEIEAQGAhkNAgICMBUQAgQBDQUbB4MAAYJGAy4BDqUGAoE4iGB1fzOCfgEBBYJJglgYghcDBoEOKIwVGIFAP4ERJx+CTD6CYgKBYRchAoJWMoIsjVWCPp4WCoIqhxmONBuCPodoj2iOSIg4kVACBAIEBQIOAQEFgWkigVhwFWUBgkFQERSRGoNzYIQ0hT90gSiQCQEB
X-IronPort-AV: E=Sophos;i="5.68,311,1569283200"; d="scan'208";a="364553569"
Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 16 Nov 2019 05:48:40 +0000
Received: from XCH-ALN-016.cisco.com (xch-aln-016.cisco.com [173.36.7.26]) by rcdn-core-6.cisco.com (8.15.2/8.15.2) with ESMTPS id xAG5me0a004350 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Sat, 16 Nov 2019 05:48:40 GMT
Received: from xhs-aln-003.cisco.com (173.37.135.120) by XCH-ALN-016.cisco.com (173.36.7.26) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 15 Nov 2019 23:48:39 -0600
Received: from xhs-rtp-003.cisco.com (64.101.210.230) by xhs-aln-003.cisco.com (173.37.135.120) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 15 Nov 2019 23:48:37 -0600
Received: from NAM01-BN3-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-003.cisco.com (64.101.210.230) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sat, 16 Nov 2019 00:48:37 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EhsaM5chySa3XL2D8r1NFdPOMt19QwJHbXLhGSQhIDx6nYpoHIRay9JQhG56mGlElnRfRc0GoQsmcBHedXuSyXLtfbztqq778W90uK8N/g1YIu1kVdFB/4KrS0yu1WGW/ByleFMXka21hgeEgToQn2Kqw3O670tA4Icy6QrldKKoqrhvnQbPX02KgaNjbDN2rKkcjSXELw9JxIx16IWP18g1EMffTE/Sg3FcfzwZCAi+/s71IkNh93kMkDsf4jz23WvNz009svPn2ExwRTYtTlkL5mn6iUMZtqwY7piy1qahQobZFZgLROpF5INM60+rJ2ryuQjK0NxZyVbDM+IXqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=18fLiGtcOLKfJ7S3Gi/7Wvlg6DgLnJy3hjuSgLTfLSo=; b=V5lD6kU+9iX4WuAdkImsaazg6Lyy4td09ulz7+Nnscza2M+xTs+ll2iYC8LdEAnOwy5qeGhvyv6L/bXxQ3zqq6CUzpD+bXofN9Rfet6TWu6adFMlZ4iwQknNhTqUopi6dGmfg3b4JmgeBLDj7fn2VdAeTpHh7jOm2z3GGisCdyNxDe4jYtXvNA8P1IXOOc9rwlWM/HhAVNSDDmfCkxYcgBt+agKhKURGsocbiKj9Q8QfWMuREVzEAmRWVwul3D6Lbc43xlSubMqjqMA5TIUo8itpw/2rrkmyVIG/v53GIlFQMmHEsSr8uMmb0BrVZalUQvNsiySsJj5j4bJzZa3rEQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=18fLiGtcOLKfJ7S3Gi/7Wvlg6DgLnJy3hjuSgLTfLSo=; b=pI5TVOkiD9n9DZxvA2UnCJd/n8RfTkl9VKc0PnJR7pMPVWrnnk7vk5NRQ+a4gCFARMsfL08+MAXCIm1LvYD5KqIDXnkvs2lyE7MKr/gMH8ye7eQK0xVGIAFxiTMVJ9xeER/exo9sN+i4i+Q0fYUdgiK3wYzRjZy7seB0hvpbHjI=
Received: from DM5PR11MB1753.namprd11.prod.outlook.com (10.175.88.141) by DM5PR11MB1932.namprd11.prod.outlook.com (10.175.92.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2451.23; Sat, 16 Nov 2019 05:48:36 +0000
Received: from DM5PR11MB1753.namprd11.prod.outlook.com ([fe80::6c99:679c:82cd:b955]) by DM5PR11MB1753.namprd11.prod.outlook.com ([fe80::6c99:679c:82cd:b955%12]) with mapi id 15.20.2451.029; Sat, 16 Nov 2019 05:48:36 +0000
From: "Eric Vyncke (evyncke)" <evyncke@cisco.com>
To: Francis Dupont <Francis.Dupont@fdupont.fr>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "draft-ietf-hip-dex.all@ietf.org" <draft-ietf-hip-dex.all@ietf.org>
Thread-Topic: review of draft-ietf-hip-dex-11.txt
Thread-Index: AQHVmv8n07aeKq5ByEuMbWl1fBj96aeNXb2A
Date: Sat, 16 Nov 2019 05:48:36 +0000
Message-ID: <6C874D65-C15F-4B4C-B4CD-872D5BB5DCF9@cisco.com>
References: <201911141428.xAEESkn0001499@givry.fdupont.fr>
In-Reply-To: <201911141428.xAEESkn0001499@givry.fdupont.fr>
Accept-Language: fr-BE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.1f.0.191110
authentication-results: spf=none (sender IP is ) smtp.mailfrom=evyncke@cisco.com;
x-originating-ip: [2001:420:c0d4:1001::26]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 55d69fb1-68f4-4829-9283-08d76a589f95
x-ms-traffictypediagnostic: DM5PR11MB1932:
x-microsoft-antispam-prvs: <DM5PR11MB1932C1436F76DC336AE55A09A9730@DM5PR11MB1932.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 02234DBFF6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(376002)(396003)(346002)(39860400002)(54094003)(189003)(199004)(8676002)(66946007)(6436002)(316002)(99286004)(25786009)(110136005)(66476007)(64756008)(2501003)(58126008)(66446008)(71200400001)(6486002)(33656002)(6306002)(6246003)(6116002)(6512007)(4326008)(186003)(229853002)(66556008)(14444005)(256004)(91956017)(71190400001)(76116006)(46003)(478600001)(76176011)(486006)(7736002)(36756003)(5660300002)(6506007)(81166006)(476003)(102836004)(11346002)(2906002)(446003)(2616005)(86362001)(8936002)(14454004)(305945005)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR11MB1932; H:DM5PR11MB1753.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Gyet8/3dqosDCS1lA6HuTIyu+XZMWk0Pae45t0zEbRX1TZitvFyXRxLVXywHBk/K1YT9wI/P7dr6j9hrkOyeiyxcOyfsM00CKEIhdW589KMaV41YYc7YnqnxuZlQ7jk4X0KodrYf0GQFPLuc5d5247ZMH3+xMZyGH8b/GazB1aeSBFD+sVkLo/eSFJvzgS236T/HyZ9HZF2qyCrTFwgZoLBRBnOCG6yApI+0cbWl7xrIhD3oUGn238RQf5567Ql2HuJgOiUmR5Y6p7w+QC/B4ClnqG4hfD+es5nMTFq/N+w3XBYbVJyIilP/D3zDR1ei7FvZCpG/SA/yZxfa3yhMSdDdSECN3gbet40dxkOhdTkU6bj8Lv63RLLmZYq9d742anqifdr4By4IS9Jtbu8+8eEVuTuQdCFZU1nX5yFpPg4BQQa+oj1xLokfHhF8qIbT
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <3F6D79F89C8D234CA697FD81153C0E47@namprd11.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 55d69fb1-68f4-4829-9283-08d76a589f95
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2019 05:48:36.1331 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0J53Vt+ETRtZpuoz6dQukg/fHKx5GWHNTSg03VWTiQKYl+BBwq4WlupHTmB3fLfGnAU5X3DL9iL8IS9S4F4ulw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1932
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.26, xch-aln-016.cisco.com
X-Outbound-Node: rcdn-core-6.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/TErLXl6zN6pNk3hwvkQOSlXonH0>
Subject: Re: [Gen-art] review of draft-ietf-hip-dex-11.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Nov 2019 05:48:44 -0000

Thank you Francis for the review.

Very much appreciated

-éric

On 14/11/2019, 23:21, "Francis Dupont" <Francis.Dupont@fdupont.fr> wrote:

    I am the assigned Gen-ART reviewer for this draft. The General Area
    Review Team (Gen-ART) reviews all IETF documents being processed
    by the IESG for the IETF Chair.  Please treat these comments just
    like any other last call comments.
    
    For more information, please see the FAQ at
    
    <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
    
    Document: draft-ietf-hip-dex-11.txt
    Reviewer: Francis Dupont
    Review Date: 20191107
    IETF LC End Date: 20191114
    IESG Telechat date: unknown
    
    Summary: Ready
    
    Major issues: None
    
    Minor issues: None
    
    Nits/editorial comments:
     - 1.2 page 6: highligts -> highlights
    
     - 3 page 8: RFC 6090 does not fully define ECDH because of the "compact"
      representation. Now it is a detail and if it can have an impact for
      implementors I think the security directorate will ask for a clarification
      (and in general I rely on the security directorate for all security
       related points, for instance whether DEX has a formal proof of its
       security properties)
    
     - 5.3.2 page 23: return-routablility -> return-routability
    
     - 4.1.1 page 11: I wonder if the puzzle solution check includes the
      check of the puzzle itself but the remark saying with K=0 the puzzle
      is just a retrun-routability cookie provided an answer... (so nothing
      to change)
    
     - at the exception of the Acknowledgments section you use the English
      spelling (with a 'e'): it is consistent with other HIP documents so
      I have no problem with this.
    
     - 4.1.3.1 page 14: "and he system" -> "and the system"
    
     - 9 page 42: perhaps a SHOULD in "Thus, any signaling
          that indicates such anonymity should be ignored as explained in
          Section 1.1." ?
    
     - 9 page 43: computated -> computed
    
     - B page 50: IEDG -> IESG
    
    Regards
    
    Francis.Dupont@fdupont.fr