Re: [Gen-art] Gen-Art review of draft-holmberg-dispatch-rfc7315-updates

Ralph Droms <rdroms.ietf@gmail.com> Tue, 12 July 2016 15:43 UTC

Return-Path: <rdroms.ietf@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3A6412D50D for <gen-art@ietfa.amsl.com>; Tue, 12 Jul 2016 08:43:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LgyYwAL0RbjA for <gen-art@ietfa.amsl.com>; Tue, 12 Jul 2016 08:43:41 -0700 (PDT)
Received: from mail-qt0-x231.google.com (mail-qt0-x231.google.com [IPv6:2607:f8b0:400d:c0d::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9AC6A12D144 for <gen-art@ietf.org>; Tue, 12 Jul 2016 08:35:05 -0700 (PDT)
Received: by mail-qt0-x231.google.com with SMTP id 52so10055432qtq.3 for <gen-art@ietf.org>; Tue, 12 Jul 2016 08:35:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=4SpTo6dUwCfQlwr458gCdgrNtdaJkH8OIaeB53ESIdg=; b=0LFXfmDnQBoFUbHxtiGqhu4UHDpgWA5kRt7LtJAKZGT843CXB+QTA7zCMZee+oedwN 9cqbuD+z5wtm3tdDCne5CJL7SQgCLx+UiD1dJw0uojGdzLvDN9jgowHMMSYqMttv/Wve X27tenF0UJnnKdu/ZowCk8xaH/uKfWLDfEgcDtAQsFHutpI8+kBBhT4n+WeDvi9BxO9o JpJC1G/j+6vLJi/9tRa8zExjexWSabwlc5g7Iu1MX8ostQhrV/pIAtTdl7RkBt7bOC2U UZaa6d3lFEmB+iIzYeAUAMHW89uZw4PpObbHncHulPui401BKb3u2IdEW2vzcNxrMhfF vPVA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=4SpTo6dUwCfQlwr458gCdgrNtdaJkH8OIaeB53ESIdg=; b=B4L931JopB4776WAW8O3hy6D0IIyJNQI2zuq86QRkbcbMydTtRQBXYf5wAbb9Tmurw QcUvAFAcpFp6n8GNU5ciFOC+2aCE2VnuHZfbYx9BBaI56oEsaIjanta3eniGKNOE5bxs G/PtKaGawFQwcn0Hh5nPBrtiW0EeqSEAfiJSkcAoqhjT7ZleqYcJZFIXx2je6Ewaz6mi XMrXle/mXxkeSaSfWgXXXeLJv96FT+d9yPR+xrCWeoX9PNas9+fpg40oayp/CuUqrWeH 4bulUzarMBwZufO4v/QgfXQdL2WGq1AmUiFIva8/13pMsh5IJTWCmxEyp/uaGGMWuDsD WcPw==
X-Gm-Message-State: ALyK8tLMGajWa4kJr+yNIl3MnzVoZkCCS8JXd+JfErHqwf+T1RvUcNjjxb5Y46dgWY4FjQ==
X-Received: by 10.237.49.101 with SMTP id 92mr4429604qtg.56.1468337704691; Tue, 12 Jul 2016 08:35:04 -0700 (PDT)
Received: from [10.131.118.131] ([173.38.117.74]) by smtp.gmail.com with ESMTPSA id p83sm705547qkh.49.2016.07.12.08.35.03 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jul 2016 08:35:03 -0700 (PDT)
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Content-Type: multipart/signed; boundary="Apple-Mail=_9A525937-284F-45F7-AF4D-32F1E46FC50B"; protocol="application/pgp-signature"; micalg="pgp-sha256"
X-Pgp-Agent: GPGMail 2.6b2
From: Ralph Droms <rdroms.ietf@gmail.com>
In-Reply-To: <D3AAAD06.BC52%christer.holmberg@ericsson.com>
Date: Tue, 12 Jul 2016 11:35:02 -0400
Message-Id: <3EDE649D-47CE-4353-8256-88DFF502F5CC@gmail.com>
References: <EDF251D1-13F4-4AB5-8489-2DDC663A9ED7@gmail.com> <D3AAAD06.BC52%christer.holmberg@ericsson.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/TJ-f4s60ZVKy7cLqLYdKCj-AMuk>
Cc: "Review Area gen-art@ietf.org Team" <gen-art@ietf.org>, "draft-holmberg-dispatch-rfc7315-updates.all@tools.ietf.org" <draft-holmberg-dispatch-rfc7315-updates.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-Art review of draft-holmberg-dispatch-rfc7315-updates
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jul 2016 15:43:44 -0000

> On Jul 12, 2016, at 7:41 AM 7/12/16, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> Hi Ralph,
> 
> Thanks for your comments! Please see inline.
> 
> Minor issues:
> 
> > I had some difficulty unraveling the relationship among the text in section 3.3.2, 3.3.3, 4 and RFC 7315.  Section 3.3.2 specifies the
> > inclusion of the NPLI option in the P-Access-Network-Info header field.  Section 4 does not include text about the NPLI option in the
> > updates to RFC 7315, and I can't find any reference to the NPLI option in RFC 7315.  Is the intention that the text in section 3.3.2
> > constitutes new Internet Standard behavior, not reflected in the update to RFC 7315, am I missing something or am I completely confused?
> 
> Sections 3.3.2 and 3.3.3 describe the 3GPP use-cases which justify the changes to RFC 7315. Section 4 defines those changes.
> 
> Section 4 then defines the changes to RFC 7315, in order to support those use-cases.
> 
> RFC 7315 (Annex A) does talk about the possibility for network provided location information, and the ABNF supports it, but the details of the network provided location information (and the other types of location information) are defined in the 3GPP specification.
> 
> > Section 3.3.3 specifies the inclusion of the IOI option in the P-Charging-Vector header field.  In this case, I am not sure if this specification represents a change to  existing text in RFC 7315 or new behavior.
> 
> Section 3.3.3 (and 3.3.2) does not update RFC 7315. Section 3.3.3 only provides the use-case/justification for the update. The update to RFC 7315 is specified in section 4.
> 
> > I would be happy to hear that I am completely confused; otherwise, I suggest some text be added to clarify that sections 3.3.2 and 3.3.3 also specify some behaviors in addition to explaining the text in section 4.
> 
> Does my clarification above clarify?

Yes.  I had missed that 3.3.2 and 3.3.3 come from 3GPP.  The doc makes perfect sense to me now.

Thanks for the clarification and I think the doc is ready for publication considering our agreement on the editorial nits.

- Ralph

> 
> 
> Nits/editorial comments:
> 
> > In section 3.2, it would reduce potential confusion to consistently name the header field referenced in each bullet; e.g.:
> >
> > OLD:
> >
> > o  P-Called-Party-ID: Delete statement that the header field can
> >    appear in SIP responses.  Add statement that the P-Called-Party-ID
> >    header field can appear in the SIP REFER method.
> >
> > NEW:
> >
> > o  P-Called-Party-ID: Delete statement that the P-Called-Party-ID
> >    header field can appear in SIP responses.  Add statement that
> >    the P-Called-Party-ID header field can appear in the SIP REFER method.
> 
> I’ll fix as suggested.
> 
> >Section 3.3.1:
> >
> >OLD:
> >
> >This following sections describe, for individual P- header fields,
> > the 3GPP use-cases that are base for the updates.
> >
> >NEW:
> >
> > The following sections describe, for individual P- header fields,
> > the 3GPP use-cases that are the basis for the updates.
> 
> I’ll fix as suggested.
> 
> > Section 3.3.2: uniformly capitalize "Network Provided Location Information".
> 
> I’ll fix as suggested.
> 
> > Section 3.3.2: 3GPP TS 23.228 needs a citation of the referenced document.
> 
> I’ll add the reference.
> 
> 
> Thanks!
> 
> Regards,
> 
> Christer
>