Re: [Gen-art] Gen-ART Last Call review of draft-ietf-isis-prefix-attributes-03

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Mon, 04 January 2016 03:53 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 947871B2A7B; Sun, 3 Jan 2016 19:53:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.5
X-Spam-Level:
X-Spam-Status: No, score=-14.5 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_HTML_ATTACH=0.01, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8IQkH0qxxraO; Sun, 3 Jan 2016 19:53:52 -0800 (PST)
Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 991621B2A78; Sun, 3 Jan 2016 19:53:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=28615; q=dns/txt; s=iport; t=1451879632; x=1453089232; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=xLxB8xIC0qukGiqBXsqdeqGGoYDLtCf2o2u+1Idjywg=; b=Fu5KOJmscoY+oPlJ/LCl2fcgfo5k4uq2SCl8Ib8QXWNACVlIvTk4QcRc lS0p+Z6nVIS3ESi6qAZX14kQQhRhD70rxrtVdV34STkLuGQxmR7WL0W0r YcncsMtXbosqfqirm0zLBiexcpMlRW+Jc0d7B3+Jh0VemybMDUm0LsqQw c=;
X-Files: wdiff draft-ietf-isis-prefix-attributes-03.txt draft-ietf-isis-prefix-attributes-04.txt.htm : 16473
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ACBABy7IlW/5pdJa1UCg6DLFJtBoQmhC2zcw6BZCKCGYNUAoEYOBQBAQEBAQEBgQqENAEBAQQtPgEKAwwEAgEIDgMEAQEBIAcHAjAUCQgCBAENBQgGBogbDr9XAQEBAQEBAQEBAQEBAQEBAQEBAQEBDwmGVoR/hCYGCwE1hE8Fh16FW4VRg3wBgnGCToJxgmWCNIFjFjSDfIc/gRqKR4NyASABQ4NMPnKDTjqBCAEBAQ
X-IronPort-AV: E=Sophos;i="5.20,519,1444694400"; d="htm'217?scan'217,208,217";a="58202649"
Received: from rcdn-core-3.cisco.com ([173.37.93.154]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jan 2016 03:53:50 +0000
Received: from XCH-RCD-003.cisco.com (xch-rcd-003.cisco.com [173.37.102.13]) by rcdn-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id u043roPT018210 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 4 Jan 2016 03:53:50 GMT
Received: from xch-aln-001.cisco.com (173.36.7.11) by XCH-RCD-003.cisco.com (173.37.102.13) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Sun, 3 Jan 2016 21:53:49 -0600
Received: from xch-aln-001.cisco.com ([173.36.7.11]) by XCH-ALN-001.cisco.com ([173.36.7.11]) with mapi id 15.00.1104.009; Sun, 3 Jan 2016 21:53:50 -0600
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Paul Kyzivat <pkyzivat@alum.mit.edu>, "draft-ietf-isis-prefix-attributes.all@ietf.org" <draft-ietf-isis-prefix-attributes.all@ietf.org>
Thread-Topic: Gen-ART Last Call review of draft-ietf-isis-prefix-attributes-03
Thread-Index: AQHRQaR+rYIB+bCFr0+n78SEagz4oZ7jwVqAgACh84CABXm30IAA1KaAgAAQ/gA=
Date: Mon, 04 Jan 2016 03:53:50 +0000
Message-ID: <1b41d2f42ebc48b99ad0812d1ff5db8f@XCH-ALN-001.cisco.com>
References: <56818AED.8090909@alum.mit.edu> <d4b8085a5e4c4087adfa44c0e8fbc4b4@XCH-ALN-001.cisco.com> <56843F07.4000606@alum.mit.edu> <fbac0b22d4f247abb6f88f47a0aeaf10@XCH-ALN-001.cisco.com> <56898941.8030804@alum.mit.edu>
In-Reply-To: <56898941.8030804@alum.mit.edu>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.24.64.27]
Content-Type: multipart/mixed; boundary="_002_1b41d2f42ebc48b99ad0812d1ff5db8fXCHALN001ciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/TN1DnRk0u-ygubNshVQRgziVVdo>
Cc: General Area Review Team <gen-art@ietf.org>
Subject: Re: [Gen-art] Gen-ART Last Call review of draft-ietf-isis-prefix-attributes-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2016 03:53:56 -0000

Paul -

Attached is a diff file w the changes I have made to address your comments. Please let me know if this suffices.

(co-authors - please let me know if you have any concerns regarding the proposed changes)

Thanx.

   Les


> -----Original Message-----
> From: Paul Kyzivat [mailto:pkyzivat@alum.mit.edu]
> Sent: Sunday, January 03, 2016 12:49 PM
> To: Les Ginsberg (ginsberg); draft-ietf-isis-prefix-attributes.all@ietf.org
> Cc: General Area Review Team
> Subject: Re: Gen-ART Last Call review of draft-ietf-isis-prefix-attributes-03
> 
> Hi Les,
> 
> Trimming to the relevant points:
> 
> On 1/3/16 9:27 AM, Les Ginsberg (ginsberg) wrote:
> 
> >> Note that at the end of the day my comments are just suggestions. You
> >> can act on them or not. They only become binding if the IESG decides
> >> to raise them.
> >
> > [Les:] I want you to know that I take your comments seriously - binding or
> not. You obviously invested time in reviewing - which I appreciate.
> 
> Thanks. Genart is educational for the reviewers (at least for me) because we
> are usually reviewing things we know nothing about! It often takes some
> sniffing around to gain enough context to do the review.
> 
> But I think that is the point of genart - to get a review from somebody who
> doesn't already know the subject.
> 
> >> Understood. But the abstract will be seen by many (like me) who don't
> >> fall into that category. They are left entirely in the dark about what this is
> about.
> >> Might it be something they *ought* to be interested in?
> >> After reading the abstract, the only clue I had about the scope of
> >> this document was the name of the wg from the draft name. And once
> >> this becomes an RFC that won't be available as a hint. I had to look
> >> up isis in the list of WGs to discover that this was in the routing
> >> area. Then I had to do more searching to figure out what IS-IS was about.
> >>
> >
> > [Les:] The title (even once it becomes an RFC) includes "IS-IS".  If you don't
> know that IS-IS is a routing protocol, do you think that further clarification is
> needed to help you understand that this isn't something which you are
> interested in reading?
> 
> It is sufficient to get people to stop reading and ignore it. Maybe that is
> enough.
> 
> But for the person who goes a step further and pulls the full document and
> still doesn't know, it would be nice to add an informative reference to the
> intro, to a base document for IS-IS. As best I can tell, the likely one is
> RFC1195. For example, revise the first sentence of the intro:
> 
>     There are existing use cases for IS-IS [RFC1195] in which knowing
>     additional attributes of a network prefix is useful.
> 
> >>> In regards to the term "prefix", you seem to be expecting the
> >>> document to
> >> define that term - but in looking at multiple RFCs I do not see
> >> precedent for that. It is part of the base knowledge that has been
> >> assumed that readers understand . Perhaps this is a bad practice -
> >> but if so there are many documents - not restricted solely to IS-IS
> >> related documents - that could be critiqued on this basis. I would
> >> ask that this comment be viewed in a larger context - I don't think
> >> this particular draft should be asked to deviate from common practice
> without larger guidance from the IETF community.
> >>
> >> Not a definition, just a disambiguation. Simply replacing "prefix"
> >> with "network prefix" would have met my need.
> >>
> >
> > [Les:] You are proposing that "prefix" be replaced by "network prefix"
> throughout the document?
> > This has not been done in any of the existing RFCs that I checked.
> 
> Not everywhere, just one or a few places - say in the abstract and the intro.
> 
> >>> In regards to "references to the Introduction", I emphasize that the
> >> Introduction is neither normative nor exhaustive. It is meant to
> >> provide some examples of cases where the information contained in the
> >> new advertisements could be useful. I therefore find that references
> >> to it would be inappropriate.
> >>
> >> I guess I wasn't clear. I was suggesting that reference(s) be added
> >> to the introduction. (References are not permitted in the abstract,
> >> but they are allowed in the intro.) A reference to the base
> >> specification for the internet version of IS-IS would have helped me.
> >>
> >
> > [Les:] I usually constrain references to those which are actually useful in the
> context of the topics being discussed in the draft. Base specifications are not
> directly referenced in this draft because we are extending TLVs which were
> defined in RFCs issued long after the base specifications were published.
> However, the following could be added to the introduction:
> >
> > "IS-IS is a link state routing protocol defined in [ISO10589] and [RFC1195].
> Extensions in support of advertising new forms of IP/IPv6 prefix reachability
> are defined in [RFC5305], [RFC5308], and [RFC5120]."
> >
> > Is this what you had in mind?
> 
> Yes.
> 
> 	Thanks,
> 	Paul
>