Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05

Mingui Zhang <zhangmingui@huawei.com> Wed, 23 September 2015 01:20 UTC

Return-Path: <zhangmingui@huawei.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF7141B3072; Tue, 22 Sep 2015 18:20:10 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.211
X-Spam-Level:
X-Spam-Status: No, score=-4.211 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9FxHbh5Dd3-t; Tue, 22 Sep 2015 18:20:09 -0700 (PDT)
Received: from lhrrgout.huawei.com (lhrrgout.huawei.com [194.213.3.17]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5EA411B306D; Tue, 22 Sep 2015 18:20:08 -0700 (PDT)
Received: from 172.18.7.190 (EHLO lhreml405-hub.china.huawei.com) ([172.18.7.190]) by lhrrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CBP60147; Wed, 23 Sep 2015 01:20:06 +0000 (GMT)
Received: from NKGEML403-HUB.china.huawei.com (10.98.56.34) by lhreml405-hub.china.huawei.com (10.201.5.242) with Microsoft SMTP Server (TLS) id 14.3.235.1; Wed, 23 Sep 2015 02:20:05 +0100
Received: from NKGEML512-MBX.china.huawei.com ([169.254.7.203]) by nkgeml403-hub.china.huawei.com ([10.98.56.34]) with mapi id 14.03.0235.001; Wed, 23 Sep 2015 09:19:59 +0800
From: Mingui Zhang <zhangmingui@huawei.com>
To: Donald Eastlake <d3e3e3@gmail.com>, Jari Arkko <jari.arkko@piuha.net>
Thread-Topic: Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05
Thread-Index: AQHQ4RO7GL3QfcPgCUuUTfg8C/4Zkp4lTBGwgAHysoCAD9O+AIAJPQUAgAEEbwCAAJVkgIADlx2AgAP4/mA=
Date: Wed, 23 Sep 2015 01:19:58 +0000
Message-ID: <4552F0907735844E9204A62BBDD325E787202FAA@nkgeml512-mbx.china.huawei.com>
References: <46A1A261-E9F4-414D-AAD8-9C85A8B53283@vigilsec.com> <4552F0907735844E9204A62BBDD325E7871A2CFE@nkgeml512-mbx.china.huawei.com> <CAF4+nEGAnyBVrv=Rbc0gfDijYsjraBW62ugC1Rwo07e6PSg_NA@mail.gmail.com> <53C61587-9F97-4664-9F84-603199B46D3E@vigilsec.com> <EBCEEEC6-1184-420F-BC8E-D19444A0A54A@piuha.net> <CAF4+nEEcz7fQLaXZSSGFrEECOfeLkhqUwrXbpjkxRnuybeefOA@mail.gmail.com> <F779EA16-6E52-46BA-A555-6485CCC7E459@piuha.net> <CAF4+nEHOPSaiA=s_BVNHCNBSdfDTRK3nG5cGtCSAW1XVT3AVkg@mail.gmail.com>
In-Reply-To: <CAF4+nEHOPSaiA=s_BVNHCNBSdfDTRK3nG5cGtCSAW1XVT3AVkg@mail.gmail.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.111.146.93]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/TO-6c7R-gHPkd5skJgo_MTiQsns>
Cc: IETF Gen-ART <gen-art@ietf.org>, IETF <ietf@ietf.org>, "draft-ietf-trill-pseudonode-nickname.all@ietf.org" <draft-ietf-trill-pseudonode-nickname.all@ietf.org>
Subject: Re: [Gen-art] Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Sep 2015 01:20:11 -0000

Hi Donald,

Thanks for the suggestion. That change will be incorporated in the new version.

Thanks,
Mingui

> -----Original Message-----
> From: Donald Eastlake [mailto:d3e3e3@gmail.com]
> Sent: Monday, September 21, 2015 4:39 AM
> To: Jari Arkko
> Cc: IETF Gen-ART; IETF; draft-ietf-trill-pseudonode-nickname.all@ietf.org
> Subject: Re: Gen-ART Review of draft-ietf-trill-pseudonode-nickname-05
> 
> On Fri, Sep 18, 2015 at 9:49 AM, Jari Arkko <jari.arkko@piuha.net> wrote:
> > Donald,
> >
> >>> (Maybe this helps: I’m not actually sure why in a k-element set you
> >>> order them based <something> mod k because that would seem to
> >>> produce likely duplicates. Since your backup option in the case of
> >>> duplicates is proper numeric sort, why just not do that and only
> >>> that? E.g. "RBridges are sorted in byte string ascending order by
> >>> their LAALP IDs, or if they are equal, by their System IDs
> >>> considered as unsigned integers.” But it could also be that it is
> >>> too early and I have not yet had enough Diet Coke…)
> >>
> >> I believe the idea is to quasi-randomize the order. The DF election
> >> is per VLAN and a goal is to spread the multicast traffic across the
> >> RBridges in the active-active edge group.
> >
> > It is a fine goal to randomise the order.
> >
> > My only observation of the current setup is that if you randomise a
> > k-element group through "mod k” operation, you will likely have some
> > number of collisions in the result. I don’t know enough about math to
> > calculate the percentage. But for the sake of argument, if k=2 it
> > seems that the likelihood of collision is 50%.
> >
> > And for every collision, your order becomes no longer random but
> > simply numerical order of the identifiers. In our degenerate
> > k=2 example it seems that in 50% of the cases you have a random order
> > and 50% of the cases you have numerical order. I’m sure there would be
> > other ways to randomise the order with less collisions, if avoiding
> > numerical order is important.
> 
> Well, the way to randomize the order with quite low probability of collisions is
> to sort by the hash of  (System IDj | LAALP IDi), for example SHA-1(System IDj
> | LAALP IDi). Ties could still be broken by System ID which is guaranteed to be
> unique but ties would be quite rare. This seems like a minor localized change.
> 
> > Jari
> 
> Thanks,
> Donald
> =============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  155 Beaver Street, Milford, MA 01757 USA  d3e3e3@gmail.com