Re: [Gen-art] Genart last call review of draft-ietf-lamps-documentsigning-eku-04

Lars Eggert <lars@eggert.org> Tue, 23 August 2022 15:35 UTC

Return-Path: <lars@eggert.org>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4F957C159496; Tue, 23 Aug 2022 08:35:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.107
X-Spam-Level:
X-Spam-Status: No, score=-7.107 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DOgob_k7njE7; Tue, 23 Aug 2022 08:35:22 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 25D91C14CE40; Tue, 23 Aug 2022 08:25:26 -0700 (PDT)
Received: from smtpclient.apple (unknown [217.149.135.167]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id F29E7270603; Tue, 23 Aug 2022 18:25:16 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1661268317; bh=cUVulgOc+HWUvmVNNItNTPp+PmglSP+l2eLwexqsAXI=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=kahRX1xXt30R9r6xtNv0s2mb3yZ0XlkzQK3O2ZIL+RNmIe11w+zLnLmpeSdjVjWnY zPcbdidZlAcyzqoEYv3irSYCsGQ56avh1mzvUoS+EsR86+zSVlBmyLZtxR0W8rgnMT wPBp5cjE8ck+dpx+wAVNEhsRu1q2+rJKLB2Gb7Vo=
Content-Type: multipart/signed; boundary="Apple-Mail=_2E58ADFF-4F35-4FFD-8AD9-8F027C73E32B"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <165990512033.41551.11873246377263870533@ietfa.amsl.com>
Date: Tue, 23 Aug 2022 17:25:16 +0200
Cc: gen-art@ietf.org, draft-ietf-lamps-documentsigning-eku.all@ietf.org, last-call@ietf.org, spasm@ietf.org
Message-Id: <6822530B-7F70-462F-984F-980C162E4C99@eggert.org>
References: <165990512033.41551.11873246377263870533@ietfa.amsl.com>
To: Dale Worley <worley@ariadne.com>
X-MailScanner-ID: F29E7270603.A3900
X-MailScanner: Not scanned: please contact your Internet E-Mail Service Provider for details
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/TPEtWDHBRywcyEsFG3JVv7U5eNA>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-lamps-documentsigning-eku-04
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2022 15:35:27 -0000

Dale, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2022-8-7, at 22:45, Dale Worley via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Dale Worley
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document:  draft-ietf-lamps-documentsigning-eku-04
> Reviewer:  Dale R. Worley
> Review Date:  2022-08-07
> IETF LC End Date:  2022-08-11
> IESG Telechat date:  (none)
> 
> Summary:
> 
>    This draft is basically ready for publication, but has nits that
>    should be fixed before publication.
> 
> The technical content of the draft is quite good, but there is an
> editorially critical issue regarding the allocation of the
> identifiers.  There are three places where "to be done" identifiers
> are specified:
> 
> 3.1.  Including the Extended Key Purpose for Document Signing in
> 
>     id-kp-documentSigning  OBJECT IDENTIFIER  ::=  { id-kp XX }
> 
> 8.2.  Informative References
> 
> Appendix A.  ASN.1 Module
>     DocSignEKU { iso(1) identified-organization(3) dod(6) internet(1)
>       security(5) mechanisms(5) pkix(7) id-mod(0)
>       id-mod-docsign-eku(TBD1) }
> 
>     id-kp-documentSigning OBJECT IDENTIFIER ::= { id-kp TBD2 }
> 
> However, section 7 "IANA Considerations" does not explicitly mention
> any of these substitutions.  Compare with
> e.g. draft-ietf-curdle-cms-chacha20-poly10305.  Section 7 does say
> that assignments need to be made to the appropriate registries but
> provides no reference or "Note to the Editor" what substitutions need
> to be made in the text.  Also, "XX" must be the same as "TBD2", but
> that is not specified.
> 
> There is also a redundant specification at the end of section 7,
> 
>   No further action is necessary by IANA.
> 
> Given that the previous sentences in the paragraph state that there
> are two actions and then enumerate them, adding a statement that there
> are no others is redundant.
> 
> [END]
> 
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art