Re: [Gen-art] Genart last call review of draft-ietf-isis-te-app-13

"Les Ginsberg (ginsberg)" <ginsberg@cisco.com> Fri, 29 May 2020 15:02 UTC

Return-Path: <ginsberg@cisco.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 041BA3A0A93; Fri, 29 May 2020 08:02:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.598
X-Spam-Level:
X-Spam-Status: No, score=-9.598 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=iUF80FRU; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=fbOqTxQZ
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IO-FAvwKSGOR; Fri, 29 May 2020 08:02:37 -0700 (PDT)
Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F3A443A0AC3; Fri, 29 May 2020 08:01:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2488; q=dns/txt; s=iport; t=1590764514; x=1591974114; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=eGGXrcTd4DvC4cPHv/gCyt8oMbq9tkXQAh9LMQrg4TY=; b=iUF80FRUt/6k5i7ROGZxJ10EUV+c72Z8qQHfOzbo9wVaYkJRhr263M0B GQ8Y0fKzz9JE/cRtO6+tlpiZgEntXT77E3pqzeyiFYV1EBB+w7n0RBP7J hR6eO6v74cPrXRoexQEDQOX0TrlyPPmGSWEjVf/C67xG23uleVgFBtyiE Y=;
IronPort-PHdr: 9a23:9jmPSRHerXQK9+bs7RYy0J1GYnJ96bzpIg4Y7IYmgLtSc6Oluo7vJ1Hb+e401QObUoDS6vYCgO3T4OjsWm0FtJCGtn1KMJlBTAQMhshemQs8SNWEBkv2IL+PDWQ6Ec1OWUUj8yS9Nk5YS8n7blzW5Ha16G1aFhD2LwEgIOPzF8bbhNi20Obn/ZrVbk1IiTOxbKk0Ig+xqFDat9Idhs1pLaNixw==
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CVBQC0ItFe/4YNJK1mHAEBAQEBAQcBARIBAQQEAQFAgUqBUFIHb1gvLIQlg0YDjUOYSYJSA1ULAQEBDAEBIwoCBAEBhEQCF4ILAiQ4EwIDAQELAQEFAQEBAgEGBG2FWQyFcgEBAQEDEhERDAEBKQ4BCwQCAQgRAwEBAQMCJgICAjAVCAgCBAENBQgagwWCSwMuAQ6lHQKBOYhhdoEygwEBAQWFOxiCDgMGgQ4qgmSJYRqBQT+BEUOCTT6CZwKBZ4MSM4ItjxGCXpExkCcKglSIMYtfhHmCZokGkiiQXYlzk30CBAIEBQIOAQEFgWoigVZwFYMkUBcCDZBADBeDT4UUhUJ0NwIGCAEBAwl8jFwBAQ
X-IronPort-AV: E=Sophos;i="5.73,449,1583193600"; d="scan'208";a="766228456"
Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 29 May 2020 15:01:53 +0000
Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by alln-core-12.cisco.com (8.15.2/8.15.2) with ESMTPS id 04TF1rk7027631 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 29 May 2020 15:01:53 GMT
Received: from xhs-rcd-001.cisco.com (173.37.227.246) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 29 May 2020 10:01:53 -0500
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xhs-rcd-001.cisco.com (173.37.227.246) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 29 May 2020 10:01:52 -0500
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 29 May 2020 11:01:52 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W7WXxqFSDu9Xuw9JqQYIckgIzv1imSw/qyni/dAOA5GLnRUMNt4oiwtrnXXvHad3o9XDAXtvQU9Tw56Y/pH0POaWhTbc1Yu3SvO81Hu3wkC5spTv+sORAWhsG95ZkpyTu87Oc7cds+bpuwPUz0vSaj6ltX0uAH6+K32ennMf71DoJMn2X5Rrw6wzxlYq33QMMCGInSrnXtZP5xyoRmPBvlmgp/cqIck5Kb3QWyduFPeFUlD21Y1OY810FezG/clHEox9H/rMuE/4tVoqVyJVe4o0nvDz9E2xPRFeuFXZvm+g6K+UsPn3xDNcZ4AR/lInT+/v/coiMefLDeGkbC7pRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eGGXrcTd4DvC4cPHv/gCyt8oMbq9tkXQAh9LMQrg4TY=; b=SeHqi1LzXpAYQoCVSu9RnIwFxaQXut9eOefYr/a5vFWG13XHL031Vune1akv1fmVhSC415yOE+YxcfLuTVxC2SGTjJCYGUYEsr5FUFPVMOJVfFJWQPAcIM0aPWDBFX1rREmEvmYDupUXHYHszVn9205iOxmLflYgoXfKjrKEH3uJoaiBdU3pkDQ+I/p5F6aY9zHzAGEHZsbclEg9xjSCuUvYJR9t8417+McrW+OadNvEQXdduk3umjxOW3mfEQQHI2g5tYhsjJC8nkrE0RQaJaifZpz+db3Uf/y4FtCOhFAU1m5gAQ0CWhp7sIuC6ceuqUBcoWyY3Qd50lxzu02RCw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eGGXrcTd4DvC4cPHv/gCyt8oMbq9tkXQAh9LMQrg4TY=; b=fbOqTxQZ7F1ATPKd7FgTl+U2LKr0g/p4hnR+BgHB3MDhAfHmQusK1xfBT0d9Q+R1X68pSg7Mykg2S5hrZ2AQl4rN35/el7CJH7hOHlnowkChZB/wwvhln9pedmMua4usr+YXLpCM9RIyVmvpSut3Ii3MNWSQkQN0qG9cOqrAdBs=
Received: from MW3PR11MB4619.namprd11.prod.outlook.com (2603:10b6:303:5b::15) by MW3PR11MB4636.namprd11.prod.outlook.com (2603:10b6:303:5a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.19; Fri, 29 May 2020 15:01:51 +0000
Received: from MW3PR11MB4619.namprd11.prod.outlook.com ([fe80::c4d2:505c:a6bf:21a6]) by MW3PR11MB4619.namprd11.prod.outlook.com ([fe80::c4d2:505c:a6bf:21a6%7]) with mapi id 15.20.3045.018; Fri, 29 May 2020 15:01:51 +0000
From: "Les Ginsberg (ginsberg)" <ginsberg@cisco.com>
To: Jouni Korhonen <jouni.nospam@gmail.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "draft-ietf-isis-te-app.all@ietf.org" <draft-ietf-isis-te-app.all@ietf.org>, "lsr@ietf.org" <lsr@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-isis-te-app-13
Thread-Index: AQHWNbqO1Qr5c/rwNEyDKM3wnwyECai/KGMg
Date: Fri, 29 May 2020 15:01:51 +0000
Message-ID: <MW3PR11MB461943D56D2BA0CD551230A6C18F0@MW3PR11MB4619.namprd11.prod.outlook.com>
References: <159075783492.5716.1349202383488874383@ietfa.amsl.com>
In-Reply-To: <159075783492.5716.1349202383488874383@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [2602:306:36ca:6640:11de:d064:36a4:d951]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4bdf19ce-d680-4420-3353-08d803e13824
x-ms-traffictypediagnostic: MW3PR11MB4636:
x-microsoft-antispam-prvs: <MW3PR11MB463694ACFF301F7053E4DD41C18F0@MW3PR11MB4636.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:5797;
x-forefront-prvs: 04180B6720
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8whxvuwXNMyOhbIGEi+u3GWaRoLhGfenKbB+nELQRAf3fim3GILBOb/jKBBaPiUtBxyXff5YQjGSJq2LXqJENtC5eZhbP4jvCG27V/ke2HhU5ldVwrSpJLyHbo/oVTfrFDo2YOes/YJqYXANRLu7qbx2O3TZvT9DVWNxXx+UndEhgV9pntWxdhX3kYxstJd220lz02IekkIMfC/1QlVDAsnkNbspJYKebSlCCavzhNfHe1V3/rsoUPtgDtve1Hd6nIwDibzX/rjvrFtQ4dx/26/rHERRrmWKTDU/reGY96ONp1p/m3DMcK3oKeyFsIkkkAaxk+y2duxIJ7p4OS9NLb/Ex3zv9PtRCyq1FV+f1eTZ4rXWsaBbfCmIV4qF6lXYHAzTp5yfHMXxHi7v/ABrdg==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR11MB4619.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(86362001)(71200400001)(76116006)(33656002)(9686003)(478600001)(186003)(53546011)(4326008)(83380400001)(6506007)(7696005)(8936002)(5660300002)(54906003)(52536014)(316002)(8676002)(66946007)(64756008)(110136005)(66446008)(66476007)(55016002)(2906002)(66556008); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: 6wejl38VOkCV7raa9W7EpBXUJPwub5iybswuhfdq6AOphN7icJMw6hAJ415cWv73a/ysjAZcIS79xzhVpfz3S0c9aFzikJAuSP8SScbv+EiWOjfx88x+jPzu2Q6MpoY6fZYs5KnIcGVXNv0G4XtWSsHmLrlkSEhsgeRcgk1HJ8Rb2435ednpyqRCTCtZVyNJnZncI7bKLMowqmEcVW4+hpxdcIgpEtT/PNytaZRGsQVJbYXa8V7vfD0eOcSVzPGBmAQcJTHYyhY9N4C8CGSUZOkpdyQ72mDpSAYhMrXEZZci8Z0/LdW44+g8IA+wg+aQF/ZsmvWD6KFxsvajscHeBcfE44oQkeLzzDBoO7gcbpgb/7+vZCF780bITRmc8IOX8UYZnowtkL7wbYl/uv+zE5V1RIgDxXy1aE9+9KxmFF9W8rmXfsh/NrKzIaV8cw2t/g94Zy3y46JZ46ZW33yhUUX7YqCYxtoer8/JRT+C3ZuJTi3gGn+rE/cADB3cfGCvKQfGkEmcfe6oxSdl17DuSbC/+sHrhsSXLr73KlckD1iYOkxuwwb2/mbjzcgUW8Y/
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bdf19ce-d680-4420-3353-08d803e13824
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2020 15:01:51.5395 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3cKelrh3Gs39y4jnt2PvJoREZZHYHnTftZ6/Ig0FsyvyCf9tEAEgO0ZUL8adYBkdEpzulA71Cx+rtaHWGwH+Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4636
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.36.7.14, xch-aln-004.cisco.com
X-Outbound-Node: alln-core-12.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/TWDv-PqpT3BZEgTKHnTeH0Vjgp8>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-isis-te-app-13
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 May 2020 15:02:39 -0000

Jouni -

Thanx for the review.

I have addressed the editorial issues you raised - though I will wait for additional comments from other reviewers before publishing a new version.

   Les


> -----Original Message-----
> From: Jouni Korhonen via Datatracker <noreply@ietf.org>
> Sent: Friday, May 29, 2020 6:11 AM
> To: gen-art@ietf.org
> Cc: last-call@ietf.org; draft-ietf-isis-te-app.all@ietf.org; lsr@ietf.org
> Subject: Genart last call review of draft-ietf-isis-te-app-13
> 
> Reviewer: Jouni Korhonen
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-isis-te-app-??
> Reviewer: Jouni Korhonen
> Review Date: 2020-05-29
> IETF LC End Date: 2020-05-29
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary:
> 
> Not really my area of expertise, however, I did not spot any issues during the
> review. The document is ready for publication.
> 
> Major issues:
> 
> None.
> 
> Minor issues:
> 
> None.
> 
> Nits/editorial comments:
> 
> * There are spacing issues mostly with parenthesis in the text that the RFC
> editor likely takes care of. * On line 165 SR is used without expanding it. The
> expansion is obvious but the RFC has both "Segment Routing" and "Shared
> Risk"
> used with SRxx.. * At least Section 5 has "is NOT" and "does NOT" emphasis
> used. I would use just "is not" and "does not", since those with "NOT" are
> not
> in listed in normal "Requirements Language".
>