Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-dnsop-iana-class-type-yang-02

Joel Halpern Direct <jmh.direct@joelhalpern.com> Mon, 17 May 2021 13:01 UTC

Return-Path: <jmh.direct@joelhalpern.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5E0023A371A; Mon, 17 May 2021 06:01:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.801
X-Spam-Level:
X-Spam-Status: No, score=-2.801 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=joelhalpern.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iUOpg4h4wfHB; Mon, 17 May 2021 06:01:36 -0700 (PDT)
Received: from maila2.tigertech.net (maila2.tigertech.net [208.80.4.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 881973A3709; Mon, 17 May 2021 06:01:36 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by maila2.tigertech.net (Postfix) with ESMTP id 4FkK5X0Zdgz6GBSp; Mon, 17 May 2021 06:01:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelhalpern.com; s=2.tigertech; t=1621256496; bh=3au6/W89uA07dSg1HqB1sGUcGS3ODiwTLffOY1MgtCo=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Arifp/pJGBn3/ITz4qBMQqw1oMPOMrr6LnU33L4NAO8ELLlRTVRphWrrGhNS+ghFM X4izShBNg7T+ujExvPVd+HlCzDRsxXHRE9xS1cGiQaOkcK6K1pKFu0ILhwSNoir1rv N3lhz8Iv8To1Nmi1uNTSXzlXIi7ClYdggQRyRFe4=
X-Quarantine-ID: <xf3o9NS9Qxdf>
X-Virus-Scanned: Debian amavisd-new at a2.tigertech.net
Received: from [192.168.128.43] (unknown [50.225.209.66]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by maila2.tigertech.net (Postfix) with ESMTPSA id 4FkK5W0LNnz6GBSn; Mon, 17 May 2021 06:01:34 -0700 (PDT)
To: Ladislav Lhotka <ladislav.lhotka@nic.cz>, gen-art@ietf.org
Cc: last-call@ietf.org, dnsop@ietf.org, draft-ietf-dnsop-iana-class-type-yang.all@ietf.org
References: <162102448453.25089.15077622369733772482@ietfa.amsl.com> <877djxk0n5.fsf@nic.cz>
From: Joel Halpern Direct <jmh.direct@joelhalpern.com>
Message-ID: <2dfdc051-d844-7ccd-678f-ab2aba31e922@joelhalpern.com>
Date: Mon, 17 May 2021 09:01:34 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <877djxk0n5.fsf@nic.cz>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/ThWIqoQP1FJoZU-uz13q5Z6-BtU>
Subject: Re: [Gen-art] [Last-Call] Genart last call review of draft-ietf-dnsop-iana-class-type-yang-02
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2021 13:01:51 -0000

Thank you Lada.
I had missed the union, reading the introductory material with more 
attention.
Glad to hear IANA did an early review.

Yours,
Joel

On 5/17/2021 8:25 AM, Ladislav Lhotka wrote:
> Hi Joel,
> 
> thanks for the review, please see my responses below.
> 
> Joel Halpern via Datatracker <noreply@ietf.org> writes:
> 
>> Reviewer: Joel Halpern
>> Review result: Ready with Issues
>>
>> I am the assigned Gen-ART reviewer for this draft. The General Area
>> Review Team (Gen-ART) reviews all IETF documents being processed
>> by the IESG for the IETF Chair.  Please treat these comments just
>> like any other last call comments.
>>
>> For more information, please see the FAQ at
>>
>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>>
>> Document: draft-ietf-dnsop-iana-class-type-yang-02
>> Reviewer: Joel Halpern
>> Review Date: 2021-05-14
>> IETF LC End Date: 2021-05-24
>> IESG Telechat date: Not scheduled for a telechat
>>
>> Summary: This document is ready for publication as a proposed standard.
>>
>> I do have two questions that I hope has already been considered by the WG and
>> is a non-issue.  See minor issues.
>>
>> Major issues:
>>
>> Minor issues: 1) I presume IANA has been involved in the development
>> of this document, and is willing to undertake the maintenance?  I
>> looked for but did not see where that was noted.
> 
> Yes, Michelle Cotton of IANA did an early review last year. One issue that remains to be decided has to do with the XSLT stylesheet that is intended to be used for generating the initial revision of the YANG module: is it to be removed before publication or not?
> 
>> 2) I question the use of enumerations for the content.  I understand
>> that since IANA will generate new YANG modules when there is a
>> change, the new models can have new values.  I am concerned that if
>> an implementation using the older schema reads data from a DNS
>> repository with updated entries (and the corresponding updated
>> version) the version skew will cause processing errors instead of
>> simply handing over the numeric value in a fashion that is
>> acceptable but not understood.
> 
> This is partly alleviated by the YANG union types "dns-class" and "rr-type" that should be used for configuration data: old clients can always use corresponding numeric values in place of unsupported enums.
> 
> If the module update rules of sec. 11 in RFC 7950 are observed, then the risk of interoperability issues is IMO reasonably low.
> 
> Lada
> 
>>
>> Nits/editorial comments:
>>
>>
>>
>