[Gen-art] Genart last call review of draft-kucherawy-dispatch-zstd-01
Vijay Gurbani <vkg@acm.org> Thu, 19 April 2018 14:54 UTC
Return-Path: <vkg@acm.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1D112124F57; Thu, 19 Apr 2018 07:54:35 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Vijay Gurbani <vkg@acm.org>
To: gen-art@ietf.org
Cc: ietf@ietf.org, draft-kucherawy-dispatch-zstd.all@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.78.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <152414967505.28757.13931035798486807912@ietfa.amsl.com>
Date: Thu, 19 Apr 2018 07:54:35 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/Tjfs_winDEbz1LJufdFCrNsvgtw>
Subject: [Gen-art] Genart last call review of draft-kucherawy-dispatch-zstd-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2018 14:54:35 -0000
Reviewer: Vijay Gurbani Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-kucherawy-dispatch-zstd-01 Reviewer: Vijay K. Gurbani Review Date: 2018-04-19 IETF LC End Date: 2018-04-23 IESG Telechat date: Not scheduled for a telechat Summary: Ready with 1 minor issue and some nits. Major issues: 0 Minor issues: 2 Nits/editorial comments: 3 Minor: - S4: "... and the usual precautions apply." Here, what are the "usual precautions"? Are they the ones enumerated below? If so, then perhaps restate as "... and the usual precautions apply, as enumerated below.". If the usual precautions are not enumerated below, then a reference should be provided to a resource(s) that enumerates such precautions. - S5: I am curious, why should we remove this section prior to publication? It contains pointers to code that is invaluable to implementors. At the most, I would advise excising company name (Facebook) from the section, but I would advocate strongly to retain this section as the draft becomes a RFC. Nits/Typos: - S2.1.1: The value of the magic number: 0xFD2FB528 --- is there any significance to it? Any insight on how you arrived at this will be interesting. (I am relating this magic number to the SIP magic cookie "z9hG4bK" which was chosen so that the probability was very small of older implementations to randomly pick a branch ID that started with these characters.) - S2.1.1: s/the origina/the original/ - S2.1.1.3.1.1: "Value ?0" --> should it be "Value 00"?
- [Gen-art] Genart last call review of draft-kucher… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ku… Yann Collet
- Re: [Gen-art] Genart last call review of draft-ku… Vijay Gurbani
- Re: [Gen-art] Genart last call review of draft-ku… Yann Collet
- Re: [Gen-art] Genart last call review of draft-ku… Alissa Cooper