[Gen-art] Review: draft-ietf-ipfix-flow-selection-tech-10.txt

"Joel M. Halpern" <jmh@joelhalpern.com> Fri, 23 March 2012 17:47 UTC

Return-Path: <jmh@joelhalpern.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB82321F8609 for <gen-art@ietfa.amsl.com>; Fri, 23 Mar 2012 10:47:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.265
X-Spam-Level:
X-Spam-Status: No, score=-102.265 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HursTo5oQMe8 for <gen-art@ietfa.amsl.com>; Fri, 23 Mar 2012 10:47:50 -0700 (PDT)
Received: from morbo.mail.tigertech.net (morbo.mail.tigertech.net [67.131.251.54]) by ietfa.amsl.com (Postfix) with ESMTP id 22DE521F8602 for <gen-art@ietf.org>; Fri, 23 Mar 2012 10:47:50 -0700 (PDT)
Received: from mailc2.tigertech.net (mailc2.tigertech.net [208.80.4.156]) by morbo.tigertech.net (Postfix) with ESMTP id 8127B55805E for <gen-art@ietf.org>; Fri, 23 Mar 2012 10:47:49 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mailc2.tigertech.net (Postfix) with ESMTP id 111F618035C; Fri, 23 Mar 2012 10:47:48 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at c2.tigertech.net
Received: from [10.216.6.78] (unknown [93.158.43.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailc2.tigertech.net (Postfix) with ESMTPSA id 27B1218035A; Fri, 23 Mar 2012 10:47:46 -0700 (PDT)
Message-ID: <4F6CB741.804@joelhalpern.com>
Date: Fri, 23 Mar 2012 13:47:45 -0400
From: "Joel M. Halpern" <jmh@joelhalpern.com>
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2
MIME-Version: 1.0
To: "A. Jean Mahoney" <mahoney@nostrum.com>, draft-ietf-ipfix-flow-selection-tech@tools.ietf.org
References: <4F6BB53A.3070609@nostrum.com>
In-Reply-To: <4F6BB53A.3070609@nostrum.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Romascanu, Dan \(Dan\)" <dromasca@avaya.com>, gen-art@ietf.org
Subject: [Gen-art] Review: draft-ietf-ipfix-flow-selection-tech-10.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Mar 2012 17:47:54 -0000

I am the assigned Gen-ART reviewer for this draft. For background on 
Gen-ART, please see the FAQ at 
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments 
you may receive.

Document: draft-ietf-ipfix-flow-selection-tech-10.txt
	Flow Selection Techniques
Reviewer: Joel M. Halpern
Review Date: 24-March-2012
IETF LC End Date: 11-April-2012
IESG Telechat date: N/A

Summary: This document is nearly ready for publication as a proposed 
standard.

Major issues:
	Should the hash functions identified in 6.1 for hash based filtering 
(BOB, IPSX, CRC-323) have references to their definitions?

Minor issues:
	The tracker does not indicate a document shepherd for this document.

	If compliance is a big issue, then this document is under-specified. 
FOr example, it says in section 5.1 "In order to be compliant with this 
document, at least the Property Match Filtering MUST be implemented." 
However, Property Match Filtering as defined in section 5.1.1 is a range 
of behaviors, so it is unclear which property tests must be supported 
(any, all possible?) in order to be compliant.


Nits/editorial comments: