Re: [Gen-art] Gen-ART review of draft-ietf-dnsop-edns-key-tag-03

Christer Holmberg <christer.holmberg@ericsson.com> Sun, 08 January 2017 19:50 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EFE641295BE for <gen-art@ietfa.amsl.com>; Sun, 8 Jan 2017 11:50:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.221
X-Spam-Level:
X-Spam-Status: No, score=-4.221 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B0QGgav0R758 for <gen-art@ietfa.amsl.com>; Sun, 8 Jan 2017 11:50:49 -0800 (PST)
Received: from sesbmg22.ericsson.net (sesbmg22.ericsson.net [193.180.251.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9AFA81295AD for <gen-art@ietf.org>; Sun, 8 Jan 2017 11:50:49 -0800 (PST)
X-AuditID: c1b4fb30-945fe70000007ae2-af-58729816e1bb
Received: from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39]) by (Symantec Mail Security) with SMTP id 54.7E.31458.61892785; Sun, 8 Jan 2017 20:50:47 +0100 (CET)
Received: from ESESSMB209.ericsson.se ([169.254.9.169]) by ESESSHC007.ericsson.se ([153.88.183.39]) with mapi id 14.03.0319.002; Sun, 8 Jan 2017 20:50:45 +0100
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "Wessels, Duane" <dwessels@verisign.com>
Thread-Topic: Gen-ART review of draft-ietf-dnsop-edns-key-tag-03
Thread-Index: AdJmtBrRcKGrJRV2SqOM8LzRCfS1UQBEl2uAAIhbkHA=
Date: Sun, 8 Jan 2017 19:50:44 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B4BF5D8FE@ESESSMB209.ericsson.se>
References: <7594FB04B1934943A5C02806D1A2204B4BF576B3@ESESSMB209.ericsson.se> <DCE5B83B-7B56-4C45-B9D5-14B4B46A6CB4@verisign.com>
In-Reply-To: <DCE5B83B-7B56-4C45-B9D5-14B4B46A6CB4@verisign.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.154]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42KZGbFdXVd8RlGEwcO9Nhbbnp5jsuj//4nJ 4uqrzywOzB5Llvxk8vhy+TObx67NDWwBzFFcNimpOZllqUX6dglcGRdvr2UsWKVS8WHvXsYG xi0yXYycHBICJhITFt9k6mLk4hASWMcocf74UzYIZzGjRGf/AsYuRg4ONgELie5/2iANIgI6 EnOXHGUFqWEWmMIo8XPCQ2aQhLCAg8TsvyvZIYocJG7f28sE0isiYCXx8WUwSJhFQEXi2fHb bCBhXgFfiYf/KiFWNTNKdO05BNbKCdT67UkXmM0oICbx/dQaJhCbWUBc4taT+UwQRwtILNlz nhnCFpV4+fgfK4StJLHo9meoeh2JBbs/sUHY2hLLFr4Gq+cVEJQ4OfMJywRG0VlIxs5C0jIL ScssJC0LGFlWMYoWpxYn5aYbGemlFmUmFxfn5+nlpZZsYgTGzsEtvw12ML587niIUYCDUYmH 90NwUYQQa2JZcWXuIUYJDmYlEd6/04BCvCmJlVWpRfnxRaU5qcWHGKU5WJTEec1W3g8XEkhP LEnNTk0tSC2CyTJxcEo1MBpzfJphoPfq8tcZV/4bsAXc0b3UscHtSJmzhJ7yOb+iBikzrtzI tfWPHJzkfIKjVjRaG03hrpq1rXteyLKMsOWp/L+Z/PZ6rg6+2mI3VZWli/2v6etERc9Jpy9d fPu6tH/HzZ2eb/Jdiw3uq00WWl1i9GL/1icVFntZuFe0G6gWBEczuu/cpMRSnJFoqMVcVJwI AFwzwhmZAgAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/U4uuufoilcim8L90tKHRfLs8xNs>
Cc: "gen-art@ietf.org" <gen-art@ietf.org>, "draft-ietf-dnsop-edns-key-tag.all@tools.ietf.org" <draft-ietf-dnsop-edns-key-tag.all@tools.ietf.org>
Subject: Re: [Gen-art] Gen-ART review of draft-ietf-dnsop-edns-key-tag-03
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Jan 2017 19:50:52 -0000

Hi Duane,

I am happy with your suggestions on how to address my issues.

Thanks!

Regards,

Christer

-----Original Message-----
From: Wessels, Duane [mailto:dwessels@verisign.com] 
Sent: 05 January 2017 23:42
To: Christer Holmberg <christer.holmberg@ericsson.com>
Cc: gen-art@ietf.org; draft-ietf-dnsop-edns-key-tag.all@tools.ietf.org
Subject: Re: Gen-ART review of draft-ietf-dnsop-edns-key-tag-03


> On Jan 4, 2017, at 10:24 AM, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> 
> I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>
> 
> Document:                       draft-ietf-dnsop-edns-key-tag-03.txt
> Reviewer:                         Christer Holmberg
> Review Date:                   4 January 2017
> IETF LC End Date:           10 January 2017
> IETF Telechat Date:        19 January 2017
> 
> Summary: The document is well written, and almost ready for publication. However, I have one issue, and a few minor editorial issues in the Abstract/Introduction that I ask the authors to address.
> 

Thank you for the review!


> Major Issues:
> 
> Q1_Abstract:
> ------------------
> 
> The text says:
> 
>   "The reason there are two methods instead of one is some people see significant problems with each method."
> 
> This text looks very strange to an outsider like myself. I can understand that people sometimes have different preferences, but when you say "people see significant problems" it makes me wonder why a publication request has been done in the first place. Don't we normally publish RFCs because we want to SOLVE problems - not because we want to (at least not intentionally) create new ones? :)
> 
> I think it would be good to talk about people having different preferences (and within the document the reasons can be described in more detail) instead of people seeing problems.
> 
> Also, I am not sure whether the Abstract needs to talk about the reason for having two methods. I think  a statement saying that the background and reason for two methods are described within the document would be enough within the Abstract.

Agreed.  I've removed that second paragraph and modified the first (now only) paragraph of the Abstract to read:

   This document specifies two different
   ways for validating resolvers to signal to a server which keys are
   referenced in their chain-of-trust (see Section 1.1 for the
   rationale).  The data from such signaling allow zone administrators
   to monitor the progress of rollovers in a DNSSEC-signed zone.



> 
> 
> Minor Issues: Note
> 
> 
> Editorial Issues:
> 
> Q2_Section_1:
> --------------------
> 
> In order to use consistent terminology, please replace "This draft" with "This document".


Done.


> 
> 
> Q3_Section_1:
> --------------------
> 
> The text says:
> 
> "This is done in two ways:"
> 
> I suggest to replace the text with the statement found in the Abstract:
> 
>   "This document describes two independent methods for validating
>   resolvers to publish their referenced keys:"

Edited so that paragraph now reads:

   This document specifies how validating resolvers can tell a server,
   in a DNS query, which DNSSEC key(s) they would use to validate the
   server's responses.  It describes two independent methods for
   conveying Key Tag information bewteen clients and servers: ...



> 
> Q4_Section_1-1:
> ----------------------
> 
> The text says:
> 
>   "Initially this document was named draft-edns-key-tag and proposed
>   including Key Tag values in a new EDNS(0) option code.  It was
>   modeled after [RFC6975], which provides DNSSEC algorithm signaling."
> 
> Why do you include the name of the initial draft? Initial drafts can be called anything. I think it is enough to instead talk about the initially suggested mechanism. Something like:
> 
>   "Initially, when the work on this document started, it proposed
>   including Key Tag values in a new EDNS(0) option code.  It was
>   modeled after [RFC6975], which provides DNSSEC algorithm signaling."

Done.


> 
> 
> Q5_Section_1-1:
> ----------------------
> 
> The text says:
> 
> "The authors received feedback from Working Group participants"
> 
> Please write the name of the Working Group. The name of the WG is currently only mentioned in the Acknowledgements.
> 

Done.


DW