Re: [Gen-art] Genart last call review of draft-ietf-ipwave-ipv6-over-80211ocb-46

NABIL BENAMAR <n.benamar@est.umi.ac.ma> Mon, 17 June 2019 09:48 UTC

Return-Path: <n.benamar@est.umi.ac.ma>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA2F012011E for <gen-art@ietfa.amsl.com>; Mon, 17 Jun 2019 02:48:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.897
X-Spam-Level:
X-Spam-Status: No, score=-1.897 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=est-umi-ac-ma.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lDxNjE_yO3Sb for <gen-art@ietfa.amsl.com>; Mon, 17 Jun 2019 02:48:33 -0700 (PDT)
Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 05B7B12011C for <gen-art@ietf.org>; Mon, 17 Jun 2019 02:48:33 -0700 (PDT)
Received: by mail-io1-xd34.google.com with SMTP id w25so19705072ioc.8 for <gen-art@ietf.org>; Mon, 17 Jun 2019 02:48:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=est-umi-ac-ma.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=r/mzHri5/q63Uw4ecIynjWc8SvxpQu9zfLuD3asAvek=; b=fZij5y+4B3puiQt3QrtSKkCHBv1+eUaPF5AGXaeA4zQMhjmd8zaEvvF7w9GCEIQEvJ BQPvF8hYIlW41baMM0xcNcX/Q3mtYYvL9vTrxWre0Zg36WtlmKY2tWANF3XWSUJT5YRi iPMpVayKxBynOhApJpQ8enSXpvz/hRqgamtFiggVqCVmYYrlUMzz7wmKGNZ7FaIaUFEd rNj1uHyN+2GmvrhZKfyJT0c/BqOOM0DPnrtuV77syzKUvDbwdCGnmSjh1SqwbrKHdHaq 2qtkw62xiABjZT0oQ1jyFBftw+t43FSMd2d5n8kXEHcgi5ulKfLeqSt+D9pzGzJnoIKt og6w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r/mzHri5/q63Uw4ecIynjWc8SvxpQu9zfLuD3asAvek=; b=B2HCY5eF4CMdaIWaRH3Ye+A6u5RA8lmUzIXcVwL6o69NviG0AvrnnVf6pkN/JkZYMI jsSiCWVmudbZbZ05PzgLsnDyPl1/RZ59XYV9yJxogPiYRZhAA2MgGEZfpT75PrxxipW9 oyafnkFF+iktUGOIh4e2YNHvyLqJVvcuPmqIZMcP6qZix9F9UNsnpVgdvmLKo3Igcopu M90gBDu4P/c0jQBPh10kdMQPDpoapgdm0Z0N1ztV9eG9qOAaL4yBnSxVZC0m2dRPSyoH peCC+nrQQ9Ma3YI+yFt0lMd8EOiqsRDHjNciazlejKekoDS9JU2zbSXpBsKYyH0KVl84 03qg==
X-Gm-Message-State: APjAAAXM1QXILQp+wYQvTsdJq9CGKb70aaQw6TF2fNUNoFeNrbOr6eyi daRyFlzGxr6xdWv7xRjYqESWDk3rKiV27QWkLUcTEA==
X-Google-Smtp-Source: APXvYqwxdaILctqwKgZI0fLe/PJbdzX8Bi5hE5E6rwe2WulGtwZrqQy9ZY7Jy6X6hImVr4NBJAkYWdaQ+f4GCG8eEmo=
X-Received: by 2002:a5d:8252:: with SMTP id n18mr1744ioo.230.1560764912225; Mon, 17 Jun 2019 02:48:32 -0700 (PDT)
MIME-Version: 1.0
References: <156067514313.12185.6559961431451739070@ietfa.amsl.com>
In-Reply-To: <156067514313.12185.6559961431451739070@ietfa.amsl.com>
From: NABIL BENAMAR <n.benamar@est.umi.ac.ma>
Date: Mon, 17 Jun 2019 10:48:21 +0100
Message-ID: <CAD8vqFcngv75CvQTSY1vnL1TsLWoFVtw8b_q6hvBRRdSMDZZsw@mail.gmail.com>
To: Roni Even <ron.even.tlv@gmail.com>
Cc: gen-art@ietf.org, IETF Discussion <ietf@ietf.org>, its@ietf.org, draft-ietf-ipwave-ipv6-over-80211ocb.all@ietf.org
Content-Type: multipart/alternative; boundary="0000000000002bf215058b81e688"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/V1wzzfbxZMf65Em_ruJirCZWqQo>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-ipwave-ipv6-over-80211ocb-46
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Jun 2019 09:48:37 -0000

Dear Roni,

Thank you for your review.
Please, see my answers below.






On Sun, Jun 16, 2019, 09:52 Roni Even via Datatracker <noreply@ietf.org>
wrote:

> Reviewer: Roni Even
> Review result: Almost Ready
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-ipwave-ipv6-over-80211ocb-??
> Reviewer: Roni Even
> Review Date: 2019-06-16
> IETF LC End Date: 2019-06-26
> IESG Telechat date: Not scheduled for a telechat
>
> Summary:
> The document is almost ready for publication as a standard track RFC
>
> Major issues:
>
> Minor issues:
>
> 1. Section 4.2  says "IP packets MUST be transmitted over 802.11-OCB media
> as
> QoS Data" while appendix F say "The STA may send data frames of subtype
> Data,
> Null, QoS Data, and
>       QoS Null.
>

I will update the appendix to reflect the text in section 4.2.

>
> 2. In section 5.2 "The policy dictating when the MAC address is changed on
> the
> 802.11-OCB interface is to-be-determined.". Reading the next sentence it
> looks
> to me that this is needed as part of the solution and should not be left
> for
> the unknown future.
>

Should we reformulate here?

>
> 3. In Appendix I 4th paragraph " However, this does not apply if TBD TBD
> TBD. "
> . What are the TBDs?
>

The whole sentence will be removed.

>
> Nits/editorial comments:
> 1. In appendix I last paragraph "Support of RFC 8505 is may be implemented
> on
> OCB." should be "Support of RFC 8505 may be implemented on OCB." 2. In
> Appendix
> I "OCB nodes that support RFC 8505 would support the 6LN operation in
> order to
> act as a host".  I think that instead of "would" it should be "should"
> also if
> this is a recommendation why not have this paragraph not in an appendix
> with
> "MAY" and "SHOULD
>


Agreed.

>
>
>