Re: [Gen-art] Genart last call review of draft-ietf-tls-oldversions-deprecate-09

Stephen Farrell <stephen.farrell@cs.tcd.ie> Wed, 25 November 2020 11:48 UTC

Return-Path: <stephen.farrell@cs.tcd.ie>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9D0A83A0EC8; Wed, 25 Nov 2020 03:48:30 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cs.tcd.ie
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0P0aw65EZatn; Wed, 25 Nov 2020 03:48:28 -0800 (PST)
Received: from mercury.scss.tcd.ie (mercury.scss.tcd.ie [134.226.56.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1975E3A0FC5; Wed, 25 Nov 2020 03:48:00 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mercury.scss.tcd.ie (Postfix) with ESMTP id BA632BF1E; Wed, 25 Nov 2020 11:47:58 +0000 (GMT)
X-Virus-Scanned: Debian amavisd-new at scss.tcd.ie
Received: from mercury.scss.tcd.ie ([127.0.0.1]) by localhost (mercury.scss.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GVEMTmxZk-88; Wed, 25 Nov 2020 11:47:56 +0000 (GMT)
Received: from [10.244.2.119] (95-45-153-252-dynamic.agg2.phb.bdt-fng.eircom.net [95.45.153.252]) by mercury.scss.tcd.ie (Postfix) with ESMTPSA id 5BE8BBF1D; Wed, 25 Nov 2020 11:47:56 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cs.tcd.ie; s=mail; t=1606304876; bh=SoerinunlYKkgYCEdjmxEHRSok9dtYDVsNQcSe4qutM=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=vFZIJmaoSwOuvqMdJen4XDyD+EAZ6Le5xfkhSskbYlgEH+lbgvyNzTDMAW01ThKyM TRW080WStbeH6OsElI9w1DR26x45AYtHZ1XktSKzf1ZRzrl504eQ7X+Bq6WUTB91T/ ZcCCmORqhO7iJ8QQYyxiIqP9lJoOVQ9w0KhM4hZM=
To: Mohit Sethi <mohit.m.sethi@ericsson.com>, gen-art@ietf.org
Cc: draft-ietf-tls-oldversions-deprecate.all@ietf.org, last-call@ietf.org, tls@ietf.org
References: <160630477967.2358.18094644892598553198@ietfa.amsl.com>
From: Stephen Farrell <stephen.farrell@cs.tcd.ie>
Message-ID: <134de32a-87d2-853a-575f-2de2ccd973dc@cs.tcd.ie>
Date: Wed, 25 Nov 2020 11:47:55 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <160630477967.2358.18094644892598553198@ietfa.amsl.com>
Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PU78AD85yopWQIMdKZ23Urs5c1KvqXnMG"
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/V8Ublh0DiDZrLSKp4jrVQAdaisM>
Subject: Re: [Gen-art] Genart last call review of draft-ietf-tls-oldversions-deprecate-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Nov 2020 11:48:31 -0000


On 25/11/2020 11:46, Mohit Sethi via Datatracker wrote:
> Reviewer: Mohit Sethi
> Review result: Ready

Thanks. Will look at those nits when next editing.

Cheers,
S.

> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-tls-oldversions-deprecate-09
> Reviewer: Mohit Sethi
> Review Date: 2020-11-25
> IETF LC End Date: 2020-11-30
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: This document deprecates older versions of TLS and DTLS. It also
> updates many RFCs that normatively refer to the older TLS/DTLS versions.
> 
> Major issues: None
> 
> Minor issues: None
> 
> Nits/editorial comments: In section 1.1, typo in "waas defined to detect".
> 
> Most references to RFCs are of the form "[RFC7507]". Can we change "RFC 7457
> [RFC7457]" to "[RFC7457]" for uniformity. Similarly, perhaps you could change
> "RFC5246 [RFC5246]" and "RFC4346 [RFC4346]" to "[RFC5246]" and "[RFC4346]".
> 
> In section 2 "NIST for example have provided " should be "..has provided...".
> 
> In section 6 "this document is called out specifically to update text
> implementing the deprecation  recommendations of this document." I was
> initially confused with the repeated usage of "this". Perhaps it would help to
> be more explicit.
> 
>