[Gen-art] Gen-ART Last Call review of draft-ietf-behave-ipfix-nat-logging-06
Paul Kyzivat <pkyzivat@alum.mit.edu> Mon, 01 February 2016 20:53 UTC
Return-Path: <pkyzivat@alum.mit.edu>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C56C91B369A for <gen-art@ietfa.amsl.com>; Mon, 1 Feb 2016 12:53:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.235
X-Spam-Level:
X-Spam-Status: No, score=-1.235 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_SOFTFAIL=0.665] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MNvb_hbFr9cm for <gen-art@ietfa.amsl.com>; Mon, 1 Feb 2016 12:53:13 -0800 (PST)
Received: from resqmta-po-06v.sys.comcast.net (resqmta-po-06v.sys.comcast.net [IPv6:2001:558:fe16:19:96:114:154:165]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CC3461B3691 for <gen-art@ietf.org>; Mon, 1 Feb 2016 12:53:12 -0800 (PST)
Received: from resomta-po-01v.sys.comcast.net ([96.114.154.225]) by resqmta-po-06v.sys.comcast.net with comcast id D8sZ1s0094s37d4018tAaV; Mon, 01 Feb 2016 20:53:10 +0000
Received: from Paul-Kyzivats-MacBook-Pro.local ([73.218.51.154]) by resomta-po-01v.sys.comcast.net with comcast id D8t91s00F3KdFy1018t98o; Mon, 01 Feb 2016 20:53:10 +0000
From: Paul Kyzivat <pkyzivat@alum.mit.edu>
To: "draft-ietf-behave-ipfix-nat-logging.all@ietf.org" <draft-ietf-isis-prefix-attributes.all@ietf.org>
References: <56818AED.8090909@alum.mit.edu>
Message-ID: <56AFC5B4.8040602@alum.mit.edu>
Date: Mon, 01 Feb 2016 15:53:08 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <56818AED.8090909@alum.mit.edu>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1454359990; bh=VZA+KqymZWfJ+JlSBEkGp8YdrMs/ByFAnGItKZCQfkE=; h=Received:Received:From:Subject:To:Message-ID:Date:MIME-Version: Content-Type; b=fFypyoKyfR/ZBtg2bALew7eaOkmXNuUxAPuncJGA8gIiRNBFJADtxiLU6OO8i5Nsk NTnl1QWOTBnnyMqNWpRtTcOJ/nlQ7m5M15puaTM1wqXXiSWvgY6e0iXJmCIWKT20xs Zt2cJkxI4be7axDHg+iMv1+YwJtxvqU4UfDIXjfh0Drpj+LwfoZi6vmJcEkZkh+V4K jz2HE89O+0jqXgl3rsiQaWyf5uGR2yPiwZLeOKg2rMjlU552HV/hJZdKcZZV2sVqk5 f+E/KUa11tu7C1oAYu4VXEwUyVKA/uzu4fkO0j0jeofvPEvnKzAqJqxVVDU2Qg1DEK Sf0KxtdSO4plQ==
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/VJnYwPAsmfmFQLdaCJ0EHtxxFrs>
Cc: General Area Review Team <gen-art@ietf.org>
Subject: [Gen-art] Gen-ART Last Call review of draft-ietf-behave-ipfix-nat-logging-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Feb 2016 20:53:15 -0000
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Document: draft-ietf-behave-ipfix-nat-logging-06 Reviewer: Paul Kyzivat Review Date: IETF LC End Date: 2016-02-12 IESG Telechat date: Summary: This draft is on the right track but has open issues, described in the review. Major: 3 Minor: 5 Nits: 1 (Note: I've used Major for anything that is ambiguous, and Minor for things that are just unclear.) (1) Major: Section 5.2 starts with "The templates could contain a subset of the Information Elements(IEs) shown in Table 1 depending upon the event being logged." This is not a normative statement. It isn't clear what is normative regarding the use and content of templates. If I understand RFC7011, a NAT device can use any number of templates, and those templates can reference any defined IE. Is *this* document intended to *restrict* the form and number of templates used for logging NAT devices? Or is it simply suggesting some templates that may be modified as desired to fit the needs of a particular NAT device device? These templates do not have any Information Element that uniquely identifies to the IPFIX collector that this template is being used. So how does the collector know that the particular event is intended to follow the definitions in this draft, rather than simply some proprietary template? Absent that, how do normative statements of what must be in the template mean anything? (2) Major: As I understand it, Section 5.3 is defining valid values for the "natEvent" IE. That Information Element is already defined in the IANA registry, with values 1-3 that seem to correspond in semantics (but not name) to the first three values in Table 2. So I gather the intent is for Table 2 to replace what is currently in the registry for natEvent. But I find nothing in the IANA Considerations section that calls for updating that entry in the registry. The IANA Considerations section needs to request a revision to the definition of this element. (3) Major: Section 5.6 says: "Depending on the implementation and configuration various IE's specified can be included or ignored." What is the normative intent of this statement? Is it defining what is meant by the "Mandatory" field in the tables? (I.e., that in the templates it sends the NAT device MUST include fields with Mandatory=Yes but MAY omit fields with Mandatory=No.) This should be revised to make the normative behavior clearer. (4) Minor: The first sentence of Section 3 says: "This document focuses exclusively on the specification of IPFIX IE's." But this statement appears to be false. A large part of the document (Section 5.6) specifies Templates. It appears to be an important aspect of the document that goes beyond specifying just IEs. So the statement should be expanded. (5) Minor: The first paragraph of Section 5 has a reference to Section 4.1, but there is no such section in the document. Did this mean to refer to Table 2 in section 5.3? (6) Minor: Section 5.4 defines a set of values that are clearly intended to be conveyed in some IE. It calls them "sub event types for the Quota exceeded or Limits reached event". It does not name the IE. By examination of the templates I finally figured out that these are values for the "natLimitEvent" IE. This needs to be specified. (It is mentioned in the IANA considerations, but that is too late to help the reader.) Also, is this list of values intended to be extensible? Should the list be in the IANA registry, with Expert Review for additions to it? Or is it expected that this RFC will need to be revised to extend the list? This needs to be spelled out. (7) Minor: Section 5.5 has an analogous issue to the one above above about section 5.4, except that it pertains to the "natThresholdEvent" IE. (8) Minor: Section 9 appears to be normative, since it uses 2119 language. But it appears at a position in the document (after Acknowledgements and IANA Considerations, before Security Considerations), where I would normally not expect to find normative language. Perhaps this is intended to be more of an appendix. If so, then the normative language should be removed, and it ought to be formatted as an appendix. If it is intended to be normative, then I suggest that it be moved ahead of the Acknowledgements. (9) Nit: Running IDNits returns a number of issues, mostly regarding references. Please check these.
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Les Ginsberg (ginsberg)
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- [Gen-art] Gen-ART Telechat review of draft-ietf-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Les Ginsberg (ginsberg)
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Les Ginsberg (ginsberg)
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Xuxiaohu
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Uma Chunduri
- [Gen-art] Gen-ART Telechat review of draft-ietf-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Jari Arkko
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Paul Kyzivat
- [Gen-art] Gen-ART Last Call review of draft-ietf-… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Tal Mizrahi
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Tal Mizrahi
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Tal Mizrahi
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Tal Mizrahi
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Paul Kyzivat
- [Gen-art] Gen-ART Telechat review of draft-ietf-n… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-i… Jari Arkko
- [Gen-art] Gen-ART Last Call review of draft-alaku… Paul Kyzivat
- Re: [Gen-art] Gen-ART Last Call review of draft-a… Zoltan Szabadka
- Re: [Gen-art] Gen-ART Last Call review of draft-a… Paul Kyzivat
- [Gen-art] Gen-ART Telechat review of draft-alakui… Paul Kyzivat
- [Gen-art] Gen-ART Telechat review of draft-alakui… Paul Kyzivat
- Re: [Gen-art] Gen-ART Telechat review of draft-al… Jari Arkko
- [Gen-art] Gen-ART Telechat review of draft-ietf-b… Paul Kyzivat
- Re: [Gen-art] Gen-ART Telechat review of draft-ie… Jari Arkko